mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-27 21:03:32 +00:00
35732699f5
Linus reported that: After commita103f46633the kernel stopped compiling for several ARM32 platforms that I am building with a bare metal compiler. Bare metal compilers (arm-none-eabi-) don't define __linux__. This is because the header <acpi/platform/acenv.h> is now in the include path for <linux/irq.h>: CC arch/arm/kernel/irq.o CC kernel/sysctl.o CC crypto/api.o In file included from ../include/acpi/acpi.h:22, from ../include/linux/fw_table.h:29, from ../include/linux/acpi.h:18, from ../include/linux/irqchip.h:14, from ../arch/arm/kernel/irq.c:25: ../include/acpi/platform/acenv.h:218:2: error: #error Unknown target environment 218 | #error Unknown target environment | ^~~~~ The issue is caused by the introducing of splitting out the ACPI code to support the new generic fw_table code. Rafael suggested [1] moving the fw_table.h include in linux/acpi.h to below the linux/mutex.h. Remove the two includes in fw_table.h. Replace linux/fw_table.h include in fw_table.c with linux/acpi.h. Link: https://lore.kernel.org/linux-acpi/CAJZ5v0idWdJq3JSqQWLG5q+b+b=zkEdWR55rGYEoxh7R6N8kFQ@mail.gmail.com/ Fixes:a103f46633("acpi: Move common tables helper functions to common lib") Closes: https://lore.kernel.org/linux-acpi/20231114-arm-build-bug-v1-1-458745fe32a4@linaro.org/ Reported-by: Linus Walleij <linus.walleij@linaro.org> Suggested-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Tested-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Dave Jiang <dave.jiang@intel.com> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
40 lines
1.1 KiB
C
40 lines
1.1 KiB
C
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
/*
|
|
* fw_tables.h - Parsing support for ACPI and ACPI-like tables provided by
|
|
* platform or device firmware
|
|
*
|
|
* Copyright (C) 2001 Paul Diefenbaugh <paul.s.diefenbaugh@intel.com>
|
|
* Copyright (C) 2023 Intel Corp.
|
|
*/
|
|
#ifndef _FW_TABLE_H_
|
|
#define _FW_TABLE_H_
|
|
|
|
union acpi_subtable_headers;
|
|
|
|
typedef int (*acpi_tbl_entry_handler)(union acpi_subtable_headers *header,
|
|
const unsigned long end);
|
|
|
|
typedef int (*acpi_tbl_entry_handler_arg)(union acpi_subtable_headers *header,
|
|
void *arg, const unsigned long end);
|
|
|
|
struct acpi_subtable_proc {
|
|
int id;
|
|
acpi_tbl_entry_handler handler;
|
|
acpi_tbl_entry_handler_arg handler_arg;
|
|
void *arg;
|
|
int count;
|
|
};
|
|
|
|
union acpi_subtable_headers {
|
|
struct acpi_subtable_header common;
|
|
struct acpi_hmat_structure hmat;
|
|
struct acpi_prmt_module_header prmt;
|
|
struct acpi_cedt_header cedt;
|
|
};
|
|
|
|
int acpi_parse_entries_array(char *id, unsigned long table_size,
|
|
struct acpi_table_header *table_header,
|
|
struct acpi_subtable_proc *proc,
|
|
int proc_num, unsigned int max_entries);
|
|
|
|
#endif
|