mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-11-01 17:08:10 +00:00
60d1509533
We have added polled mode to the normal input devices with the intent of retiring input_polled_dev. This converts peaq-wmi driver to use the polling mode of standard input devices and removes dependency on INPUT_POLLDEV. Because the new polling coded does not allow peeking inside the poller structure to get the poll interval, we change the "debounce" process to operate on the time basis, instead of counting events. We also fix error handling during initialization, as previously we leaked input device structure when we failed to register it. Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Reviewed-by: Hans de Goede <hdegoede@redhat.com> Tested-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
128 lines
3.2 KiB
C
128 lines
3.2 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* PEAQ 2-in-1 WMI hotkey driver
|
|
* Copyright (C) 2017 Hans de Goede <hdegoede@redhat.com>
|
|
*/
|
|
|
|
#include <linux/acpi.h>
|
|
#include <linux/dmi.h>
|
|
#include <linux/input.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
|
|
#define PEAQ_DOLBY_BUTTON_GUID "ABBC0F6F-8EA1-11D1-00A0-C90629100000"
|
|
#define PEAQ_DOLBY_BUTTON_METHOD_ID 5
|
|
#define PEAQ_POLL_INTERVAL_MS 250
|
|
#define PEAQ_POLL_IGNORE_MS 500
|
|
#define PEAQ_POLL_MAX_MS 1000
|
|
|
|
MODULE_ALIAS("wmi:"PEAQ_DOLBY_BUTTON_GUID);
|
|
|
|
static struct input_dev *peaq_poll_dev;
|
|
|
|
/*
|
|
* The Dolby button (yes really a Dolby button) causes an ACPI variable to get
|
|
* set on both press and release. The WMI method checks and clears that flag.
|
|
* So for a press + release we will get back One from the WMI method either once
|
|
* (if polling after the release) or twice (polling between press and release).
|
|
* We ignore events for 0.5s after the first event to avoid reporting 2 presses.
|
|
*/
|
|
static void peaq_wmi_poll(struct input_dev *input_dev)
|
|
{
|
|
static unsigned long last_event_time;
|
|
static bool had_events;
|
|
union acpi_object obj;
|
|
acpi_status status;
|
|
u32 dummy = 0;
|
|
|
|
struct acpi_buffer input = { sizeof(dummy), &dummy };
|
|
struct acpi_buffer output = { sizeof(obj), &obj };
|
|
|
|
status = wmi_evaluate_method(PEAQ_DOLBY_BUTTON_GUID, 0,
|
|
PEAQ_DOLBY_BUTTON_METHOD_ID,
|
|
&input, &output);
|
|
if (ACPI_FAILURE(status))
|
|
return;
|
|
|
|
if (obj.type != ACPI_TYPE_INTEGER) {
|
|
dev_err(&input_dev->dev,
|
|
"Error WMBC did not return an integer\n");
|
|
return;
|
|
}
|
|
|
|
if (!obj.integer.value)
|
|
return;
|
|
|
|
if (had_events && time_before(jiffies, last_event_time +
|
|
msecs_to_jiffies(PEAQ_POLL_IGNORE_MS)))
|
|
return;
|
|
|
|
input_event(input_dev, EV_KEY, KEY_SOUND, 1);
|
|
input_sync(input_dev);
|
|
input_event(input_dev, EV_KEY, KEY_SOUND, 0);
|
|
input_sync(input_dev);
|
|
|
|
last_event_time = jiffies;
|
|
had_events = true;
|
|
}
|
|
|
|
/* Some other devices (Shuttle XS35) use the same WMI GUID for other purposes */
|
|
static const struct dmi_system_id peaq_dmi_table[] __initconst = {
|
|
{
|
|
.matches = {
|
|
DMI_MATCH(DMI_SYS_VENDOR, "PEAQ"),
|
|
DMI_MATCH(DMI_PRODUCT_NAME, "PEAQ PMM C1010 MD99187"),
|
|
},
|
|
},
|
|
{}
|
|
};
|
|
|
|
static int __init peaq_wmi_init(void)
|
|
{
|
|
int err;
|
|
|
|
/* WMI GUID is not unique, also check for a DMI match */
|
|
if (!dmi_check_system(peaq_dmi_table))
|
|
return -ENODEV;
|
|
|
|
if (!wmi_has_guid(PEAQ_DOLBY_BUTTON_GUID))
|
|
return -ENODEV;
|
|
|
|
peaq_poll_dev = input_allocate_device();
|
|
if (!peaq_poll_dev)
|
|
return -ENOMEM;
|
|
|
|
peaq_poll_dev->name = "PEAQ WMI hotkeys";
|
|
peaq_poll_dev->phys = "wmi/input0";
|
|
peaq_poll_dev->id.bustype = BUS_HOST;
|
|
input_set_capability(peaq_poll_dev, EV_KEY, KEY_SOUND);
|
|
|
|
err = input_setup_polling(peaq_poll_dev, peaq_wmi_poll);
|
|
if (err)
|
|
goto err_out;
|
|
|
|
input_set_poll_interval(peaq_poll_dev, PEAQ_POLL_INTERVAL_MS);
|
|
input_set_max_poll_interval(peaq_poll_dev, PEAQ_POLL_MAX_MS);
|
|
|
|
err = input_register_device(peaq_poll_dev);
|
|
if (err)
|
|
goto err_out;
|
|
|
|
return 0;
|
|
|
|
err_out:
|
|
input_free_device(peaq_poll_dev);
|
|
return err;
|
|
}
|
|
|
|
static void __exit peaq_wmi_exit(void)
|
|
{
|
|
input_unregister_device(peaq_poll_dev);
|
|
}
|
|
|
|
module_init(peaq_wmi_init);
|
|
module_exit(peaq_wmi_exit);
|
|
|
|
MODULE_DESCRIPTION("PEAQ 2-in-1 WMI hotkey driver");
|
|
MODULE_AUTHOR("Hans de Goede <hdegoede@redhat.com>");
|
|
MODULE_LICENSE("GPL");
|