linux-stable/drivers
Sven Anderson 35f4a0c441 [PATCH] USB: clean up all iPod models in unusual_devs.h
Phil Dibowitz wrote:
> 1. You're adding product IDs 1202, 1203, 1204, and 1205. 1203 was
> already there, but you remove it, OK, but 1205 is already there, so
> you'll need to fix that.

I was not removing 1203, it's just the extension of the bcd range. You are 
right about 1205, as I wrote, it was a patch against 2.6.11.7. Attached is 
a patch against 2.6.12-rc2.

> 2. I'm OK with the full bcd range if Apple is changing it on firmware
> revs... fine, but it's bcd, not hex... 0x9999 =)

I just copied from other entries. There're a lot 0xffffs in unusual_dev.h, 
so I assumed it is correct. I changed it to 0x9999.

> 3. It's rather obnoxious to take the original submitter's credit away.

I didn't remove it, I changed it to "based on...". Because I changed 
something (the range) in his entry, I thought it is the best to take the 
responsibility but keep the origin. Anyway, in the new patch I did it in a 
different way.

> 4. Your /proc/bus/usb/devices shows 1204, but I see no evidence 1202 is
> really an iPod.

I don't have an old iPod mini, but you find a lot of evidence here:

http://www.google.com/search?q=0x1202+ipod

Especially this one:

http://www.qbik.ch/usb/devices/showdescr.php?id=2737

> It also looks like 1205's entry is getting mangled, but I haven't
> attempted to apply the patch, so I'm not sure.

No, the patch was ok, but I agree it looks strange. It's not very 
readable, because I cannot tell diff to work blockwise instead of 
linewise. Because of the similarity of the entries, diff splits and merges 
them. Anyway, the new patch "looks" better. ;-)

Signed-off-by: Sven Anderson <sven-linux@anderson.de>
Signed-off-by: Phil Dibowitz <phil@ipom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2005-04-22 15:06:58 -07:00
..
acorn Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
acpi Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
atm Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
base [PATCH] kobject/hotplug split - devices core 2005-04-18 21:57:36 -07:00
block [PATCH] aoe 12/12: send outgoing packets in order 2005-04-18 22:00:22 -07:00
bluetooth Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
cdrom Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
char [PATCH] update maintainer for /dev/random 2005-04-16 15:25:56 -07:00
cpufreq Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
crypto Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
dio Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
eisa Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
fc4 Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
firmware Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
i2c [PATCH] I2C: Fix incorrect sysfs file permissions in it87 and via686a drivers 2005-04-18 21:16:59 -07:00
ide [PATCH] hd: eliminate bad section references 2005-04-16 15:25:52 -07:00
ieee1394 [PATCH] Fix non-legacy ISO receive regression 2005-04-21 14:09:42 -07:00
infiniband [PATCH] drivers/infiniband/hw/mthca/mthca_main.c: remove an unused label 2005-04-16 15:26:35 -07:00
input Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
isdn [PATCH] fix for ISDN ippp filtering 2005-04-21 08:30:30 -07:00
macintosh [PATCH] fix few remaining u32 vs. pm_message_t problems 2005-04-16 15:25:38 -07:00
mca Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
md [PATCH] md: remove a number of misleading calls to MD_BUG 2005-04-16 15:26:42 -07:00
media [PATCH] fix module_param_string() calls 2005-04-16 15:25:43 -07:00
message [PATCH] Convert i2o to compat_ioctl 2005-04-18 12:34:15 -05:00
misc Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
mmc [PATCH] fix u32 vs. pm_message_t in drivers/mmc,mtd,scsi 2005-04-16 15:25:29 -07:00
mtd [PATCH] fix u32 vs. pm_message_t in drivers/mmc,mtd,scsi 2005-04-16 15:25:29 -07:00
net [TG3]: Add msi test 2005-04-21 17:13:59 -07:00
nubus Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
oprofile Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
parisc Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
parport Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
pci [PATCH] fix u32 vs. pm_message_t in PCI, PCIE 2005-04-16 15:25:33 -07:00
pcmcia [PATCH] fix u32 vs. pm_message_t in pcmcia 2005-04-16 15:25:26 -07:00
pnp [PATCH] pnpbios: eliminate bad section references 2005-04-16 15:25:51 -07:00
s390 merge by hand (scsi_device.h) 2005-04-18 13:45:00 -05:00
sbus [SPARC]: Provide generic ioctls in Sparc RTC driver. 2005-04-21 21:42:34 -07:00
scsi [PATCH] Fix aic7xxx_osm.c compile with older gcc's 2005-04-21 07:35:45 -07:00
serial [SPARC64]: In sunsab driver, make sure to set the uart timeout. 2005-04-21 22:18:03 -07:00
sh Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
sn Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
tc Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
telephony Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
usb [PATCH] USB: clean up all iPod models in unusual_devs.h 2005-04-22 15:06:58 -07:00
video [PATCH] Fix tgafb.c compile failure 2005-04-21 14:09:42 -07:00
w1 [PATCH] w1_smem: w1 ID is only 8 bytes long. 2005-04-18 21:16:57 -07:00
zorro Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
Kconfig Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
Makefile Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00