mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-31 16:38:12 +00:00
0c2d696456
There are a few known (minor) problems with having the support code for both I2C
and SPI in the same module:
* We need to be extra careful to make sure to not build the driver into the
kernel if one of the subsystems is build as a module (Currently only I2C
can be build as a module).
* The module init path error handling is rather ugly. E.g. what should be
done if either the SPI or the I2C driver fails to register. Most drivers
that implement SPI and I2C in the same module currently fallback to
undefined behavior in that case. Splitting the the driver into two
modules, one for each bus, allows the registration of the other bus drive
to continue without problems if one of them fails.
This patch splits the ADAV80X driver into 3 modules. One core module that
implements the device logic, but is independent of the bus method used. And one
module for SPI and I2C each that registers the drivers and sets up the regmap
struct for the bus.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Mark Brown <broonie@linaro.org>
53 lines
1.1 KiB
C
53 lines
1.1 KiB
C
/*
|
|
* ADAV801 audio driver
|
|
*
|
|
* Copyright 2014 Analog Devices Inc.
|
|
*
|
|
* Licensed under the GPL-2.
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/spi/spi.h>
|
|
#include <linux/regmap.h>
|
|
|
|
#include <sound/soc.h>
|
|
|
|
#include "adav80x.h"
|
|
|
|
static const struct spi_device_id adav80x_spi_id[] = {
|
|
{ "adav801", 0 },
|
|
{ }
|
|
};
|
|
MODULE_DEVICE_TABLE(spi, adav80x_spi_id);
|
|
|
|
static int adav80x_spi_probe(struct spi_device *spi)
|
|
{
|
|
struct regmap_config config;
|
|
|
|
config = adav80x_regmap_config;
|
|
config.read_flag_mask = 0x01;
|
|
|
|
return adav80x_bus_probe(&spi->dev, devm_regmap_init_spi(spi, &config));
|
|
}
|
|
|
|
static int adav80x_spi_remove(struct spi_device *spi)
|
|
{
|
|
snd_soc_unregister_codec(&spi->dev);
|
|
return 0;
|
|
}
|
|
|
|
static struct spi_driver adav80x_spi_driver = {
|
|
.driver = {
|
|
.name = "adav801",
|
|
.owner = THIS_MODULE,
|
|
},
|
|
.probe = adav80x_spi_probe,
|
|
.remove = adav80x_spi_remove,
|
|
.id_table = adav80x_spi_id,
|
|
};
|
|
module_spi_driver(adav80x_spi_driver);
|
|
|
|
MODULE_DESCRIPTION("ASoC ADAV801 driver");
|
|
MODULE_AUTHOR("Lars-Peter Clausen <lars@metafoo.de>");
|
|
MODULE_AUTHOR("Yi Li <yi.li@analog.com>>");
|
|
MODULE_LICENSE("GPL");
|