linux-stable/fs/overlayfs
Amir Goldstein 82a0e25734 ovl: relax WARN_ON() on rename to self
commit 6889ee5a53 upstream.

In ovl_rename(), if new upper is hardlinked to old upper underneath
overlayfs before upper dirs are locked, user will get an ESTALE error
and a WARN_ON will be printed.

Changes to underlying layers while overlayfs is mounted may result in
unexpected behavior, but it shouldn't crash the kernel and it shouldn't
trigger WARN_ON() either, so relax this WARN_ON().

Reported-by: syzbot+bb1836a212e69f8e201a@syzkaller.appspotmail.com
Fixes: 804032fabb ("ovl: don't check rename to self")
Cc: <stable@vger.kernel.org> # v4.9+
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-12-17 19:56:11 +01:00
..
copy_up.c SPDX update for 5.2-rc6 2019-06-21 09:58:42 -07:00
dir.c ovl: relax WARN_ON() on rename to self 2019-12-17 19:56:11 +01:00
export.c ovl: Fix dereferencing possible ERR_PTR() 2019-09-11 16:11:45 +02:00
file.c SPDX update for 5.2-rc6 2019-06-21 09:58:42 -07:00
inode.c ovl: fix corner case of non-unique st_dev;st_ino 2019-12-17 19:56:10 +01:00
Kconfig treewide: Add SPDX license identifier - Makefile/Kconfig 2019-05-21 10:50:46 +02:00
Makefile treewide: Add SPDX license identifier - Makefile/Kconfig 2019-05-21 10:50:46 +02:00
namei.c ovl: fix lookup failure on multi lower squashfs 2019-12-17 19:56:10 +01:00
overlayfs.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00
ovl_entry.h ovl: fix lookup failure on multi lower squashfs 2019-12-17 19:56:10 +01:00
readdir.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00
super.c ovl: fix lookup failure on multi lower squashfs 2019-12-17 19:56:10 +01:00
util.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00