linux-stable/drivers/gpu/drm/vkms
Maxime Ripard 37418bf14c
drm: Use state helper instead of the plane state pointer
Many drivers reference the plane->state pointer in order to get the
current plane state in their atomic_update or atomic_disable hooks,
which would be the new plane state in the global atomic state since
_swap_state happened when those hooks are run.

Use the drm_atomic_get_new_plane_state helper to get that state to make it
more obvious.

This was made using the coccinelle script below:

@ plane_atomic_func @
identifier helpers;
identifier func;
@@

(
 static const struct drm_plane_helper_funcs helpers = {
 	...,
 	.atomic_disable = func,
	...,
 };
|
 static const struct drm_plane_helper_funcs helpers = {
 	...,
 	.atomic_update = func,
	...,
 };
)

@ adds_new_state @
identifier plane_atomic_func.func;
identifier plane, state;
identifier new_state;
@@

 func(struct drm_plane *plane, struct drm_atomic_state *state)
 {
 	...
-	struct drm_plane_state *new_state = plane->state;
+	struct drm_plane_state *new_state = drm_atomic_get_new_plane_state(state, plane);
	...
 }

@ include depends on adds_new_state @
@@

 #include <drm/drm_atomic.h>

@ no_include depends on !include && adds_new_state @
@@

+ #include <drm/drm_atomic.h>
  #include <drm/...>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://lore.kernel.org/r/20210219120032.260676-1-maxime@cerno.tech
2021-02-25 08:05:28 +01:00
..
Makefile drm/vkms: Switch to shmem helpers 2020-10-15 23:37:58 +02:00
vkms_composer.c drm/vkms: Switch to shmem helpers 2020-10-15 23:37:58 +02:00
vkms_crtc.c drm/vkms: Annotate vblank timer 2021-02-23 12:54:20 +01:00
vkms_drv.c drm/vkms: Fix missing kmalloc allocation failure check 2021-01-15 17:45:07 -03:00
vkms_drv.h drm/vkms: Add support for writeback module 2021-01-12 17:16:25 -03:00
vkms_output.c drm/vkms: Add support for writeback module 2021-01-12 17:16:25 -03:00
vkms_plane.c drm: Use state helper instead of the plane state pointer 2021-02-25 08:05:28 +01:00
vkms_writeback.c drm: Switch to %p4cc format modifier 2021-02-17 12:52:59 +01:00