Jules Irenge 390ba6a775 bpf: Fix resetting logic for unreferenced kptrs ... commit 9fad7fe5b2 upstream. Sparse reported a warning at bpf_map_free_kptrs() "warning: Using plain integer as NULL pointer" During the process of fixing this warning, it was discovered that the current code erroneously writes to the pointer variable instead of deferencing and writing to the actual kptr. Hence, Sparse tool accidentally helped to uncover this problem. Fix this by doing WRITE_ONCE(*p, 0) instead of WRITE_ONCE(p, 0). Note that the effect of this bug is that unreferenced kptrs will not be cleared during check_and_free_fields. It is not a problem if the clearing is not done during map_free stage, as there is nothing to free for them. Fixes: 14a324f6a6 ("bpf: Wire up freeing of referenced kptr") Signed-off-by: Jules Irenge <jbi.octave@gmail.com> Link: https://lore.kernel.org/r/Yxi3pJaK6UDjVJSy@playground Signed-off-by: Alexei Starovoitov <ast@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2022-10-12 09:39:04 +02:00
..
preload	bpf: iterators: Build and use lightweight bootstrap version of bpftool	2022-07-15 12:01:30 -07:00
arraymap.c	bpf: Acquire map uref in .init_seq_private for array map iterator	2022-08-10 10:12:47 -07:00
bloom_filter.c	bpf: Compute map_btf_id during build time	2022-04-26 11:35:21 -07:00
bpf_inode_storage.c	bpf: Compute map_btf_id during build time	2022-04-26 11:35:21 -07:00
bpf_iter.c	bpf: Only allow sleepable program for resched-able iterator	2022-08-10 10:12:48 -07:00
bpf_local_storage.c	bpf: Fix usage of trace RCU in local storage.	2022-04-19 17:55:45 -07:00
bpf_lru_list.c	bpf_lru_list: Read double-checked variable once without lock	2021-02-10 15:54:26 -08:00
bpf_lru_list.h	printk: stop including cache.h from printk.h	2022-05-13 07:20:07 -07:00
bpf_lsm.c	bpf: fix lsm_cgroup build errors on esoteric configs	2022-07-19 09:40:41 -07:00
bpf_struct_ops.c	bpf: Remove is_valid_bpf_tramp_flags()	2022-07-11 21:04:58 +02:00
bpf_struct_ops_types.h	bpf: Add dummy BPF STRUCT_OPS for test purpose	2021-11-01 14:10:00 -07:00
bpf_task_storage.c	bpf: Compute map_btf_id during build time	2022-04-26 11:35:21 -07:00
btf.c	bpf: btf: Fix vsnprintf return value check	2022-07-29 09:57:14 -07:00
cgroup.c	bpf, cgroup: Fix kernel BUG in purge_effective_progs	2022-08-18 23:27:33 +02:00
core.c	bpf: Fix a data-race around bpf_jit_limit.	2022-08-24 00:27:14 +02:00
cpumap.c	bpf: Compute map_btf_id during build time	2022-04-26 11:35:21 -07:00
devmap.c	bpf, devmap: Compute proper xdp_frame len redirecting frames	2022-07-26 16:26:19 +02:00
disasm.c	bpf: Relicense disassembler as GPL-2.0-only OR BSD-2-Clause	2021-09-02 14:49:23 +02:00
disasm.h	bpf: Relicense disassembler as GPL-2.0-only OR BSD-2-Clause	2021-09-02 14:49:23 +02:00
dispatcher.c
hashtab.c	bpf: Acquire map uref in .init_seq_private for hash map iterator	2022-08-10 10:12:47 -07:00
helpers.c	bpf: Gate dynptr API behind CAP_BPF	2022-10-12 09:39:04 +02:00
inode.c	bpf: Convert bpf_preload.ko to use light skeleton.	2022-02-10 23:31:51 +01:00
Kconfig	rcu: Make the TASKS_RCU Kconfig option be selected	2022-04-20 16:52:58 -07:00
link_iter.c	bpf: Add bpf_link iterator	2022-05-10 11:20:45 -07:00
local_storage.c	bpf: Make non-preallocated allocation low priority	2022-07-12 17:44:27 -07:00
lpm_trie.c	bpf: Make non-preallocated allocation low priority	2022-07-12 17:44:27 -07:00
Makefile	bpf: Add bpf_link iterator	2022-05-10 11:20:45 -07:00
map_in_map.c	bpf: Allow storing unreferenced kptr in map	2022-04-25 17:31:35 -07:00
map_in_map.h
map_iter.c	bpf: Introduce MEM_RDONLY flag	2021-12-18 13:27:41 -08:00
mmap_unlock_work.h	bpf: Introduce helper bpf_find_vma	2021-11-07 11:54:51 -08:00
net_namespace.c	net: Add includes masked by netdevice.h including uapi/bpf.h	2021-12-29 20:03:05 -08:00
offload.c
percpu_freelist.c	bpf: avoid grabbing spin_locks of all cpus when no free elems	2022-06-11 14:25:35 -07:00
percpu_freelist.h	bpf: Use raw_spin_trylock() for pcpu_freelist_push/pop in NMI	2020-10-06 00:04:11 +02:00
prog_iter.c
queue_stack_maps.c	bpf: Compute map_btf_id during build time	2022-04-26 11:35:21 -07:00
reuseport_array.c	net: Fix suspicious RCU usage in bpf_sk_reuseport_detach()	2022-08-17 16:42:59 -07:00
ringbuf.c	bpf: Dynptr support for ring buffers	2022-05-23 14:31:28 -07:00
stackmap.c	bpf: Compute map_btf_id during build time	2022-04-26 11:35:21 -07:00
syscall.c	bpf: Fix resetting logic for unreferenced kptrs	2022-10-12 09:39:04 +02:00
sysfs_btf.c	bpf: Load and verify kernel module BTFs	2020-11-10 15:25:53 -08:00
task_iter.c	bpf: Remove redundant assignment to meta.seq in __task_seq_show()	2022-04-11 21:14:34 +02:00
tnum.c	bpf, tnums: Provably sound, faster, and more precise algorithm for tnum_mul	2021-06-01 13:34:15 +02:00
trampoline.c	bpf: Cleanup ftrace hash in bpf_trampoline_put	2022-08-05 09:43:58 -07:00
verifier.c	bpf: Don't use tnum_range on array range checking for poke descriptors	2022-08-25 14:58:30 -07:00