Germano Percossi 395664439c Fix default behaviour for empty domains and add domainauto option ... With commit 2b149f119 many things have been fixed/introduced. However, the default behaviour for RawNTLMSSP authentication seems to be wrong in case the domain is not passed on the command line. The main points (see below) of the patch are: - It alignes behaviour with Windows clients - It fixes backward compatibility - It fixes UPN I compared this behavour with the one from a Windows 10 command line client. When no domains are specified on the command line, I traced the packets and observed that the client does send an empty domain to the server. In the linux kernel case, the empty domain is replaced by the primary domain communicated by the SMB server. This means that, if the credentials are valid against the local server but that server is part of a domain, then the kernel module will ask to authenticate against that domain and we will get LOGON failure. I compared the packet trace from the smbclient when no domain is passed and, in that case, a default domain from the client smb.conf is taken. Apparently, connection succeeds anyway, because when the domain passed is not valid (in my case WORKGROUP), then the local one is tried and authentication succeeds. I tried with any kind of invalid domain and the result was always a connection. So, trying to interpret what to do and picking a valid domain if none is passed, seems the wrong thing to do. To this end, a new option "domainauto" has been added in case the user wants a mechanism for guessing. Without this patch, backward compatibility also is broken. With kernel 3.10, the default auth mechanism was NTLM. One of our testing servers accepted NTLM and, because no domains are passed, authentication was local. Moving to RawNTLMSSP forced us to change our command line to add a fake domain to pass to prevent this mechanism to kick in. For the same reasons, UPN is broken because the domain is specified in the username. The SMB server will work out the domain from the UPN and authenticate against the right server. Without the patch, though, given the domain is empty, it gets replaced with another domain that could be the wrong one for the authentication. Signed-off-by: Germano Percossi <germano.percossi@citrix.com> Acked-by: Pavel Shilovsky <pshilov@microsoft.com> Signed-off-by: Steve French <smfrench@gmail.com>		2016-12-15 01:42:38 -06:00
..
9p	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
adfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
affs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
afs	afs: call->operation_ID sometimes used as __be32 sometimes as u32	2016-10-13 17:03:52 +01:00
autofs4	autofs: refactor ioctl fn vector in iookup_dev_ioctl()	2016-10-11 15:06:31 -07:00
befs	befs fixes for 4.9-rc1	2016-10-15 12:09:13 -07:00
bfs	Merge remote-tracking branch 'ovl/rename2' into for-linus	2016-10-10 23:02:51 -04:00
btrfs	Merge branch 'for-4.9-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux	2016-11-04 20:08:16 -07:00
cachefiles	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
ceph	ceph: use default file splice read callback	2016-11-10 20:13:04 +01:00
cifs	Fix default behaviour for empty domains and add domainauto option	2016-12-15 01:42:38 -06:00
coda	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
configfs	Merge remote-tracking branch 'ovl/rename2' into for-linus	2016-10-10 23:02:51 -04:00
cramfs
crypto	fscrypto: don't use on-stack buffer for key derivation	2016-11-19 20:56:13 -05:00
debugfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
devpts	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
dlm	dlm: free workqueues after the connections	2016-10-10 09:54:00 -05:00
ecryptfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
efivarfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
efs
exofs	fs: exofs: print a hex number after a 0x prefix	2016-10-27 18:43:43 -07:00
exportfs	exportfs: be careful to only return expected errors.	2016-10-06 09:07:44 -04:00
ext2	ext2: avoid bogus -Wmaybe-uninitialized warning	2016-10-18 11:29:35 +02:00
ext4	ext4: sanity check the block and cluster size at mount time	2016-11-19 20:58:15 -05:00
f2fs	This includes fixing a bug which references a wrong pointer, sum_page, in	2016-10-18 14:15:23 -07:00
fat	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
freevxfs
fscache
fuse	fuse: fix fuse_write_end() if zero bytes were copied	2016-11-15 12:34:21 +01:00
gfs2	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
hfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
hfsplus	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
hostfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
hpfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
hugetlbfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
isofs	isofs: add KERN_CONT to printing of ER records	2016-11-30 10:41:26 -08:00
jbd2	jbd2: fix incorrect unlock on j_list_lock	2016-10-12 23:19:18 -04:00
jffs2	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
jfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
kernfs	kernfs: Add noop_fsync to supported kernfs_file_fops	2016-10-27 17:47:11 +02:00
lockd	treewide: remove redundant #include <linux/kconfig.h>	2016-10-11 15:06:33 -07:00
logfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
minix	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
ncpfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
nfs	NFS client bugfixes for Linux 4.9 part 4	2016-11-23 14:43:40 -08:00
nfs_common
nfsd	nfsd: Fix general protection fault in release_lock_stateid()	2016-11-01 15:24:43 -04:00
nilfs2	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
nls
notify	fsnotify: clean up spinlock assertions	2016-10-07 18:46:26 -07:00
ntfs	fs: remove the never implemented aio_fsync file operation	2016-10-30 13:09:42 -04:00
ocfs2	ocfs2: fix not enough credit panic	2016-11-11 08:12:37 -08:00
omfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
openpromfs	fs: Replace CURRENT_TIME with current_time() for inode timestamps	2016-09-27 21:06:21 -04:00
orangefs	orangefs: add .owner to debugfs file_operations	2016-11-16 11:52:19 -05:00
overlayfs	ovl: fsync after copy-up	2016-10-31 14:42:14 +01:00
proc	proc: fix NULL dereference when reading /proc/<pid>/auxv	2016-10-27 18:43:43 -07:00
pstore	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
qnx4
qnx6
quota
ramfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
reiserfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
romfs
squashfs	vfs: Remove {get,set,remove}xattr inode operations	2016-10-07 21:48:36 -04:00
sysfs	Merge branch 'for-4.9' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup	2016-10-14 12:18:50 -07:00
sysv	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
tracefs	fs: Replace CURRENT_TIME with current_time() for inode timestamps	2016-09-27 21:06:21 -04:00
ubifs	ubifs: Fix regression in ubifs_readdir()	2016-10-28 14:48:31 +02:00
udf	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
ufs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
xfs	xfs: defer should abort intent items if the trans roll fails	2016-10-24 14:21:18 +11:00
aio.c	aio: fix freeze protection of aio writes	2016-10-30 13:09:42 -04:00
anon_inodes.c
attr.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
bad_inode.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
binfmt_aout.c
binfmt_elf.c	x86/coredump: Use pr_reg size, rather that TIF_IA32 flag	2016-09-14 21:28:10 +02:00
binfmt_elf_fdpic.c
binfmt_em86.c
binfmt_flat.c
binfmt_misc.c	fs: Replace current_fs_time() with current_time()	2016-09-27 21:06:22 -04:00
binfmt_script.c
block_dev.c	block: implement (some of) fallocate for block devices	2016-10-11 15:06:30 -07:00
buffer.c	fs: use mapping_set_error instead of opencoded set_bit	2016-10-11 15:06:33 -07:00
char_dev.c
compat.c	compat: remove compat_printk()	2016-09-27 21:20:53 -04:00
compat_binfmt_elf.c
compat_ioctl.c	fs: compat_ioctl: add pretimeout functions for watchdogs	2016-09-24 09:27:18 +02:00
coredump.c	coredump: fix unfreezable coredumping task	2016-11-11 08:12:37 -08:00
dax.c	thp: reduce usage of huge zero page's atomic counter	2016-10-07 18:46:28 -07:00
dcache.c
dcookies.c
direct-io.c	consistent treatment of EFAULT on O_DIRECT read/write	2016-10-03 20:38:55 -04:00
drop_caches.c
eventfd.c
eventpoll.c
exec.c	mm: replace get_user_pages_remote() write/force parameters with gup_flags	2016-10-19 08:12:02 -07:00
fcntl.c
fhandle.c
file.c	fs/file: more unsigned file descriptors	2016-09-27 18:47:38 -04:00
file_table.c
filesystems.c
fs-writeback.c
fs_pin.c
fs_struct.c
inode.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
internal.h	Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 13:04:49 -07:00
ioctl.c	vfs: cap dedupe request structure size at PAGE_SIZE	2016-09-15 13:29:52 -07:00
iomap.c	fs: Do to trim high file position bits in iomap_page_mkwrite_actor	2016-10-24 14:20:25 +11:00
Kconfig	mm/hugetlb: introduce ARCH_HAS_GIGANTIC_PAGE	2016-10-07 18:46:29 -07:00
Kconfig.binfmt
libfs.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
locks.c	locking, fs/locks: Add missing file_sem locks	2016-10-18 12:21:28 +02:00
Makefile
mbcache.c
mount.h	mnt: Add a per mount namespace limit on the number of mounts	2016-09-30 12:46:48 -05:00
mpage.c
namei.c	Merge branch 'overlayfs-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs	2016-10-14 17:23:33 -07:00
namespace.c	This adds a new gcc plugin named "latent_entropy". It is designed to	2016-10-15 10:03:15 -07:00
no-block.c
nsfs.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
open.c	xfs: reflink update for 4.9-rc1	2016-10-13 20:28:22 -07:00
pipe.c	pipe: cap initial pipe capacity according to pipe-max-size limit	2016-10-11 15:06:32 -07:00
pnode.c	mnt: Add a per mount namespace limit on the number of mounts	2016-09-30 12:46:48 -05:00
pnode.h	mnt: Add a per mount namespace limit on the number of mounts	2016-09-30 12:46:48 -05:00
posix_acl.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
proc_namespace.c
read_write.c	iov_iter: kernel-doc import_iovec() and rw_copy_check_uvector()	2016-10-14 20:00:34 -04:00
readdir.c
select.c	fs/select: add vmalloc fallback for select(2)	2016-10-11 15:06:30 -07:00
seq_file.c	seq/proc: modify seq_put_decimal_[u]ll to take a const char *, not char	2016-10-07 18:46:30 -07:00
signalfd.c
splice.c	fix default_file_splice_read()	2016-11-26 20:05:42 -05:00
stack.c
stat.c
statfs.c
super.c	fs/super.c: don't fool lockdep in freeze_super() and thaw_super() paths	2016-10-14 20:41:59 -04:00
sync.c
timerfd.c
userfaultfd.c
utimes.c	Merge remote-tracking branch 'jk/vfs' into work.misc	2016-10-08 11:06:08 -04:00
xattr.c	xattr: Fix setting security xattrs on sockfs	2016-11-17 00:00:23 -05:00