linux-stable/drivers/gpu/drm/tidss
Tomi Valkeinen c079e2e113 drm/tidss: Fix sync-lost issue with two displays
A sync lost issue can be observed with two displays, when moving a plane
from one disabled display to an another disabled display, and then
enabling the display to which the plane was moved to. The exact
requirements for this to trigger are not clear.

It looks like the issue is that the layers are left enabled in the first
display's OVR registers. Even if the corresponding VP is disabled, it
still causes an issue, as if the disabled VP and its OVR would still be
in use, leading to the same VID being used by two OVRs. However, this is
just speculation based on testing the DSS behavior.

Experimentation shows that as a workaround, we can disable all the
layers in the OVR when disabling a VP. There should be no downside to
this, as the OVR is anyway effectively disabled if its VP is disabled,
and it seems to solve the sync lost issue.

However, there may be a bigger issue in play here, related to J721e
erratum i2097 ("DSS: Disabling a Layer Connected to Overlay May Result
in Synclost During the Next Frame"). Experimentation also shows that the
OVR's CHANNELIN field has similar issue. So we may need to revisit this
when we find out more about the core issue.

Fixes: 32a1795f57 ("drm/tidss: New driver for TI Keystone platform Display SubSystem")
Reviewed-by: Aradhya Bhatia <a-bhatia1@ti.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240213-tidss-fixes-v1-2-d709e8dfa505@ideasonboard.com
2024-02-26 10:09:43 +02:00
..
Kconfig drm/gem: rename GEM CMA helpers to GEM DMA helpers 2022-08-03 18:31:49 +02:00
Makefile
tidss_crtc.c drm/tidss: Fix sync-lost issue with two displays 2024-02-26 10:09:43 +02:00
tidss_crtc.h
tidss_dispc.c drm/tidss: Fix dss reset 2023-12-01 12:04:42 +02:00
tidss_dispc.h drm/tidss: Add support for AM62A7 DSS 2023-12-01 12:04:37 +02:00
tidss_dispc_regs.h
tidss_drv.c drm/tidss: IRQ code cleanup 2023-12-01 12:04:42 +02:00
tidss_drv.h
tidss_encoder.c drm/tidss: Update encoder/bridge chain connect model 2023-07-10 14:21:29 +02:00
tidss_encoder.h drm/tidss: Update encoder/bridge chain connect model 2023-07-10 14:21:29 +02:00
tidss_irq.c drm/tidss: IRQ code cleanup 2023-12-01 12:04:42 +02:00
tidss_irq.h
tidss_kms.c drm/tidss: Use DRM_PLANE_COMMIT_ACTIVE_ONLY 2023-12-01 12:04:43 +02:00
tidss_kms.h
tidss_plane.c drm/tidss: Fix initial plane zpos values 2024-02-26 10:09:23 +02:00
tidss_plane.h
tidss_scale_coefs.c
tidss_scale_coefs.h