mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 19:00:25 +00:00
![Tejun Heo](/assets/img/avatar_default.png)
percpu.h is included by sched.h and module.h and thus ends up being included when building most .c files. percpu.h includes slab.h which in turn includes gfp.h making everything defined by the two files universally available and complicating inclusion dependencies. percpu.h -> slab.h dependency is about to be removed. Prepare for this change by updating users of gfp and slab facilities include those headers directly instead of assuming availability. As this conversion needs to touch large number of source files, the following script is used as the basis of conversion. http://userweb.kernel.org/~tj/misc/slabh-sweep.py The script does the followings. * Scan files for gfp and slab usages and update includes such that only the necessary includes are there. ie. if only gfp is used, gfp.h, if slab is used, slab.h. * When the script inserts a new include, it looks at the include blocks and try to put the new include such that its order conforms to its surrounding. It's put in the include block which contains core kernel includes, in the same order that the rest are ordered - alphabetical, Christmas tree, rev-Xmas-tree or at the end if there doesn't seem to be any matching order. * If the script can't find a place to put a new include (mostly because the file doesn't have fitting include block), it prints out an error message indicating which .h file needs to be added to the file. The conversion was done in the following steps. 1. The initial automatic conversion of all .c files updated slightly over 4000 files, deleting around 700 includes and adding ~480 gfp.h and ~3000 slab.h inclusions. The script emitted errors for ~400 files. 2. Each error was manually checked. Some didn't need the inclusion, some needed manual addition while adding it to implementation .h or embedding .c file was more appropriate for others. This step added inclusions to around 150 files. 3. The script was run again and the output was compared to the edits from #2 to make sure no file was left behind. 4. Several build tests were done and a couple of problems were fixed. e.g. lib/decompress_*.c used malloc/free() wrappers around slab APIs requiring slab.h to be added manually. 5. The script was run on all .h files but without automatically editing them as sprinkling gfp.h and slab.h inclusions around .h files could easily lead to inclusion dependency hell. Most gfp.h inclusion directives were ignored as stuff from gfp.h was usually wildly available and often used in preprocessor macros. Each slab.h inclusion directive was examined and added manually as necessary. 6. percpu.h was updated not to include slab.h. 7. Build test were done on the following configurations and failures were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my distributed build env didn't work with gcov compiles) and a few more options had to be turned off depending on archs to make things build (like ipr on powerpc/64 which failed due to missing writeq). * x86 and x86_64 UP and SMP allmodconfig and a custom test config. * powerpc and powerpc64 SMP allmodconfig * sparc and sparc64 SMP allmodconfig * ia64 SMP allmodconfig * s390 SMP allmodconfig * alpha SMP allmodconfig * um on x86_64 SMP allmodconfig 8. percpu.h modifications were reverted so that it could be applied as a separate patch and serve as bisection point. Given the fact that I had only a couple of failures from tests on step 6, I'm fairly confident about the coverage of this conversion patch. If there is a breakage, it's likely to be something in one of the arch headers which should be easily discoverable easily on most builds of the specific arch. Signed-off-by: Tejun Heo <tj@kernel.org> Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org> Cc: Ingo Molnar <mingo@redhat.com> Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
270 lines
6.5 KiB
C
270 lines
6.5 KiB
C
/*
|
|
* WHCI UWB Multi-interface Controller enumerator.
|
|
*
|
|
* Copyright (C) 2007 Cambridge Silicon Radio Ltd.
|
|
*
|
|
* This file is released under the GNU GPL v2.
|
|
*/
|
|
#include <linux/delay.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/pci.h>
|
|
#include <linux/dma-mapping.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/uwb/whci.h>
|
|
#include <linux/uwb/umc.h>
|
|
|
|
struct whci_card {
|
|
struct pci_dev *pci;
|
|
void __iomem *uwbbase;
|
|
u8 n_caps;
|
|
struct umc_dev *devs[0];
|
|
};
|
|
|
|
|
|
/* Fix faulty HW :( */
|
|
static
|
|
u64 whci_capdata_quirks(struct whci_card *card, u64 capdata)
|
|
{
|
|
u64 capdata_orig = capdata;
|
|
struct pci_dev *pci_dev = card->pci;
|
|
if (pci_dev->vendor == PCI_VENDOR_ID_INTEL
|
|
&& (pci_dev->device == 0x0c3b || pci_dev->device == 0004)
|
|
&& pci_dev->class == 0x0d1010) {
|
|
switch (UWBCAPDATA_TO_CAP_ID(capdata)) {
|
|
/* WLP capability has 0x100 bytes of aperture */
|
|
case 0x80:
|
|
capdata |= 0x40 << 8; break;
|
|
/* WUSB capability has 0x80 bytes of aperture
|
|
* and ID is 1 */
|
|
case 0x02:
|
|
capdata &= ~0xffff;
|
|
capdata |= 0x2001;
|
|
break;
|
|
}
|
|
}
|
|
if (capdata_orig != capdata)
|
|
dev_warn(&pci_dev->dev,
|
|
"PCI v%04x d%04x c%06x#%02x: "
|
|
"corrected capdata from %016Lx to %016Lx\n",
|
|
pci_dev->vendor, pci_dev->device, pci_dev->class,
|
|
(unsigned)UWBCAPDATA_TO_CAP_ID(capdata),
|
|
(unsigned long long)capdata_orig,
|
|
(unsigned long long)capdata);
|
|
return capdata;
|
|
}
|
|
|
|
|
|
/**
|
|
* whci_wait_for - wait for a WHCI register to be set
|
|
*
|
|
* Polls (for at most @max_ms ms) until '*@reg & @mask == @result'.
|
|
*/
|
|
int whci_wait_for(struct device *dev, u32 __iomem *reg, u32 mask, u32 result,
|
|
unsigned long max_ms, const char *tag)
|
|
{
|
|
unsigned t = 0;
|
|
u32 val;
|
|
for (;;) {
|
|
val = le_readl(reg);
|
|
if ((val & mask) == result)
|
|
break;
|
|
if (t >= max_ms) {
|
|
dev_err(dev, "%s timed out\n", tag);
|
|
return -ETIMEDOUT;
|
|
}
|
|
msleep(10);
|
|
t += 10;
|
|
}
|
|
return 0;
|
|
}
|
|
EXPORT_SYMBOL_GPL(whci_wait_for);
|
|
|
|
|
|
/*
|
|
* NOTE: the capinfo and capdata registers are slightly different
|
|
* (size and cap-id fields). So for cap #0, we need to fill
|
|
* in. Size comes from the size of the register block
|
|
* (statically calculated); cap_id comes from nowhere, we use
|
|
* zero, that is reserved, for the radio controller, because
|
|
* none was defined at the spec level.
|
|
*/
|
|
static int whci_add_cap(struct whci_card *card, int n)
|
|
{
|
|
struct umc_dev *umc;
|
|
u64 capdata;
|
|
int bar, err;
|
|
|
|
umc = umc_device_create(&card->pci->dev, n);
|
|
if (umc == NULL)
|
|
return -ENOMEM;
|
|
|
|
capdata = le_readq(card->uwbbase + UWBCAPDATA(n));
|
|
|
|
bar = UWBCAPDATA_TO_BAR(capdata) << 1;
|
|
|
|
capdata = whci_capdata_quirks(card, capdata);
|
|
/* Capability 0 is the radio controller. It's size is 32
|
|
* bytes (WHCI0.95[2.3, T2-9]). */
|
|
umc->version = UWBCAPDATA_TO_VERSION(capdata);
|
|
umc->cap_id = n == 0 ? 0 : UWBCAPDATA_TO_CAP_ID(capdata);
|
|
umc->bar = bar;
|
|
umc->resource.start = pci_resource_start(card->pci, bar)
|
|
+ UWBCAPDATA_TO_OFFSET(capdata);
|
|
umc->resource.end = umc->resource.start
|
|
+ (n == 0 ? 0x20 : UWBCAPDATA_TO_SIZE(capdata)) - 1;
|
|
umc->resource.name = dev_name(&umc->dev);
|
|
umc->resource.flags = card->pci->resource[bar].flags;
|
|
umc->resource.parent = &card->pci->resource[bar];
|
|
umc->irq = card->pci->irq;
|
|
|
|
err = umc_device_register(umc);
|
|
if (err < 0)
|
|
goto error;
|
|
card->devs[n] = umc;
|
|
return 0;
|
|
|
|
error:
|
|
kfree(umc);
|
|
return err;
|
|
}
|
|
|
|
static void whci_del_cap(struct whci_card *card, int n)
|
|
{
|
|
struct umc_dev *umc = card->devs[n];
|
|
|
|
if (umc != NULL)
|
|
umc_device_unregister(umc);
|
|
}
|
|
|
|
static int whci_n_caps(struct pci_dev *pci)
|
|
{
|
|
void __iomem *uwbbase;
|
|
u64 capinfo;
|
|
|
|
uwbbase = pci_iomap(pci, 0, 8);
|
|
if (!uwbbase)
|
|
return -ENOMEM;
|
|
capinfo = le_readq(uwbbase + UWBCAPINFO);
|
|
pci_iounmap(pci, uwbbase);
|
|
|
|
return UWBCAPINFO_TO_N_CAPS(capinfo);
|
|
}
|
|
|
|
static int whci_probe(struct pci_dev *pci, const struct pci_device_id *id)
|
|
{
|
|
struct whci_card *card;
|
|
int err, n_caps, n;
|
|
|
|
err = pci_enable_device(pci);
|
|
if (err < 0)
|
|
goto error;
|
|
pci_enable_msi(pci);
|
|
pci_set_master(pci);
|
|
err = -ENXIO;
|
|
if (!pci_set_dma_mask(pci, DMA_BIT_MASK(64)))
|
|
pci_set_consistent_dma_mask(pci, DMA_BIT_MASK(64));
|
|
else if (!pci_set_dma_mask(pci, DMA_BIT_MASK(32)))
|
|
pci_set_consistent_dma_mask(pci, DMA_BIT_MASK(32));
|
|
else
|
|
goto error_dma;
|
|
|
|
err = n_caps = whci_n_caps(pci);
|
|
if (n_caps < 0)
|
|
goto error_ncaps;
|
|
|
|
err = -ENOMEM;
|
|
card = kzalloc(sizeof(struct whci_card)
|
|
+ sizeof(struct whci_dev *) * (n_caps + 1),
|
|
GFP_KERNEL);
|
|
if (card == NULL)
|
|
goto error_kzalloc;
|
|
card->pci = pci;
|
|
card->n_caps = n_caps;
|
|
|
|
err = -EBUSY;
|
|
if (!request_mem_region(pci_resource_start(pci, 0),
|
|
UWBCAPDATA_SIZE(card->n_caps),
|
|
"whci (capability data)"))
|
|
goto error_request_memregion;
|
|
err = -ENOMEM;
|
|
card->uwbbase = pci_iomap(pci, 0, UWBCAPDATA_SIZE(card->n_caps));
|
|
if (!card->uwbbase)
|
|
goto error_iomap;
|
|
|
|
/* Add each capability. */
|
|
for (n = 0; n <= card->n_caps; n++) {
|
|
err = whci_add_cap(card, n);
|
|
if (err < 0 && n == 0) {
|
|
dev_err(&pci->dev, "cannot bind UWB radio controller:"
|
|
" %d\n", err);
|
|
goto error_bind;
|
|
}
|
|
if (err < 0)
|
|
dev_warn(&pci->dev, "warning: cannot bind capability "
|
|
"#%u: %d\n", n, err);
|
|
}
|
|
pci_set_drvdata(pci, card);
|
|
return 0;
|
|
|
|
error_bind:
|
|
pci_iounmap(pci, card->uwbbase);
|
|
error_iomap:
|
|
release_mem_region(pci_resource_start(pci, 0), UWBCAPDATA_SIZE(card->n_caps));
|
|
error_request_memregion:
|
|
kfree(card);
|
|
error_kzalloc:
|
|
error_ncaps:
|
|
error_dma:
|
|
pci_disable_msi(pci);
|
|
pci_disable_device(pci);
|
|
error:
|
|
return err;
|
|
}
|
|
|
|
static void whci_remove(struct pci_dev *pci)
|
|
{
|
|
struct whci_card *card = pci_get_drvdata(pci);
|
|
int n;
|
|
|
|
pci_set_drvdata(pci, NULL);
|
|
/* Unregister each capability in reverse (so the master device
|
|
* is unregistered last). */
|
|
for (n = card->n_caps; n >= 0 ; n--)
|
|
whci_del_cap(card, n);
|
|
pci_iounmap(pci, card->uwbbase);
|
|
release_mem_region(pci_resource_start(pci, 0), UWBCAPDATA_SIZE(card->n_caps));
|
|
kfree(card);
|
|
pci_disable_msi(pci);
|
|
pci_disable_device(pci);
|
|
}
|
|
|
|
static struct pci_device_id whci_id_table[] = {
|
|
{ PCI_DEVICE_CLASS(PCI_CLASS_WIRELESS_WHCI, ~0) },
|
|
{ 0 },
|
|
};
|
|
MODULE_DEVICE_TABLE(pci, whci_id_table);
|
|
|
|
|
|
static struct pci_driver whci_driver = {
|
|
.name = "whci",
|
|
.id_table = whci_id_table,
|
|
.probe = whci_probe,
|
|
.remove = whci_remove,
|
|
};
|
|
|
|
static int __init whci_init(void)
|
|
{
|
|
return pci_register_driver(&whci_driver);
|
|
}
|
|
|
|
static void __exit whci_exit(void)
|
|
{
|
|
pci_unregister_driver(&whci_driver);
|
|
}
|
|
|
|
module_init(whci_init);
|
|
module_exit(whci_exit);
|
|
|
|
MODULE_DESCRIPTION("WHCI UWB Multi-interface Controller enumerator");
|
|
MODULE_AUTHOR("Cambridge Silicon Radio Ltd.");
|
|
MODULE_LICENSE("GPL");
|