mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 01:10:04 +00:00
![Dmitry Safonov](/assets/img/avatar_default.png)
show_trace_log_lvl() provides x86 platform-specific way to unwind backtrace with a given log level. Unfortunately, registers dump(s) are not printed with the same log level - instead, KERN_DEFAULT is always used. Arista's switches uses quite common setup with rsyslog, where only urgent messages goes to console (console_log_level=KERN_ERR), everything else goes into /var/log/ as the console baud-rate often is indecently slow (9600 bps). Backtrace dumps without registers printed have proven to be as useful as morning standups. Furthermore, in order to introduce KERN_UNSUPPRESSED (which I believe is still the most elegant way to fix raciness of sysrq[1]) the log level should be passed down the stack to register dumping functions. Besides, there is a potential use-case for printing traces with KERN_DEBUG level [2] (where registers dump shouldn't appear with higher log level). Add log_lvl parameter to __show_regs(). Keep the used log level intact to separate visible change. [1]: https://lore.kernel.org/lkml/20190528002412.1625-1-dima@arista.com/ [2]: https://lore.kernel.org/linux-doc/20190724170249.9644-1-dima@arista.com/ Signed-off-by: Dmitry Safonov <dima@arista.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Acked-by: Petr Mladek <pmladek@suse.com> Link: https://lkml.kernel.org/r/20200629144847.492794-3-dima@arista.com
45 lines
1.1 KiB
C
45 lines
1.1 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef _ASM_X86_KDEBUG_H
|
|
#define _ASM_X86_KDEBUG_H
|
|
|
|
#include <linux/notifier.h>
|
|
|
|
struct pt_regs;
|
|
|
|
/* Grossly misnamed. */
|
|
enum die_val {
|
|
DIE_OOPS = 1,
|
|
DIE_INT3,
|
|
DIE_DEBUG,
|
|
DIE_PANIC,
|
|
DIE_NMI,
|
|
DIE_DIE,
|
|
DIE_KERNELDEBUG,
|
|
DIE_TRAP,
|
|
DIE_GPF,
|
|
DIE_CALL,
|
|
DIE_PAGE_FAULT,
|
|
DIE_NMIUNKNOWN,
|
|
};
|
|
|
|
enum show_regs_mode {
|
|
SHOW_REGS_SHORT,
|
|
/*
|
|
* For when userspace crashed, but we don't think it's our fault, and
|
|
* therefore don't print kernel registers.
|
|
*/
|
|
SHOW_REGS_USER,
|
|
SHOW_REGS_ALL
|
|
};
|
|
|
|
extern void die(const char *, struct pt_regs *,long);
|
|
void die_addr(const char *str, struct pt_regs *regs, long err, long gp_addr);
|
|
extern int __must_check __die(const char *, struct pt_regs *, long);
|
|
extern void show_stack_regs(struct pt_regs *regs);
|
|
extern void __show_regs(struct pt_regs *regs, enum show_regs_mode,
|
|
const char *log_lvl);
|
|
extern void show_iret_regs(struct pt_regs *regs, const char *log_lvl);
|
|
extern unsigned long oops_begin(void);
|
|
extern void oops_end(unsigned long, struct pt_regs *, int signr);
|
|
|
|
#endif /* _ASM_X86_KDEBUG_H */
|