Willem de Bruijn c3e974e9c4 selftests/net: mptcp: fix uninitialized variable warnings ... [ Upstream commit 00a4f8fd9c ] Same init_rng() in both tests. The function reads /dev/urandom to initialize srand(). In case of failure, it falls back onto the entropy in the uninitialized variable. Not sure if this is on purpose. But failure reading urandom should be rare, so just fail hard. While at it, convert to getrandom(). Which man 4 random suggests is simpler and more robust. mptcp_inq.c:525:6: mptcp_connect.c:1131:6: error: variable 'foo' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] Fixes: 048d19d444 ("mptcp: add basic kselftest for mptcp") Fixes: b51880568f ("selftests: mptcp: add inq test case") Cc: Florian Westphal <fw@strlen.de> Signed-off-by: Willem de Bruijn <willemb@google.com> ---- When input is randomized because this is expected to meaningfully explore edge cases, should we also add 1. logging the random seed to stdout and 2. adding a command line argument to replay from a specific seed I can do this in net-next, if authors find it useful in this case. Reviewed-by: Matthieu Baerts <matttbe@kernel.org> Link: https://lore.kernel.org/r/20231124171645.1011043-5-willemdebruijn.kernel@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-12-08 08:51:17 +01:00
..
crypto/chacha20-s390
cxl	cxl/region: Fix x1 root-decoder granularity calculations	2023-11-28 17:07:18 +00:00
fault-injection
ktest	ktest.pl: Add RUN_TIMEOUT option with default unlimited	2023-03-10 09:34:27 +01:00
kunit	kunit: tool: Don't download risc-v opensbi firmware with wget	2022-10-07 10:16:28 -06:00
memblock	memblock tests: fix warning ‘struct seq_file’ declared inside parameter list	2023-10-06 14:56:56 +02:00
nvdimm	ndtest: Cleanup all of blk namespace specific code	2022-07-12 17:57:55 -07:00
radix-tree	XArray: Do not return sibling entries from xa_load()	2023-09-13 09:43:00 +02:00
scatterlist
selftests	selftests/net: mptcp: fix uninitialized variable warnings	2023-12-08 08:51:17 +01:00
vsock	vsock_test: POLLIN + SO_RCVLOWAT test	2022-08-23 10:43:12 +02:00