Jakub Sitnicki 3c69611b89 selftests/bpf: Fix u8 narrow load checks for bpf_sk_lookup remote_port ... In commit 9a69e2b385 ("bpf: Make remote_port field in struct bpf_sk_lookup 16-bit wide") ->remote_port field changed from __u32 to __be16. However, narrow load tests which exercise 1-byte sized loads from offsetof(struct bpf_sk_lookup, remote_port) were not adopted to reflect the change. As a result, on little-endian we continue testing loads from addresses: - (__u8 *)&ctx->remote_port + 3 - (__u8 *)&ctx->remote_port + 4 which map to the zero padding following the remote_port field, and don't break the tests because there is no observable change. While on big-endian, we observe breakage because tests expect to see zeros for values loaded from: - (__u8 *)&ctx->remote_port - 1 - (__u8 *)&ctx->remote_port - 2 Above addresses map to ->remote_ip6 field, which precedes ->remote_port, and are populated during the bpf_sk_lookup IPv6 tests. Unsurprisingly, on s390x we observe: #136/38 sk_lookup/narrow access to ctx v4:OK #136/39 sk_lookup/narrow access to ctx v6:FAIL Fix it by removing the checks for 1-byte loads from offsets outside of the ->remote_port field. Fixes: 9a69e2b385 ("bpf: Make remote_port field in struct bpf_sk_lookup 16-bit wide") Suggested-by: Ilya Leoshkevich <iii@linux.ibm.com> Signed-off-by: Jakub Sitnicki <jakub@cloudflare.com> Signed-off-by: Alexei Starovoitov <ast@kernel.org> Acked-by: Martin KaFai Lau <kafai@fb.com> Link: https://lore.kernel.org/bpf/20220319183356.233666-3-jakub@cloudflare.com		2022-03-20 18:58:59 -07:00
..
accounting	delayacct: track delays from memory compact	2022-01-20 08:52:55 +02:00
arch	tools arch x86: Sync the msr-index.h copy with the kernel sources	2022-02-22 17:43:05 -03:00
bootconfig
bpf	bpftool: Add BPF_TRACE_KPROBE_MULTI to attach type names table	2022-03-18 17:56:00 +01:00
build	Merge remote-tracking branch 'torvalds/master' into perf/core	2022-01-13 10:20:59 -03:00
cgroup	tools/cgroup/slabinfo: update to work with struct slab	2022-02-21 11:34:49 +01:00
counter
debugging
edid
firewire
firmware
gpio
hv
iio	iio: event_monitor: Flush output on event	2021-12-16 12:20:35 +00:00
include	bpf: Add cookie support to programs attached with kprobe multi link	2022-03-17 20:17:19 -07:00
io_uring
kvm/kvm_stat
laptop
leds
lib	libbpf: Avoid NULL deref when initializing map BTF info	2022-03-20 18:53:04 -07:00
memory-model	tools/memory-model: litmus: Add two tests for unlock(A)+lock(B) ordering	2021-11-30 17:47:08 -08:00
objtool	objtool: Fix truncated string warning	2022-01-24 10:09:06 -08:00
pci
pcmcia
perf	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-03-03 11:55:12 -08:00
power	More ACPI updates for 5.17-rc1	2022-01-18 08:51:51 +02:00
rcu
scripts	tools: Fix unavoidable GCC call in Clang builds	2022-03-08 23:36:37 +01:00
spi
testing	selftests/bpf: Fix u8 narrow load checks for bpf_sk_lookup remote_port	2022-03-20 18:58:59 -07:00
thermal/tmon	thermal: tools: tmon: remove unneeded local variable	2021-11-24 17:26:13 +01:00
time
tracing	rtla/osnoise: Fix error message when failing to enable trace instance	2022-02-25 21:05:30 -05:00
usb
virtio
vm
wmi
Makefile	tools/lib/lockdep: drop liblockdep	2021-11-12 11:07:17 -08:00