Ignat Korchagin 3e11ef1903 ipv6: mcast: use rcu-safe version of ipv6_get_lladdr() ... commit 26394fc118 upstream. Some time ago 8965779d2c ("ipv6,mcast: always hold idev->lock before mca_lock") switched ipv6_get_lladdr() to __ipv6_get_lladdr(), which is rcu-unsafe version. That was OK, because idev->lock was held for these codepaths. In 88e2ca3080 ("mld: convert ifmcaddr6 to RCU") these external locks were removed, so we probably need to restore the original rcu-safe call. Otherwise, we occasionally get a machine crashed/stalled with the following in dmesg: [ 3405.966610][T230589] general protection fault, probably for non-canonical address 0xdead00000000008c: 0000 [#1] SMP NOPTI [ 3405.982083][T230589] CPU: 44 PID: 230589 Comm: kworker/44:3 Tainted: G O 5.15.19-cloudflare-2022.2.1 #1 [ 3405.998061][T230589] Hardware name: SUPA-COOL-SERV [ 3406.009552][T230589] Workqueue: mld mld_ifc_work [ 3406.017224][T230589] RIP: 0010:__ipv6_get_lladdr+0x34/0x60 [ 3406.025780][T230589] Code: 57 10 48 83 c7 08 48 89 e5 48 39 d7 74 3e 48 8d 82 38 ff ff ff eb 13 48 8b 90 d0 00 00 00 48 8d 82 38 ff ff ff 48 39 d7 74 22 <66> 83 78 32 20 77 1b 75 e4 89 ca 23 50 2c 75 dd 48 8b 50 08 48 8b [ 3406.055748][T230589] RSP: 0018:ffff94e4b3fc3d10 EFLAGS: 00010202 [ 3406.065617][T230589] RAX: dead00000000005a RBX: ffff94e4b3fc3d30 RCX: 0000000000000040 [ 3406.077477][T230589] RDX: dead000000000122 RSI: ffff94e4b3fc3d30 RDI: ffff8c3a31431008 [ 3406.089389][T230589] RBP: ffff94e4b3fc3d10 R08: 0000000000000000 R09: 0000000000000000 [ 3406.101445][T230589] R10: ffff8c3a31430000 R11: 000000000000000b R12: ffff8c2c37887100 [ 3406.113553][T230589] R13: ffff8c3a39537000 R14: 00000000000005dc R15: ffff8c3a31431000 [ 3406.125730][T230589] FS: 0000000000000000(0000) GS:ffff8c3b9fc80000(0000) knlGS:0000000000000000 [ 3406.138992][T230589] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 3406.149895][T230589] CR2: 00007f0dfea1db60 CR3: 000000387b5f2000 CR4: 0000000000350ee0 [ 3406.162421][T230589] Call Trace: [ 3406.170235][T230589] <TASK> [ 3406.177736][T230589] mld_newpack+0xfe/0x1a0 [ 3406.186686][T230589] add_grhead+0x87/0xa0 [ 3406.195498][T230589] add_grec+0x485/0x4e0 [ 3406.204310][T230589] ? newidle_balance+0x126/0x3f0 [ 3406.214024][T230589] mld_ifc_work+0x15d/0x450 [ 3406.223279][T230589] process_one_work+0x1e6/0x380 [ 3406.232982][T230589] worker_thread+0x50/0x3a0 [ 3406.242371][T230589] ? rescuer_thread+0x360/0x360 [ 3406.252175][T230589] kthread+0x127/0x150 [ 3406.261197][T230589] ? set_kthread_struct+0x40/0x40 [ 3406.271287][T230589] ret_from_fork+0x22/0x30 [ 3406.280812][T230589] </TASK> [ 3406.288937][T230589] Modules linked in: ... [last unloaded: kheaders] [ 3406.476714][T230589] ---[ end trace 3525a7655f2f3b9e ]--- Fixes: 88e2ca3080 ("mld: convert ifmcaddr6 to RCU") Reported-by: David Pinilla Caparros <dpini@cloudflare.com> Signed-off-by: Ignat Korchagin <ignat@cloudflare.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2022-02-23 12:03:10 +01:00
..
9p	9p: apply review requests for fid refcounting	2020-11-19 17:21:34 +01:00
bluetooth	Bluetooth: add quirk disabling LE Read Transmit Power	2022-01-16 09:12:44 +01:00
caif	net: remove the caif_hsi driver	2021-07-01 13:19:48 -07:00
iucv	net/af_iucv: don't track individual TX skbs for TRANS_HIPER sockets	2021-01-28 20:36:21 -08:00
netfilter	netfilter: conntrack: annotate data-races around ct->timeout	2021-12-14 10:57:10 +01:00
netns	ipv4: convert fib_num_tclassid_users to atomic_t	2021-12-08 09:04:49 +01:00
nfc	NFC: add NCI_UNREG flag to eliminate the race	2021-11-25 09:48:40 +01:00
phonet	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 336	2019-06-05 17:37:07 +02:00
sctp	sctp: hold endpoint before calling cb in sctp_transport_lookup_process	2022-01-11 15:35:14 +01:00
tc_act	net/sched: act_vlan: Fix modify to allow 0	2021-06-01 16:54:42 -07:00
6lowpan.h	6lowpan: Replace zero-length array with flexible-array member	2020-02-28 14:51:30 +01:00
act_api.h	net_sched: refactor TC action init API	2021-08-02 10:24:38 +01:00
addrconf.h	ipv6: mcast: use rcu-safe version of ipv6_get_lladdr()	2022-02-23 12:03:10 +01:00
af_ieee802154.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174	2019-05-30 11:26:41 -07:00
af_rxrpc.h	afs: Don't truncate iter during data fetch	2021-04-23 10:17:26 +01:00
af_unix.h	af_unix: Add unix_stream_proto for sockmap	2021-08-16 18:43:39 -07:00
af_vsock.h	af_vsock: rest of SEQPACKET support	2021-06-11 13:32:46 -07:00
ah.h
arp.h	net: avoid potential false sharing in neighbor related code	2019-11-06 16:14:48 -08:00
atmclip.h
ax25.h
ax88796.h	ax88796: export ax_NS8390_init() hook	2021-08-03 13:05:25 +01:00
bareudp.h	bareudp: Reverted support to enable & disable rx metadata collection	2020-07-21 18:30:47 -07:00
bond_3ad.h	bonding: add new option lacp_active	2021-08-03 11:50:22 +01:00
bond_alb.h	bonding: make tx_rebalance_counter an atomic	2021-12-14 10:57:09 +01:00
bond_options.h	bonding: add new option lacp_active	2021-08-03 11:50:22 +01:00
bonding.h	bonding: remove extraneous definitions from bonding.h	2021-08-11 14:57:31 -07:00
bpf_sk_storage.h	bpf: struct sock is declared twice in bpf_sk_storage header	2021-03-26 17:43:55 +01:00
busy_poll.h	net: annotate data race around sk_ll_usec	2021-07-01 11:23:50 -07:00
calipso.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 13	2019-05-21 11:28:45 +02:00
cfg80211-wext.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
cfg80211.h	cfg80211: fix management registrations locking	2021-10-25 15:20:22 +02:00
cfg802154.h	cfg802154: Replace zero-length array with flexible-array member	2020-02-29 14:39:08 +01:00
checksum.h	csum_and_copy_to_iter(): massage into form closer to csum_and_copy_from_iter()	2021-06-10 11:45:14 -04:00
cipso_ipv4.h	cipso: Remove unused inline functions	2020-07-15 07:45:24 -07:00
cls_cgroup.h	bpf: Allow to retrieve cgroup v1 classid from v2 hooks	2020-03-27 19:40:38 -07:00
codel.h
codel_impl.h
codel_qdisc.h
compat.h	net/ipv4/ipv6: Replace one-element arraya with flexible-array members	2021-08-05 11:46:42 +01:00
datalink.h
dcbevent.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 201	2019-05-30 11:29:52 -07:00
dcbnl.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 201	2019-05-30 11:29:52 -07:00
devlink.h	devlink: Use xarray to store devlink instances	2021-08-14 13:59:10 +01:00
dn.h
dn_dev.h
dn_fib.h	net: convert fib_treeref from int to refcount_t	2021-07-30 15:33:24 +02:00
dn_neigh.h
dn_nsp.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 24	2019-05-21 11:52:39 +02:00
dn_route.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 24	2019-05-21 11:52:39 +02:00
dsa.h	net: dsa: tear down devlink port regions when tearing down the devlink port on error	2021-09-19 13:05:44 +01:00
dsfield.h	ipv6: Annotate bitwise IPv6 dsfield pointer cast	2019-12-16 16:09:44 -08:00
dst.h	sk_buff: track dst status in slow_gro	2021-07-29 12:18:11 +01:00
dst_cache.h	wireguard: device: reset peer src endpoint when netns exits	2021-12-08 09:04:46 +01:00
dst_metadata.h	net: fix a memleak when uncloning an skb dst and its metadata	2022-02-16 12:56:30 +01:00
dst_ops.h	net/dst: use a smaller percpu_counter batch for dst entries accounting	2020-05-08 21:33:33 -07:00
erspan.h	erspan: Add type I version 0 support.	2020-05-05 13:23:29 -07:00
esp.h	ESP: Export esp_output_fill_trailer function	2020-02-19 13:52:32 +01:00
espintcp.h	xfrm: espintcp: save and call old ->sk_destruct	2020-04-20 07:34:16 +02:00
ethoc.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
failover.h
fib_notifier.h	ipv6: Remove old route notifications and convert listeners	2019-12-24 22:37:30 -08:00
fib_rules.h	ipv6: fix memory leak in fib6_rule_suppress	2021-12-08 09:04:43 +01:00
firewire.h
flow.h	flow: fix object-size-mismatch warning in flowi{4,6}_to_flowi_common()	2021-09-02 11:44:19 +01:00
flow_dissector.h	flow_dissector: constify raw input data argument	2021-03-14 14:46:32 -07:00
flow_offload.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2021-08-19 18:09:18 -07:00
fou.h
fq.h	net/fq_impl: do not maintain a backlog-sorted list of flows	2021-01-21 13:33:45 +01:00
fq_impl.h	net/fq_impl: do not maintain a backlog-sorted list of flows	2021-01-21 13:33:45 +01:00
garp.h	treewide: Use sizeof_field() macro	2019-12-09 10:36:44 -08:00
gen_stats.h	net_sched: extend packet counter to 64bit	2019-11-05 18:20:55 -08:00
genetlink.h	mptcp: avoid lock_fast usage in accept path	2021-02-12 16:31:46 -08:00
geneve.h
gre.h	ip_gre: add csum offload support for gre header	2021-01-29 20:39:14 -08:00
gro.h	gro: add combined call_gro_receive() + INDIRECT_CALL_INET() helper	2021-03-18 19:51:12 -07:00
gro_cells.h
gtp.h
gue.h	GUE: Fix a typo	2020-06-22 21:12:44 -07:00
hwbm.h	net: hwbm: if CONFIG_NET_HWBM unset, make stub functions static	2019-10-25 16:24:32 -07:00
icmp.h	ipv6: ICMPV6: add response to ICMPV6 RFC 8335 PROBE messages	2021-06-28 14:29:45 -07:00
ieee80211_radiotap.h	mac80211: Use flex-array for radiotap header bitmap	2021-08-13 09:58:25 +02:00
ieee802154_netdev.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174	2019-05-30 11:26:41 -07:00
if_inet6.h	ipv6: add IFLA_INET6_RA_MTU to expose mtu value	2021-08-27 17:29:18 -07:00
ife.h
ila.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
inet6_connection_sock.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
inet6_hashtables.h	net: Track socket refcounts in skb_steal_sock()	2020-03-30 13:45:04 -07:00
inet_common.h	bpf: Allow rewriting to ports under ip_unprivileged_port_start	2021-01-27 18:18:15 -08:00
inet_connection_sock.h	tcp: switch orphan_count to bare per-cpu counters	2021-11-18 19:16:33 +01:00
inet_ecn.h	inet_ecn: Use csum16_add() helper for IP_ECN_set_* helpers	2020-12-14 18:38:58 -08:00
inet_frag.h	inet: frags: annotate races around fqdir->dead and fqdir->high_thresh	2022-01-27 11:05:35 +01:00
inet_hashtables.h	tcp: seq_file: Replace listening_hash with lhash2	2021-07-23 16:44:57 -07:00
inet_sock.h	tcp: move inet->rx_dst_ifindex to sk->sk_rx_dst_ifindex	2021-12-29 12:28:42 +01:00
inet_timewait_sock.h	tcp: honor SO_PRIORITY in TIME_WAIT state	2019-09-27 12:05:02 +02:00
inetpeer.h
ioam6.h	ipv6: ioam: Support for IOAM injection with lwtunnels	2021-07-21 08:14:33 -07:00
ip.h	ipv4: avoid using shared IP generator for connected sockets	2022-02-01 17:27:08 +01:00
ip6_checksum.h	tcp: remove indirect calls for icsk->icsk_af_ops->send_check	2020-06-20 17:47:53 -07:00
ip6_fib.h	ipv6: fix data-race in fib6_info_hw_flags_set / fib6_purge_rt	2022-02-23 12:03:10 +01:00
ip6_route.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2021-08-05 15:08:47 -07:00
ip6_tunnel.h	ip6_tunnel: allow not to count pkts on tstats by passing dev as NULL	2019-06-18 20:48:45 -04:00
ip_fib.h	ipv4: convert fib_num_tclassid_users to atomic_t	2021-12-08 09:04:49 +01:00
ip_tunnels.h	ip_tunnel: use ndo_siocdevprivate	2021-07-27 20:11:44 +01:00
ip_vs.h	netfilter: move handlers to net/ip_vs.h	2021-02-04 18:37:57 -08:00
ipcomp.h
ipconfig.h
ipv6.h	ipv6: Add a sysctl to control multipath hash fields	2021-05-18 13:27:32 -07:00
ipv6_frag.h	inet: frags: annotate races around fqdir->dead and fqdir->high_thresh	2022-01-27 11:05:35 +01:00
ipv6_stubs.h	net: ipv6: add fib6_nh_release_dsts stub	2021-12-01 09:04:49 +01:00
iw_handler.h
kcm.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
l3mdev.h	l3mdev: add infrastructure for table to VRF mapping	2020-06-20 17:22:22 -07:00
lag.h
lapb.h	net: lapb: Make "lapb_t1timer_running" able to detect an already running timer	2021-03-23 14:14:50 -07:00
lib80211.h
llc.h	llc: fix out-of-bound array index in llc_sk_dev_hash()	2021-11-18 19:17:10 +01:00
llc_c_ac.h
llc_c_ev.h
llc_c_st.h
llc_conn.h	llc: fix sk_buff leak in llc_conn_service()	2019-10-08 13:23:05 -07:00
llc_if.h
llc_pdu.h	net: llc: fix skb_over_panic	2021-07-27 13:05:56 +01:00
llc_s_ac.h
llc_s_ev.h
llc_s_st.h
llc_sap.h
lwtunnel.h	netfilter: add netfilter hooks to SRv6 data plane	2021-08-30 01:51:36 +02:00
mac80211.h	mac80211: Fix Ptk0 rekey documentation	2021-09-27 12:02:54 +02:00
mac802154.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174	2019-05-30 11:26:41 -07:00
macsec.h	net: macsec: fix the length used to copy the key for offloading	2021-06-24 12:41:12 -07:00
mctp.h	mctp: unify sockaddr_mctp types	2021-10-18 13:47:09 +01:00
mctpdevice.h	mctp: Remove the repeated declaration	2021-08-25 11:23:14 +01:00
mip6.h	net: mip6: Replace zero-length array with flexible-array member	2020-03-02 11:16:27 -08:00
mld.h	mld: add new workqueues for process mld events	2021-03-26 15:14:56 -07:00
mpls.h	net: Make mpls_entry_encode() available for generic users	2020-05-29 21:20:20 -07:00
mpls_iptunnel.h	net: mpls: Replace zero-length array with flexible-array member	2020-02-28 12:08:37 -08:00
mptcp.h	mptcp: fix corrupt receiver key in MPC + data + checksum	2021-10-28 08:19:06 -07:00
mrp.h	treewide: Use sizeof_field() macro	2019-12-09 10:36:44 -08:00
ncsi.h
ndisc.h	ipv6: ndisc: adjust ndisc_ifinfo_sysctl_change prototype	2020-08-24 06:40:07 -07:00
neighbour.h	net, neigh: Enable state migration between NUD_PERMANENT and NTF_USE	2021-11-18 19:17:16 +01:00
net_failover.h
net_namespace.h	netfilter: remove xt pernet data	2021-08-01 12:00:51 +02:00
net_ratelimit.h
netevent.h
netlabel.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 13	2019-05-21 11:28:45 +02:00
netlink.h	net: netlink: add the case when nlh is NULL	2021-07-27 11:43:50 +01:00
netprio_cgroup.h	netprio: use css ID instead of cgroup ID	2019-11-12 08:18:03 -08:00
netrom.h
nexthop.h	net: ipv4: Fix rtnexthop len when RTA_FLOW is present	2021-09-24 14:07:10 +01:00
nl802154.h	net: ieee802154: handle iftypes as u32	2021-12-01 09:04:46 +01:00
nsh.h
p8022.h
page_pool.h	page_pool: add frag page recycling support in page pool	2021-08-09 15:49:00 -07:00
pie.h	pie: realign comment	2020-03-04 13:25:55 -08:00
ping.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
pkt_cls.h	sch_htb: Fix inconsistency when leaf qdisc creation fails	2021-08-30 16:33:59 -07:00
pkt_sched.h	net: openvswitch: Fix ct_state nat flags for conns arriving from tc	2022-01-27 11:04:02 +01:00
pptp.h
protocol.h	net: Remove the member netns_ok	2021-05-17 15:29:35 -07:00
psample.h	psample: Add a fwd declaration for skbuff	2021-08-09 15:34:21 -07:00
psnap.h
raw.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
rawv6.h
red.h	sch_red: fix off-by-one checks in red_check_params()	2021-03-25 17:40:43 -07:00
regulatory.h	net/wireless: regulatory.h: drop duplicate word in comment	2020-07-31 09:24:23 +02:00
request_sock.h	tcp: bpf: Optionally store mac header in TCP_SAVE_SYN	2020-08-24 14:35:00 -07:00
rose.h
route.h	ipv4: remove sparse error in ip_neigh_gw4()	2022-02-01 17:27:14 +01:00
rpl.h	net: ipv6: Use struct_size() helper and kcalloc()	2020-06-23 20:27:09 -07:00
rsi_91x.h
rtnetlink.h	net: add extack arg for link ops	2021-08-04 10:01:26 +01:00
rtnh.h
sch_generic.h	net_sched: restore "mpu xxx" handling	2022-01-27 11:05:40 +01:00
scm.h	fs: Move __scm_install_fd() to __receive_fd()	2020-07-13 11:03:44 -07:00
secure_seq.h
seg6.h	udp6: Use Segment Routing Header for dest address if present	2022-01-27 11:05:05 +01:00
seg6_hmac.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
seg6_local.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
selftests.h	net: selftest: fix build issue if INET is disabled	2021-04-28 14:06:45 -07:00
slhc_vj.h
smc.h	net/smc: introduce CHID callback for ISM devices	2020-09-28 15:19:03 -07:00
snmp.h	net/tls: add skeleton of MIB statistics	2019-10-05 16:29:00 -07:00
sock.h	inet: fully convert sk->sk_rx_dst to RCU rules	2021-12-29 12:28:42 +01:00
sock_reuseport.h	tcp: Add reuseport_migrate_sock() to select a new listener.	2021-06-15 18:01:05 +02:00
Space.h	wan: remove sbni/granch driver	2021-08-03 13:05:26 +01:00
stp.h
strparser.h	bpf, sockmap: sk_skb data_end access incorrect when src_reg = dst_reg	2021-11-18 19:17:11 +01:00
switchdev.h	net: make switchdev_bridge_port_{,unoffload} loosely coupled with the bridge	2021-08-04 12:35:07 +01:00
tcp.h	tcp: switch orphan_count to bare per-cpu counters	2021-11-18 19:16:33 +01:00
tcp_states.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
timewait_sock.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
tipc.h
tls.h	net/tls: Fix flipped sign in tls_err_abort() calls	2021-10-28 14:41:20 +01:00
tls_toe.h	net/tls: rename tls_hw_* functions tls_toe_*	2019-10-04 14:07:07 -07:00
transp_v6.h	tcp: move ipv4_specific to tcp include file	2020-06-23 20:10:15 -07:00
tso.h	net: tso: cache transport header length	2020-06-18 20:46:23 -07:00
tun_proto.h
udp.h	net: multicast: calculate csum of looped-back and forwarded packets	2021-10-26 13:09:22 +01:00
udp_tunnel.h	udp: call udp_encap_enable for v6 sockets when enabling encap	2021-02-04 18:37:14 -08:00
udplite.h
vsock_addr.h	vsock: remove include/linux/vm_sockets.h file	2019-11-14 18:12:17 -08:00
vxlan.h	net: sched: only keep the available bits when setting vxlan md->gbp	2020-09-14 16:49:39 -07:00
wext.h
x25.h	net/x25: add new state X25_STATE_5	2019-12-09 10:28:43 -08:00
x25device.h
xdp.h	bpf: Add function for XDP meta data length check	2021-07-07 19:51:12 -07:00
xdp_priv.h	page_pool: do not release pool until inflight == 0.	2019-11-16 12:39:10 -08:00
xdp_sock.h	xdp: Add proper __rcu annotations to redirect map entries	2021-06-24 19:41:15 +02:00
xdp_sock_drv.h	xsk: Introduce batched Tx descriptor interfaces	2020-11-17 22:07:40 +01:00
xfrm.h	xfrm: fix dflt policy check when there is no policy configured	2022-01-27 11:05:14 +01:00
xsk_buff_pool.h	xsk: Fix missing validation for skb and unaligned mode	2021-06-18 16:57:19 +02:00