linux-stable/drivers/s390
Stefan Haberland 6deb8727f2 s390/dasd: print copy pair message only for the correct error
commit 856d8e3c63 upstream.

The DASD driver has certain types of requests that might be rejected by
the storage server or z/VM because they are not supported. Since the
missing support of the command is not a real issue there is no user
visible kernel error message for this.

For copy pair setups  there is a specific error that IO is not allowed on
secondary devices. This error case is explicitly handled and an error
message is printed.

The code checking for the error did use a bitwise 'and' that is used to
check for specific bits. But in this case the whole sense byte has to
match.

This leads to the problem that the copy pair related error message is
erroneously printed for other error cases that are usually not reported.
This might heavily confuse users and lead to follow on actions that might
disrupt application processing.

Fix by checking the sense byte for the exact value and not single bits.

Cc: stable@vger.kernel.org # 6.1+
Fixes: 1fca631a11 ("s390/dasd: suppress generic error messages for PPRC secondary devices")
Signed-off-by: Stefan Haberland <sth@linux.ibm.com>
Reviewed-by: Jan Hoeppner <hoeppner@linux.ibm.com>
Link: https://lore.kernel.org/r/20230721193647.3889634-5-sth@linux.ibm.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-08-03 10:24:16 +02:00
..
block s390/dasd: print copy pair message only for the correct error 2023-08-03 10:24:16 +02:00
char
cio s390/cio: unregister device when the only path is gone 2023-06-28 11:12:37 +02:00
crypto s390/zcrypt: do not retry administrative requests 2023-07-23 13:49:35 +02:00
net s390/qeth: Fix vipa deletion 2023-07-19 16:22:06 +02:00
scsi
virtio
Makefile