mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 02:39:48 +00:00
453431a549
As said by Linus: A symmetric naming is only helpful if it implies symmetries in use. Otherwise it's actively misleading. In "kzalloc()", the z is meaningful and an important part of what the caller wants. In "kzfree()", the z is actively detrimental, because maybe in the future we really _might_ want to use that "memfill(0xdeadbeef)" or something. The "zero" part of the interface isn't even _relevant_. The main reason that kzfree() exists is to clear sensitive information that should not be leaked to other future users of the same memory objects. Rename kzfree() to kfree_sensitive() to follow the example of the recently added kvfree_sensitive() and make the intention of the API more explicit. In addition, memzero_explicit() is used to clear the memory to make sure that it won't get optimized away by the compiler. The renaming is done by using the command sequence: git grep -w --name-only kzfree |\ xargs sed -i 's/kzfree/kfree_sensitive/' followed by some editing of the kfree_sensitive() kerneldoc and adding a kzfree backward compatibility macro in slab.h. [akpm@linux-foundation.org: fs/crypto/inline_crypt.c needs linux/slab.h] [akpm@linux-foundation.org: fix fs/crypto/inline_crypt.c some more] Suggested-by: Joe Perches <joe@perches.com> Signed-off-by: Waiman Long <longman@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Acked-by: David Howells <dhowells@redhat.com> Acked-by: Michal Hocko <mhocko@suse.com> Acked-by: Johannes Weiner <hannes@cmpxchg.org> Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> Cc: James Morris <jmorris@namei.org> Cc: "Serge E. Hallyn" <serge@hallyn.com> Cc: Joe Perches <joe@perches.com> Cc: Matthew Wilcox <willy@infradead.org> Cc: David Rientjes <rientjes@google.com> Cc: Dan Carpenter <dan.carpenter@oracle.com> Cc: "Jason A . Donenfeld" <Jason@zx2c4.com> Link: http://lkml.kernel.org/r/20200616154311.12314-3-longman@redhat.com Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
77 lines
1.8 KiB
C
77 lines
1.8 KiB
C
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
/*
|
|
* Asynchronous Compression operations
|
|
*
|
|
* Copyright (c) 2016, Intel Corporation
|
|
* Authors: Weigang Li <weigang.li@intel.com>
|
|
* Giovanni Cabiddu <giovanni.cabiddu@intel.com>
|
|
*/
|
|
#ifndef _CRYPTO_ACOMP_INT_H
|
|
#define _CRYPTO_ACOMP_INT_H
|
|
#include <crypto/acompress.h>
|
|
|
|
/*
|
|
* Transform internal helpers.
|
|
*/
|
|
static inline void *acomp_request_ctx(struct acomp_req *req)
|
|
{
|
|
return req->__ctx;
|
|
}
|
|
|
|
static inline void *acomp_tfm_ctx(struct crypto_acomp *tfm)
|
|
{
|
|
return tfm->base.__crt_ctx;
|
|
}
|
|
|
|
static inline void acomp_request_complete(struct acomp_req *req,
|
|
int err)
|
|
{
|
|
req->base.complete(&req->base, err);
|
|
}
|
|
|
|
static inline const char *acomp_alg_name(struct crypto_acomp *tfm)
|
|
{
|
|
return crypto_acomp_tfm(tfm)->__crt_alg->cra_name;
|
|
}
|
|
|
|
static inline struct acomp_req *__acomp_request_alloc(struct crypto_acomp *tfm)
|
|
{
|
|
struct acomp_req *req;
|
|
|
|
req = kzalloc(sizeof(*req) + crypto_acomp_reqsize(tfm), GFP_KERNEL);
|
|
if (likely(req))
|
|
acomp_request_set_tfm(req, tfm);
|
|
return req;
|
|
}
|
|
|
|
static inline void __acomp_request_free(struct acomp_req *req)
|
|
{
|
|
kfree_sensitive(req);
|
|
}
|
|
|
|
/**
|
|
* crypto_register_acomp() -- Register asynchronous compression algorithm
|
|
*
|
|
* Function registers an implementation of an asynchronous
|
|
* compression algorithm
|
|
*
|
|
* @alg: algorithm definition
|
|
*
|
|
* Return: zero on success; error code in case of error
|
|
*/
|
|
int crypto_register_acomp(struct acomp_alg *alg);
|
|
|
|
/**
|
|
* crypto_unregister_acomp() -- Unregister asynchronous compression algorithm
|
|
*
|
|
* Function unregisters an implementation of an asynchronous
|
|
* compression algorithm
|
|
*
|
|
* @alg: algorithm definition
|
|
*/
|
|
void crypto_unregister_acomp(struct acomp_alg *alg);
|
|
|
|
int crypto_register_acomps(struct acomp_alg *algs, int count);
|
|
void crypto_unregister_acomps(struct acomp_alg *algs, int count);
|
|
|
|
#endif
|