mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-16 07:35:14 +00:00
40fbb23881
The recent coreboot memory console update (firmware: google: memconsole:
Adapt to new coreboot ring buffer format) introduced a small security
issue in the driver: The new driver implementation parses the memory
console structure again on every access. This is intentional so that
additional lines added concurrently by runtime firmware can be read out.
However, if an attacker can write to the structure, they could increase
the size value to a point where the driver would read potentially
sensitive memory areas from outside the original console buffer during
the next access. This can be done through /dev/mem, since the console
buffer usually resides in firmware-reserved memory that is not covered
by STRICT_DEVMEM.
This patch resolves that problem by reading the buffer's size value only
once during boot (where we can still trust the structure). Other parts
of the structure can still be modified at runtime, but the driver's
bounds checks make sure that it will never read outside the buffer.
Fixes:
|
||
|---|---|---|
| .. | ||
| coreboot_table-acpi.c | ||
| coreboot_table-of.c | ||
| coreboot_table.c | ||
| coreboot_table.h | ||
| gsmi.c | ||
| Kconfig | ||
| Makefile | ||
| memconsole-coreboot.c | ||
| memconsole-x86-legacy.c | ||
| memconsole.c | ||
| memconsole.h | ||
| vpd.c | ||
| vpd_decode.c | ||
| vpd_decode.h | ||