mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-01 14:44:12 +00:00
0fc6ff5a0f
`strncpy` is deprecated for use on NUL-terminated destination strings [1]. `efi_loader_signature` has space for 4 bytes. We are copying "Xen" (3 bytes) plus a NUL-byte which makes 4 total bytes. With that being said, there is currently not a bug with the current `strncpy()` implementation in terms of buffer overreads but we should favor a more robust string interface either way. A suitable replacement is `strscpy` [2] due to the fact that it guarantees NUL-termination on the destination buffer while being functionally the same in this case. Link: www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings[1] Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2] Link: https://github.com/KSPP/linux/issues/90 Cc: linux-hardening@vger.kernel.org Cc: Kees Cook <keescook@chromium.org> Signed-off-by: Justin Stitt <justinstitt@google.com> Reviewed-by: Kees Cook <keescook@chromium.org> Link: https://lore.kernel.org/r/20230911-strncpy-arch-x86-xen-efi-c-v1-1-96ab2bba2feb@google.com Signed-off-by: Juergen Gross <jgross@suse.com> |
||
|---|---|---|
| .. | ||
| apic.c | ||
| debugfs.c | ||
| debugfs.h | ||
| efi.c | ||
| enlighten.c | ||
| enlighten_hvm.c | ||
| enlighten_pv.c | ||
| enlighten_pvh.c | ||
| grant-table.c | ||
| irq.c | ||
| Kconfig | ||
| Makefile | ||
| mmu.c | ||
| mmu.h | ||
| mmu_hvm.c | ||
| mmu_pv.c | ||
| multicalls.c | ||
| multicalls.h | ||
| p2m.c | ||
| platform-pci-unplug.c | ||
| pmu.c | ||
| pmu.h | ||
| setup.c | ||
| smp.c | ||
| smp.h | ||
| smp_hvm.c | ||
| smp_pv.c | ||
| spinlock.c | ||
| suspend.c | ||
| suspend_hvm.c | ||
| suspend_pv.c | ||
| time.c | ||
| trace.c | ||
| vga.c | ||
| xen-asm.S | ||
| xen-head.S | ||
| xen-ops.h | ||