mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-12 05:48:40 +00:00
![]() When checkpatch is run on ab8500-debugfs.c it screamed blue murder! This patch fixes up all of the errors/warnings reported: WARNING: line over 80 characters + err = seq_printf(s, " [0x%02X/0x%02X]: 0x%02X\n", WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... + printk(KERN_INFO" [0x%02X/0x%02X]: 0x%02X\n", WARNING: Prefer seq_puts to seq_printf + seq_printf(s, AB8500_NAME_STRING " register values:\n"); WARNING: Prefer seq_puts to seq_printf + seq_printf(s, AB8500_NAME_STRING " register values:\n"); WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... + printk(KERN_INFO"ab8500 register values:\n"); WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... + printk(KERN_INFO" bank 0x%02X:\n", i); WARNING: externs should be avoided in .c files +extern int prcmu_abb_read(u8 slave, u8 reg, u8 *value, u8 size); WARNING: quoted string split across lines + pr_info("Saving all ABB registers at \"ab8500_complete_register_dump\" " + "for crash analyze.\n"); WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... + printk(KERN_ERR "abx500_set_reg failed %d, %d", err, __LINE__); WARNING: Prefer seq_puts to seq_printf + seq_printf(s, "name: number: number of: wake:\n"); WARNING: line over 80 characters + return single_open(file, ab8500_print_modem_registers, inode->i_private); WARNING: line over 80 characters + return single_open(file, ab8500_gpadc_btemp_ball_print, inode->i_private); WARNING: line over 80 characters + return single_open(file, ab8500_gpadc_main_bat_v_print, inode->i_private); WARNING: line over 80 characters + vbat_true_meas_convert = ab8500_gpadc_ad_to_voltage(gpadc, VBAT_TRUE_MEAS, WARNING: line over 80 characters +static int ab8540_gpadc_vbat_true_meas_and_ibat_print(struct seq_file *s, void *p) WARNING: line over 80 characters +static const struct file_operations ab8540_gpadc_vbat_true_meas_and_ibat_fops = { WARNING: line over 80 characters + vmain_l, vmain_h, btemp_l, btemp_h, vbat_l, vbat_h, ibat_l, ibat_h); WARNING: quoted string split across lines + dev_err(dev, "debugfs error input: " + "should be egal to 1, 4, 8 or 16\n"); WARNING: Missing a blank line after declarations + char *s = b; + if ((*s == '0') && ((*(s+1) == 'x') || (*(s+1) == 'X'))) { WARNING: simple_strtoul is obsolete, use kstrtoul instead + loc.mask = simple_strtoul(b, &b, 0); WARNING: simple_strtol is obsolete, use kstrtol instead + loc.shift = simple_strtol(b, &b, 0); WARNING: simple_strtoul is obsolete, use kstrtoul instead + loc.bank = simple_strtoul(b, &b, 0); WARNING: simple_strtoul is obsolete, use kstrtoul instead + loc.addr = simple_strtoul(b, &b, 0); WARNING: simple_strtoul is obsolete, use kstrtoul instead + val = simple_strtoul(b, &b, 0); WARNING: quoted string split across lines + pr_warn("HWREG request: %s, %s, addr=0x%08X, mask=0x%X, shift=%d" + "value=0x%X\n", (write) ? "write" : "read", WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... + printk(KERN_ERR "sysfs_create_file failed %d\n", err); WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... + printk(KERN_ERR "request_threaded_irq failed %d, %lu\n", ERROR: code indent should use tabs where possible + err, user_val);$ WARNING: please, no spaces at the start of a line + err, user_val);$ WARNING: Missing a blank line after declarations + struct resource *res; + debug_bank = AB8500_MISC; ERROR: space required after that ',' (ctx:VxV) + sizeof(*dev_attr)*num_irqs,GFP_KERNEL); ^ WARNING: return of an errno should typically be -ve (return -ENXIO) + return ENXIO; WARNING: line over 80 characters + file = debugfs_create_file("register-bank", (S_IRUGO | S_IWUSR | S_IWGRP), WARNING: line over 80 characters + file = debugfs_create_file("register-address", (S_IRUGO | S_IWUSR | S_IWGRP), WARNING: line over 80 characters + file = debugfs_create_file("register-value", (S_IRUGO | S_IWUSR | S_IWGRP), WARNING: line over 80 characters + file = debugfs_create_file("irq-subscribe", (S_IRUGO | S_IWUSR | S_IWGRP), WARNING: line over 80 characters + file = debugfs_create_file("irq-unsubscribe", (S_IRUGO | S_IWUSR | S_IWGRP), WARNING: line over 80 characters + file = debugfs_create_file("all-modem-registers", (S_IRUGO | S_IWUSR | S_IWGRP), WARNING: line over 80 characters + file = debugfs_create_file("main_charger_v", (S_IRUGO | S_IWUSR | S_IWGRP), WARNING: line over 80 characters + file = debugfs_create_file("main_charger_c", (S_IRUGO | S_IWUSR | S_IWGRP), WARNING: line over 80 characters + file = debugfs_create_file("usb_charger_c", (S_IRUGO | S_IWUSR | S_IWGRP), WARNING: line over 80 characters + file = debugfs_create_file("xtal_temp", (S_IRUGO | S_IWUSR | S_IWGRP), WARNING: line over 80 characters + ab8500_gpadc_dir, &plf->dev, &ab8540_gpadc_xtal_temp_fops); WARNING: line over 80 characters + file = debugfs_create_file("vbattruemeas", (S_IRUGO | S_IWUSR | S_IWGRP), WARNING: line over 80 characters + file = debugfs_create_file("otp_calib", (S_IRUGO | S_IWUSR | S_IWGRP), WARNING: line over 80 characters + ab8500_gpadc_dir, &plf->dev, &ab8540_gpadc_otp_calib_fops); total: 2 errors, 44 warnings, 3230 lines checked Signed-off-by: Lee Jones <lee.jones@linaro.org> |
||
---|---|---|
.. | ||
88pm80x.c | ||
88pm800.c | ||
88pm805.c | ||
88pm860x-core.c | ||
88pm860x-i2c.c | ||
aat2870-core.c | ||
ab3100-core.c | ||
ab3100-otp.c | ||
ab8500-core.c | ||
ab8500-debugfs.c | ||
ab8500-gpadc.c | ||
ab8500-sysctrl.c | ||
abx500-core.c | ||
adp5520.c | ||
arizona-core.c | ||
arizona-i2c.c | ||
arizona-irq.c | ||
arizona-spi.c | ||
arizona.h | ||
as3711.c | ||
as3722.c | ||
asic3.c | ||
axp20x.c | ||
bcm590xx.c | ||
cros_ec.c | ||
cros_ec_i2c.c | ||
cros_ec_spi.c | ||
cs5535-mfd.c | ||
da903x.c | ||
da9052-core.c | ||
da9052-i2c.c | ||
da9052-irq.c | ||
da9052-spi.c | ||
da9055-core.c | ||
da9055-i2c.c | ||
da9063-core.c | ||
da9063-i2c.c | ||
da9063-irq.c | ||
davinci_voicecodec.c | ||
db8500-prcmu.c | ||
dbx500-prcmu-regs.h | ||
dm355evm_msp.c | ||
ezx-pcap.c | ||
htc-egpio.c | ||
htc-i2cpld.c | ||
htc-pasic3.c | ||
intel_msic.c | ||
intel_soc_pmic_core.c | ||
intel_soc_pmic_core.h | ||
intel_soc_pmic_crc.c | ||
ipaq-micro.c | ||
janz-cmodio.c | ||
jz4740-adc.c | ||
Kconfig | ||
kempld-core.c | ||
lm3533-core.c | ||
lm3533-ctrlbank.c | ||
lp3943.c | ||
lp8788-irq.c | ||
lp8788.c | ||
lpc_ich.c | ||
lpc_sch.c | ||
Makefile | ||
max8907.c | ||
max8925-core.c | ||
max8925-i2c.c | ||
max8997-irq.c | ||
max8997.c | ||
max8998-irq.c | ||
max8998.c | ||
max14577.c | ||
max77686-irq.c | ||
max77686.c | ||
max77693.c | ||
mc13xxx-core.c | ||
mc13xxx-i2c.c | ||
mc13xxx-spi.c | ||
mc13xxx.h | ||
mcp-core.c | ||
mcp-sa11x0.c | ||
menelaus.c | ||
mfd-core.c | ||
omap-usb-host.c | ||
omap-usb-tll.c | ||
omap-usb.h | ||
palmas.c | ||
pcf50633-adc.c | ||
pcf50633-core.c | ||
pcf50633-gpio.c | ||
pcf50633-irq.c | ||
pm8921-core.c | ||
rc5t583-irq.c | ||
rc5t583.c | ||
rdc321x-southbridge.c | ||
retu-mfd.c | ||
rtl8411.c | ||
rts5209.c | ||
rts5227.c | ||
rts5229.c | ||
rts5249.c | ||
rtsx_pcr.c | ||
rtsx_pcr.h | ||
rtsx_usb.c | ||
sec-core.c | ||
sec-irq.c | ||
si476x-cmd.c | ||
si476x-i2c.c | ||
si476x-prop.c | ||
sm501.c | ||
smsc-ece1099.c | ||
ssbi.c | ||
sta2x11-mfd.c | ||
stmpe-i2c.c | ||
stmpe-spi.c | ||
stmpe.c | ||
stmpe.h | ||
stw481x.c | ||
sun6i-prcm.c | ||
syscon.c | ||
t7l66xb.c | ||
tc3589x.c | ||
tc6387xb.c | ||
tc6393xb.c | ||
ti_am335x_tscadc.c | ||
timberdale.c | ||
timberdale.h | ||
tmio_core.c | ||
tps6105x.c | ||
tps6507x.c | ||
tps6586x.c | ||
tps65010.c | ||
tps65090.c | ||
tps65217.c | ||
tps65218.c | ||
tps65910.c | ||
tps65911-comparator.c | ||
tps65912-core.c | ||
tps65912-i2c.c | ||
tps65912-irq.c | ||
tps65912-spi.c | ||
tps80031.c | ||
twl-core.c | ||
twl-core.h | ||
twl4030-audio.c | ||
twl4030-irq.c | ||
twl4030-power.c | ||
twl6030-irq.c | ||
twl6040.c | ||
ucb1x00-assabet.c | ||
ucb1x00-core.c | ||
ucb1x00-ts.c | ||
ucb1400_core.c | ||
vexpress-sysreg.c | ||
viperboard.c | ||
vx855.c | ||
wl1273-core.c | ||
wm831x-auxadc.c | ||
wm831x-core.c | ||
wm831x-i2c.c | ||
wm831x-irq.c | ||
wm831x-otp.c | ||
wm831x-spi.c | ||
wm5102-tables.c | ||
wm5110-tables.c | ||
wm8350-core.c | ||
wm8350-gpio.c | ||
wm8350-i2c.c | ||
wm8350-irq.c | ||
wm8350-regmap.c | ||
wm8400-core.c | ||
wm8994-core.c | ||
wm8994-irq.c | ||
wm8994-regmap.c | ||
wm8994.h | ||
wm8997-tables.c |