Norbert Manthey 4c6d80e114 pstore: Fix double-free in pstore_mkfile() failure path ... The pstore_mkfile() function is passed a pointer to a struct pstore_record. On success it consumes this 'record' pointer and references it from the created inode. On failure, however, it may or may not free the record. There are even two different code paths which return -ENOMEM -- one of which does and the other doesn't free the record. Make the behaviour deterministic by never consuming and freeing the record when returning failure, allowing the caller to do the cleanup consistently. Signed-off-by: Norbert Manthey <nmanthey@amazon.de> Link: https://lore.kernel.org/r/1562331960-26198-1-git-send-email-nmanthey@amazon.de Fixes: 83f70f0769 ("pstore: Do not duplicate record metadata") Fixes: 1dfff7dd67 ("pstore: Pass record contents instead of copying") Cc: stable@vger.kernel.org [kees: also move "private" allocation location, rename inode cleanup label] Signed-off-by: Kees Cook <keescook@chromium.org>		2019-07-08 21:04:42 -07:00
..
ftrace.c	pstore: no need to check return value of debugfs_create functions	2019-07-08 21:04:42 -07:00
inode.c	pstore: Fix double-free in pstore_mkfile() failure path	2019-07-08 21:04:42 -07:00
internal.h	pstore: Centralize init/exit routines	2018-10-22 07:11:58 -07:00
Kconfig	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
platform.c	SPDX update for 5.2-rc4	2019-06-08 12:52:42 -07:00
pmsg.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282	2019-06-05 17:36:37 +02:00
ram.c	pstore/ram: Improve backward compatibility with older Chromebooks	2019-07-08 21:04:42 -07:00
ram_core.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282	2019-06-05 17:36:37 +02:00