Yu Kuai 7380a73621 blk-wbt: call rq_qos_add() after wb_normal is initialized ... commit 8c5035dfbb upstream. Our test found a problem that wbt inflight counter is negative, which will cause io hang(noted that this problem doesn't exist in mainline): t1: device create t2: issue io add_disk blk_register_queue wbt_enable_default wbt_init rq_qos_add // wb_normal is still 0 /* * in mainline, disk can't be opened before * bdev_add(), however, in old kernels, disk * can be opened before blk_register_queue(). */ blkdev_issue_flush // disk size is 0, however, it's not checked submit_bio_wait submit_bio blk_mq_submit_bio rq_qos_throttle wbt_wait bio_to_wbt_flags rwb_enabled // wb_normal is 0, inflight is not increased wbt_queue_depth_changed(&rwb->rqos); wbt_update_limits // wb_normal is initialized rq_qos_track wbt_track rq->wbt_flags |= bio_to_wbt_flags(rwb, bio); // wb_normal is not 0，wbt_flags will be set t3: io completion blk_mq_free_request rq_qos_done wbt_done wbt_is_tracked // return true __wbt_done wbt_rqw_done atomic_dec_return(&rqw->inflight); // inflight is decreased commit 8235b5c1e8 ("block: call bdev_add later in device_add_disk") can avoid this problem, however it's better to fix this problem in wbt: 1) Lower kernel can't backport this patch due to lots of refactor. 2) Root cause is that wbt call rq_qos_add() before wb_normal is initialized. Fixes: e34cbd3074 ("blk-wbt: add general throttling mechanism") Cc: <stable@vger.kernel.org> Signed-off-by: Yu Kuai <yukuai3@huawei.com> Link: https://lore.kernel.org/r/20220913105749.3086243-1-yukuai1@huaweicloud.com Signed-off-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2022-10-21 12:37:54 +02:00
..
partitions	block: don't add partitions if GD_SUPPRESS_PART_SCAN is set	2022-09-03 11:29:03 -06:00
badblocks.c	block/badblocks: Remove redundant assignments	2022-04-23 07:15:26 -06:00
bdev.c	block: stop using bdevname in bdev_write_inode	2022-07-14 10:27:56 -06:00
bfq-cgroup.c	block/bfq: Use the new blk_opf_t type	2022-07-14 12:14:30 -06:00
bfq-iosched.c	block/bfq: Use the new blk_opf_t type	2022-07-14 12:14:30 -06:00
bfq-iosched.h	block/bfq: Use the new blk_opf_t type	2022-07-14 12:14:30 -06:00
bfq-wf2q.c	block: bfq: Fix kernel-doc headers	2022-06-27 06:29:12 -06:00
bio-integrity.c	block: pass struct queue_limits to the bio splitting helpers	2022-08-02 21:08:53 -06:00
bio.c	blk-throttle: fix that io throttle can only work for single bio	2022-10-21 12:37:54 +02:00
blk-cgroup-fc-appid.c	blk-cgroup: move blkcg_{get,set}_fc_appid out of line	2022-05-02 14:06:20 -06:00
blk-cgroup-rwstat.c	blk-cgroup: Fix the recursive blkg rwstat	2021-03-05 11:32:15 -07:00
blk-cgroup-rwstat.h	block: Use the new blk_opf_t type	2022-07-14 12:14:30 -06:00
blk-cgroup.c	blk-cgroup: Use atomic{,64}_try_cmpxchg	2022-07-12 15:46:03 -06:00
blk-cgroup.h	blk-cgroup: Use atomic{,64}_try_cmpxchg	2022-07-12 15:46:03 -06:00
blk-core.c	block: blk_queue_enter() / __bio_queue_enter() must return -EAGAIN for nowait	2022-09-13 15:06:39 -06:00
blk-crypto-fallback.c	block: remove superfluous calls to blkcg_bio_issue_init	2022-05-04 18:29:52 -06:00
blk-crypto-internal.h	blk-crypto: show crypto capabilities in sysfs	2022-02-28 06:40:23 -07:00
blk-crypto-profile.c	blk-crypto: remove blk_crypto_unregister()	2021-11-29 06:38:51 -07:00
blk-crypto-sysfs.c	blk-crypto: show crypto capabilities in sysfs	2022-02-28 06:40:23 -07:00
blk-crypto.c	blk-crypto: show crypto capabilities in sysfs	2022-02-28 06:40:23 -07:00
blk-flush.c	block: Use the new blk_opf_t type	2022-07-14 12:14:30 -06:00
blk-ia-ranges.c	block: simplify disk_set_independent_access_ranges	2022-06-29 08:36:46 -06:00
blk-integrity.c	blk-crypto: remove blk_crypto_unregister()	2021-11-29 06:38:51 -07:00
blk-ioc.c	block: fix default IO priority handling again	2022-06-27 06:29:12 -06:00
blk-iocost.c	block: don't allow the same type rq_qos add more than once	2022-07-20 06:44:14 -06:00
blk-iolatency.c	block: don't allow the same type rq_qos add more than once	2022-07-20 06:44:14 -06:00
blk-ioprio.c	blk-ioprio: Convert from rqos policy to direct call	2022-06-27 06:29:12 -06:00
blk-ioprio.h	blk-ioprio: Convert from rqos policy to direct call	2022-06-27 06:29:12 -06:00
blk-lib.c	blk-lib: fix blkdev_issue_secure_erase	2022-09-15 00:25:17 -06:00
blk-map.c	block: convert to advancing variants of iov_iter_get_pages{,_alloc}()	2022-08-08 22:37:22 -04:00
blk-merge.c	block: pass struct queue_limits to the bio splitting helpers	2022-08-02 21:08:53 -06:00
blk-mq-cpumap.c	blk-mq: remove the calling of local_memory_node()	2020-10-20 07:08:17 -06:00
blk-mq-debugfs-zoned.c	block: move zone related fields to struct gendisk	2022-07-06 06:46:26 -06:00
blk-mq-debugfs.c	block: add missing request flags to debugfs code	2022-09-09 05:57:52 -06:00
blk-mq-debugfs.h	block: remove per-disk debugfs files in blk_unregister_queue	2022-06-17 07:31:05 -06:00
blk-mq-pci.c
blk-mq-rdma.c
blk-mq-sched.c	block: serialize all debugfs operations using q->debugfs_mutex	2022-06-17 07:31:05 -06:00
blk-mq-sched.h	block: move blk_mq_sched_assign_ioc to blk-ioc.c	2021-11-29 06:41:29 -07:00
blk-mq-sysfs.c	blk-mq: cleanup disk sysfs registration	2022-06-28 11:32:42 -06:00
blk-mq-tag.c	blk-mq: Drop local variable for reserved tag	2022-07-06 06:33:53 -06:00
blk-mq-tag.h	blk-mq: blk_mq_tag_busy is no need to return a value	2022-06-27 06:29:12 -06:00
blk-mq-virtio.c
blk-mq.c	blk-mq: fix io hung due to missing commit_rqs	2022-08-19 20:45:58 +00:00
blk-mq.h	block: Use the new blk_opf_t type	2022-07-14 12:14:30 -06:00
blk-pm.c	scsi: block: pm: Always set request queue runtime active in blk_post_runtime_resume()	2021-12-22 23:38:29 -05:00
blk-pm.h	block: Remove unused blk_pm_*() function definitions	2021-02-22 06:33:48 -07:00
blk-rq-qos.c	block/rq_qos: Use atomic_try_cmpxchg in atomic_inc_below	2022-07-12 14:38:52 -06:00
blk-rq-qos.h	block: don't allow the same type rq_qos add more than once	2022-07-20 06:44:14 -06:00
blk-settings.c	block: pass a gendisk to blk_queue_clear_zone_settings	2022-07-06 06:46:26 -06:00
blk-stat.c	block: make queue stat accounting a reference	2021-12-14 17:23:05 -07:00
blk-stat.h	block: make queue stat accounting a reference	2021-12-14 17:23:05 -07:00
blk-sysfs.c	block: move ->bio_split to the gendisk	2022-08-02 21:08:49 -06:00
blk-throttle.c	blk-throttle: fix that io throttle can only work for single bio	2022-10-21 12:37:54 +02:00
blk-throttle.h	blk-throttle: fix that io throttle can only work for single bio	2022-10-21 12:37:54 +02:00
blk-timeout.c	block: blk-timeout: delete duplicated word	2020-07-31 16:29:47 -06:00
blk-wbt.c	blk-wbt: call rq_qos_add() after wb_normal is initialized	2022-10-21 12:37:54 +02:00
blk-wbt.h	blk-wbt: remove wbt_track stub	2022-03-31 12:58:38 -06:00
blk-zoned.c	treewide: Rename enum req_opf into enum req_op	2022-07-14 12:14:30 -06:00
blk.h	block: pass struct queue_limits to the bio splitting helpers	2022-08-02 21:08:53 -06:00
bounce.c	block: change the blk_queue_bounce calling convention	2022-08-02 17:22:54 -06:00
bsg-lib.c	blk-mq: Drop blk_mq_ops.timeout 'reserved' arg	2022-07-06 06:33:53 -06:00
bsg.c	scsi: core: bsg: Remove usage of the deprecated ida_simple_xxx() API	2022-06-21 21:22:51 -04:00
disk-events.c	block: remove genhd.h	2022-02-02 07:49:59 -07:00
elevator.c	for-5.18/block-2022-03-18	2022-03-21 16:48:55 -07:00
elevator.h	block: Use the new blk_opf_t type	2022-07-14 12:14:30 -06:00
fops.c	new iov_iter flavour - ITER_UBUF	2022-08-08 22:37:15 -04:00
genhd.c	Revert "block: freeze the queue earlier in del_gendisk"	2022-09-20 08:15:44 -06:00
holder.c	block: remove WARN_ON() from bd_link_disk_holder	2022-06-23 07:48:05 -06:00
ioctl.c	block: replace blkdev_nr_zones with bdev_nr_zones	2022-07-06 06:46:26 -06:00
ioprio.c	block: Fix handling of tasks without ioprio in ioprio_get(2)	2022-06-27 06:29:12 -06:00
Kconfig	block: remove "select BLK_RQ_IO_DATA_LEN" from BLK_CGROUP_IOCOST dependency	2022-06-29 08:35:57 -06:00
Kconfig.iosched	block: only build the icq tracking code when needed	2021-12-16 10:59:02 -07:00
kyber-iosched.c	block/kyber: Use the new blk_opf_t type	2022-07-14 12:14:30 -06:00
Makefile	blk-cgroup: move blkcg_{get,set}_fc_appid out of line	2022-05-02 14:06:20 -06:00
mq-deadline.c	block/mq-deadline: Use the new blk_opf_t type	2022-07-14 12:14:30 -06:00
opal_proto.h
sed-opal.c	block: remove genhd.h	2022-02-02 07:49:59 -07:00
t10-pi.c	block: add pi for extended integrity	2022-03-07 12:48:35 -07:00