Wolfram Sang 97a2d55ead virtio-mmio: don't break lifecycle of vm_dev ... [ Upstream commit 55c91fedd0 ] vm_dev has a separate lifecycle because it has a 'struct device' embedded. Thus, having a release callback for it is correct. Allocating the vm_dev struct with devres totally breaks this protection, though. Instead of waiting for the vm_dev release callback, the memory is freed when the platform_device is removed. Resulting in a use-after-free when finally the callback is to be called. To easily see the problem, compile the kernel with CONFIG_DEBUG_KOBJECT_RELEASE and unbind with sysfs. The fix is easy, don't use devres in this case. Found during my research about object lifetime problems. Fixes: 7eb781b1bb ("virtio_mmio: add cleanup for virtio_mmio_probe") Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Message-Id: <20230629120526.7184-1-wsa+renesas@sang-engineering.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-08-30 16:31:47 +02:00
..
Kconfig
Makefile
virtio.c	virtio: acknowledge all features before access	2022-03-16 13:20:27 +01:00
virtio_balloon.c
virtio_input.c
virtio_mmio.c	virtio-mmio: don't break lifecycle of vm_dev	2023-08-30 16:31:47 +02:00
virtio_pci_common.c	virtio-pci: Remove wrong address verification in vp_del_vqs()	2022-06-25 11:49:17 +02:00
virtio_pci_common.h
virtio_pci_legacy.c
virtio_pci_modern.c
virtio_ring.c	treewide: Remove uninitialized_var() usage	2023-08-11 11:45:01 +02:00