mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-04 08:08:54 +00:00
46243b85b0
The position reporting on Intel Skylake and later chips via
azx_get_pos_skl() contains a udelay(20) call for the capture streams.
A call for this alone doesn't sound too harmful. However, as the
pointer PCM ops is one of the hottest path in the PCM operations --
especially for the timer-scheduled operations like PulseAudio -- such
a delay hogs CPU usage significantly in the total performance.
The code there was taken from the original code in ASoC SST Skylake
driver blindly. The udelay() is a workaround for the case where the
reported position is behind the period boundary at the timing
triggered from interrupts; applications often expect that the full
data is available for the whole period when returned (and also that's
the definition of the ALSA PCM period).
OTOH, HD-audio (legacy) driver has already some workarounds for the
delayed position reporting due to its relatively large FIFO, such as
the BDL position adjustment and the delayed period-elapsed call in the
work. That said, the udelay() is almost superfluous for HD-audio
driver unlike SST, and we can drop the udelay().
Though, the current code doesn't guarantee the full period readiness
as mentioned in the above, but rather it checks the wallclock and
detects the unexpected jump. That's one missing piece, and the drop
of udelay() needs a bit more sanity checks for the delayed handling.
This patch implements those: the drop of udelay() call in
azx_get_pos_skl() and the more proper check of hwptr in
azx_position_ok(). The latter change is applied only for the case
where the stream is running in the normal mode without
no_period_wakeup flag. When no_period_wakeup is set, it essentially
ignores the period handling and rather concentrates only on the
current position; which implies that we don't need to care about the
period boundary at all.
Fixes:
|
||
|---|---|---|
| .. | ||
| ca0132_regs.h | ||
| hda_auto_parser.c | ||
| hda_auto_parser.h | ||
| hda_beep.c | ||
| hda_beep.h | ||
| hda_bind.c | ||
| hda_codec.c | ||
| hda_controller.c | ||
| hda_controller.h | ||
| hda_controller_trace.h | ||
| hda_eld.c | ||
| hda_generic.c | ||
| hda_generic.h | ||
| hda_hwdep.c | ||
| hda_intel.c | ||
| hda_intel.h | ||
| hda_intel_trace.h | ||
| hda_jack.c | ||
| hda_jack.h | ||
| hda_local.h | ||
| hda_proc.c | ||
| hda_sysfs.c | ||
| hda_tegra.c | ||
| hp_x360_helper.c | ||
| ideapad_s740_helper.c | ||
| Kconfig | ||
| Makefile | ||
| patch_analog.c | ||
| patch_ca0110.c | ||
| patch_ca0132.c | ||
| patch_cirrus.c | ||
| patch_cmedia.c | ||
| patch_conexant.c | ||
| patch_cs8409-tables.c | ||
| patch_cs8409.c | ||
| patch_cs8409.h | ||
| patch_hdmi.c | ||
| patch_realtek.c | ||
| patch_si3054.c | ||
| patch_sigmatel.c | ||
| patch_via.c | ||
| thinkpad_helper.c | ||