Anna Schumaker f8cf4dabbd SUNRPC: Fix a suspicious RCU usage warning ... [ Upstream commit 31b6290869 ] I received the following warning while running cthon against an ontap server running pNFS: [ 57.202521] ============================= [ 57.202522] WARNING: suspicious RCU usage [ 57.202523] 6.7.0-rc3-g2cc14f52aeb7 #41492 Not tainted [ 57.202525] ----------------------------- [ 57.202525] net/sunrpc/xprtmultipath.c:349 RCU-list traversed in non-reader section!! [ 57.202527] other info that might help us debug this: [ 57.202528] rcu_scheduler_active = 2, debug_locks = 1 [ 57.202529] no locks held by test5/3567. [ 57.202530] stack backtrace: [ 57.202532] CPU: 0 PID: 3567 Comm: test5 Not tainted 6.7.0-rc3-g2cc14f52aeb7 #41492 5b09971b4965c0aceba19f3eea324a4a806e227e [ 57.202534] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS unknown 2/2/2022 [ 57.202536] Call Trace: [ 57.202537] <TASK> [ 57.202540] dump_stack_lvl+0x77/0xb0 [ 57.202551] lockdep_rcu_suspicious+0x154/0x1a0 [ 57.202556] rpc_xprt_switch_has_addr+0x17c/0x190 [sunrpc ebe02571b9a8ceebf7d98e71675af20c19bdb1f6] [ 57.202596] rpc_clnt_setup_test_and_add_xprt+0x50/0x180 [sunrpc ebe02571b9a8ceebf7d98e71675af20c19bdb1f6] [ 57.202621] ? rpc_clnt_add_xprt+0x254/0x300 [sunrpc ebe02571b9a8ceebf7d98e71675af20c19bdb1f6] [ 57.202646] rpc_clnt_add_xprt+0x27a/0x300 [sunrpc ebe02571b9a8ceebf7d98e71675af20c19bdb1f6] [ 57.202671] ? __pfx_rpc_clnt_setup_test_and_add_xprt+0x10/0x10 [sunrpc ebe02571b9a8ceebf7d98e71675af20c19bdb1f6] [ 57.202696] nfs4_pnfs_ds_connect+0x345/0x760 [nfsv4 c716d88496ded0ea6d289bbea684fa996f9b57a9] [ 57.202728] ? __pfx_nfs4_test_session_trunk+0x10/0x10 [nfsv4 c716d88496ded0ea6d289bbea684fa996f9b57a9] [ 57.202754] nfs4_fl_prepare_ds+0x75/0xc0 [nfs_layout_nfsv41_files e3a4187f18ae8a27b630f9feae6831b584a9360a] [ 57.202760] filelayout_write_pagelist+0x4a/0x200 [nfs_layout_nfsv41_files e3a4187f18ae8a27b630f9feae6831b584a9360a] [ 57.202765] pnfs_generic_pg_writepages+0xbe/0x230 [nfsv4 c716d88496ded0ea6d289bbea684fa996f9b57a9] [ 57.202788] __nfs_pageio_add_request+0x3fd/0x520 [nfs 6c976fa593a7c2976f5a0aeb4965514a828e6902] [ 57.202813] nfs_pageio_add_request+0x18b/0x390 [nfs 6c976fa593a7c2976f5a0aeb4965514a828e6902] [ 57.202831] nfs_do_writepage+0x116/0x1e0 [nfs 6c976fa593a7c2976f5a0aeb4965514a828e6902] [ 57.202849] nfs_writepages_callback+0x13/0x30 [nfs 6c976fa593a7c2976f5a0aeb4965514a828e6902] [ 57.202866] write_cache_pages+0x265/0x450 [ 57.202870] ? __pfx_nfs_writepages_callback+0x10/0x10 [nfs 6c976fa593a7c2976f5a0aeb4965514a828e6902] [ 57.202891] nfs_writepages+0x141/0x230 [nfs 6c976fa593a7c2976f5a0aeb4965514a828e6902] [ 57.202913] do_writepages+0xd2/0x230 [ 57.202917] ? filemap_fdatawrite_wbc+0x5c/0x80 [ 57.202921] filemap_fdatawrite_wbc+0x67/0x80 [ 57.202924] filemap_write_and_wait_range+0xd9/0x170 [ 57.202930] nfs_wb_all+0x49/0x180 [nfs 6c976fa593a7c2976f5a0aeb4965514a828e6902] [ 57.202947] nfs4_file_flush+0x72/0xb0 [nfsv4 c716d88496ded0ea6d289bbea684fa996f9b57a9] [ 57.202969] __se_sys_close+0x46/0xd0 [ 57.202972] do_syscall_64+0x68/0x100 [ 57.202975] ? do_syscall_64+0x77/0x100 [ 57.202976] ? do_syscall_64+0x77/0x100 [ 57.202979] entry_SYSCALL_64_after_hwframe+0x6e/0x76 [ 57.202982] RIP: 0033:0x7fe2b12e4a94 [ 57.202985] Code: 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 80 3d d5 18 0e 00 00 74 13 b8 03 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 44 c3 0f 1f 00 48 83 ec 18 89 7c 24 0c e8 c3 [ 57.202987] RSP: 002b:00007ffe857ddb38 EFLAGS: 00000202 ORIG_RAX: 0000000000000003 [ 57.202989] RAX: ffffffffffffffda RBX: 00007ffe857dfd68 RCX: 00007fe2b12e4a94 [ 57.202991] RDX: 0000000000002000 RSI: 00007ffe857ddc40 RDI: 0000000000000003 [ 57.202992] RBP: 00007ffe857dfc50 R08: 7fffffffffffffff R09: 0000000065650f49 [ 57.202993] R10: 00007fe2b11f8300 R11: 0000000000000202 R12: 0000000000000000 [ 57.202994] R13: 00007ffe857dfd80 R14: 00007fe2b1445000 R15: 0000000000000000 [ 57.202999] </TASK> The problem seems to be that two out of three callers aren't taking the rcu_read_lock() before calling the list_for_each_entry_rcu() function in rpc_xprt_switch_has_addr(). I fix this by having rpc_xprt_switch_has_addr() unconditionaly take the rcu_read_lock(), which is okay to do recursively in the case that the lock has already been taken by a caller. Reviewed-by: Jeff Layton <jlayton@kernel.org> Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-02-23 08:54:40 +01:00
..
6lowpan
9p	net: 9p: avoid freeing uninit memory in p9pdu_vreadf	2024-01-05 15:13:34 +01:00
802	mrp: introduce active flags to prevent UAF when applicant uninit	2022-12-31 13:14:42 +01:00
8021q	vlan: skip nested type that is not IFLA_VLAN_QOS_MAPPING	2024-02-23 08:54:27 +01:00
appletalk	appletalk: Fix Use-After-Free in atalk_ioctl	2023-12-20 15:17:37 +01:00
atm	atm: Fix Use-After-Free in do_vcc_ioctl	2023-12-20 15:17:35 +01:00
ax25
batman-adv	net: vlan: introduce skb_vlan_eth_hdr()	2023-12-20 15:17:35 +01:00
bluetooth	Bluetooth: Fix atomicity violation in {min,max}_key_size_set	2024-01-25 14:52:48 -08:00
bpf	bpf: Move skb->len == 0 checks into __bpf_redirect	2022-12-31 13:14:11 +01:00
bpfilter
bridge	netfilter: nf_tables: add and use BE register load-store helpers	2023-11-28 16:56:24 +00:00
caif	net: caif: Fix use-after-free in cfusbl_device_notify()	2023-03-17 08:48:54 +01:00
can	can: raw: add support for SO_MARK	2024-01-15 18:51:14 +01:00
ceph	libceph: use kernel_connect()	2023-10-19 23:05:36 +02:00
core	tcp: make sure init the accept_queue's spinlocks once	2024-02-23 08:54:27 +01:00
dcb	net: dcb: choose correct policy to parse DCB_ATTR_BCN	2023-08-11 15:13:53 +02:00
dccp	net: inet: Retire port only listening_hash	2023-11-28 16:56:22 +00:00
dns_resolver	keys, dns: Fix size check of V1 server-list header	2024-01-25 14:52:46 -08:00
dsa	net: dsa: tag_sja1105: fix MAC DA patching from meta frames	2023-07-23 13:47:30 +02:00
ethernet
ethtool	ethtool: netlink: Add missing ethnl_ops_begin/complete	2024-01-25 14:52:54 -08:00
hsr	hsr: Prevent use after free in prp_create_tagged_frame()	2023-11-20 11:08:28 +01:00
ieee802154	net: ieee802154: fix error return code in dgram_bind()	2022-11-03 23:59:14 +09:00
ife	net: sched: ife: fix potential use-after-free	2024-01-05 15:13:29 +01:00
ipv4	tcp: Add memory barrier to tcp_push()	2024-02-23 08:54:28 +01:00
ipv6	ipv6: init the accept_queue's spinlocks in inet6_create	2024-02-23 08:54:28 +01:00
iucv	net/iucv: Fix size of interrupt data	2023-03-22 13:31:28 +01:00
kcm	kcm: Fix error handling for SOCK_DGRAM in kcm_sendmsg().	2023-09-19 12:23:04 +02:00
key	net: af_key: fix sadb_x_filter validation	2023-08-26 14:23:32 +02:00
l2tp	ipv4, ipv6: Fix handling of transhdrlen in __ip{,6}_append_data()	2023-10-10 21:59:07 +02:00
l3mdev
lapb
llc	llc: Drop support for ETH_P_TR_802_2.	2024-02-23 08:54:27 +01:00
mac80211	wifi: mac80211: mesh_plink: fix matches_local logic	2024-01-05 15:13:28 +01:00
mac802154	mac802154: fix missing INIT_LIST_HEAD in ieee802154_if_add()	2022-12-14 11:37:25 +01:00
mctp	mctp: perform route lookups under a RCU read-side lock	2023-10-25 11:58:59 +02:00
mpls	net: mpls: fix stale pointer if allocation fails during device rename	2023-02-22 12:57:09 +01:00
mptcp	mptcp: use OPTION_MPTCP_MPJ_SYN in subflow_check_req()	2024-01-25 14:52:53 -08:00
ncsi	net/ncsi: Fix netlink major/minor version numbers	2024-01-25 14:52:36 -08:00
netfilter	netfilter: nf_tables: reject QUEUE/DROP verdict parameters	2024-02-23 08:54:32 +01:00
netlabel	calipso: fix memory leak in netlbl_calipso_add_pass()	2024-01-25 14:52:33 -08:00
netlink	netlink: fix potential sleeping issue in mqueue_flush_file	2024-02-23 08:54:28 +01:00
netrom	netrom: Deny concurrent connect().	2023-09-19 12:22:35 +02:00
nfc	nfc: llcp_core: Hold a ref to llcp_local->dev when holding a ref to llcp_local	2024-01-15 18:51:09 +01:00
nsh	net: nsh: Use correct mac_offset to unwind gso skb in nsh_gso_segment()	2023-05-24 17:36:51 +01:00
openvswitch	net: openvswitch: fix possible memory leak in ovs_meter_cmd_set()	2023-02-22 12:57:09 +01:00
packet	packet: Move reference count in packet_sock to atomic_long_t	2023-12-13 18:36:43 +01:00
phonet
psample	psample: Require 'CAP_NET_ADMIN' when joining "packets" group	2023-12-13 18:36:37 +01:00
qrtr	net: qrtr: ns: Return 0 if server port is not present	2024-01-25 14:52:30 -08:00
rds	net/rds: Fix UBSAN: array-index-out-of-bounds in rds_cmsg_recv	2024-02-23 08:54:27 +01:00
rfkill	net: rfkill: gpio: set GPIO direction	2024-01-05 15:13:34 +01:00
rose	net/rose: fix races in rose_kill_by_device()	2024-01-05 15:13:29 +01:00
rxrpc	rxrpc_find_service_conn_rcu: fix the usage of read_seqbegin_or_lock()	2024-02-23 08:54:39 +01:00
sched	net/sched: act_ct: fix skb leak and crash on ooo frags	2024-01-25 14:52:40 -08:00
sctp	sctp: update hb timer immediately after users change hb_interval	2023-10-10 21:59:08 +02:00
smc	net/smc: fix illegal rmb_desc access in SMC-D connection dump	2024-02-23 08:54:27 +01:00
strparser
sunrpc	SUNRPC: Fix a suspicious RCU usage warning	2024-02-23 08:54:40 +01:00
switchdev
tipc	tipc: Fix kernel-infoleak due to uninitialized TLV value	2023-11-28 16:56:23 +00:00
tls	net: tls, update curr on splice as well	2024-01-15 18:51:24 +01:00
unix	af_unix: fix use-after-free in unix_stream_read_actor()	2023-11-28 16:56:24 +00:00
vmw_vsock	virtio/vsock: fix logic which reduces credit update messages	2024-01-25 14:52:38 -08:00
wireless	wifi: cfg80211: lock wiphy mutex for rfkill poll	2024-01-25 14:52:27 -08:00
x25	net/x25: Fix to not accept on connected socket	2023-02-09 11:26:40 +01:00
xdp	xsk: Fix xsk_diag use-after-free error during socket cleanup	2023-09-19 12:22:58 +02:00
xfrm	xfrm: interface: use DEV_STATS_INC()	2023-10-25 11:58:56 +02:00
compat.c
devres.c
Kconfig	Remove DECnet support from kernel	2023-06-21 15:59:15 +02:00
Makefile	Remove DECnet support from kernel	2023-06-21 15:59:15 +02:00
socket.c	net: Save and restore msg_namelen in sock_sendmsg	2024-01-15 18:51:16 +01:00
sysctl_net.c