mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-04 09:59:32 +00:00
![Peilin Ye](/assets/img/avatar_default.png)
syzbot has reported an issue in the framebuffer layer, where a malicious user may overflow our built-in font data buffers. In order to perform a reliable range check, subsystems need to know `FONTDATAMAX` for each built-in font. Unfortunately, our font descriptor, `struct console_font` does not contain `FONTDATAMAX`, and is part of the UAPI, making it infeasible to modify it. For user-provided fonts, the framebuffer layer resolves this issue by reserving four extra words at the beginning of data buffers. Later, whenever a function needs to access them, it simply uses the following macros: Recently we have gathered all the above macros to <linux/font.h>. Let us do the same thing for built-in fonts, prepend four extra words (including `FONTDATAMAX`) to their data buffers, so that subsystems can use these macros for all fonts, no matter built-in or user-provided. This patch depends on patch "fbdev, newport_con: Move FONT_EXTRA_WORDS macros into linux/font.h". Cc: stable@vger.kernel.org Link: https://syzkaller.appspot.com/bug?id=08b8be45afea11888776f897895aef9ad1c3ecfd Signed-off-by: Peilin Ye <yepeilin.cs@gmail.com> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> Link: https://patchwork.freedesktop.org/patch/msgid/ef18af00c35fb3cc826048a5f70924ed6ddce95b.1600953813.git.yepeilin.cs@gmail.com
75 lines
1.6 KiB
C
75 lines
1.6 KiB
C
/*
|
|
* font.h -- `Soft' font definitions
|
|
*
|
|
* Created 1995 by Geert Uytterhoeven
|
|
*
|
|
* This file is subject to the terms and conditions of the GNU General Public
|
|
* License. See the file COPYING in the main directory of this archive
|
|
* for more details.
|
|
*/
|
|
|
|
#ifndef _VIDEO_FONT_H
|
|
#define _VIDEO_FONT_H
|
|
|
|
#include <linux/types.h>
|
|
|
|
struct font_desc {
|
|
int idx;
|
|
const char *name;
|
|
int width, height;
|
|
const void *data;
|
|
int pref;
|
|
};
|
|
|
|
#define VGA8x8_IDX 0
|
|
#define VGA8x16_IDX 1
|
|
#define PEARL8x8_IDX 2
|
|
#define VGA6x11_IDX 3
|
|
#define FONT7x14_IDX 4
|
|
#define FONT10x18_IDX 5
|
|
#define SUN8x16_IDX 6
|
|
#define SUN12x22_IDX 7
|
|
#define ACORN8x8_IDX 8
|
|
#define MINI4x6_IDX 9
|
|
#define FONT6x10_IDX 10
|
|
#define TER16x32_IDX 11
|
|
|
|
extern const struct font_desc font_vga_8x8,
|
|
font_vga_8x16,
|
|
font_pearl_8x8,
|
|
font_vga_6x11,
|
|
font_7x14,
|
|
font_10x18,
|
|
font_sun_8x16,
|
|
font_sun_12x22,
|
|
font_acorn_8x8,
|
|
font_mini_4x6,
|
|
font_6x10,
|
|
font_ter_16x32;
|
|
|
|
/* Find a font with a specific name */
|
|
|
|
extern const struct font_desc *find_font(const char *name);
|
|
|
|
/* Get the default font for a specific screen size */
|
|
|
|
extern const struct font_desc *get_default_font(int xres, int yres,
|
|
u32 font_w, u32 font_h);
|
|
|
|
/* Max. length for the name of a predefined font */
|
|
#define MAX_FONT_NAME 32
|
|
|
|
/* Extra word getters */
|
|
#define REFCOUNT(fd) (((int *)(fd))[-1])
|
|
#define FNTSIZE(fd) (((int *)(fd))[-2])
|
|
#define FNTCHARCNT(fd) (((int *)(fd))[-3])
|
|
#define FNTSUM(fd) (((int *)(fd))[-4])
|
|
|
|
#define FONT_EXTRA_WORDS 4
|
|
|
|
struct font_data {
|
|
unsigned int extra[FONT_EXTRA_WORDS];
|
|
const unsigned char data[];
|
|
} __packed;
|
|
|
|
#endif /* _VIDEO_FONT_H */
|