mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 01:10:04 +00:00
8b105ef6ff
Sending the switch state change twice within the same frame is invalid
evdev protocol and only works if the client handles keys immediately as
well. Processing events immediately is incorrect, it forces a fake
order of events that does not exist on the device.
Recent versions of libinput changed to only process the device state and
SYN_REPORT time, so now the key event is lost.
Same fix as 'commit <bff5bf9db1c94> ("platform/x86: asus-wireless: send
an EV_SYN/SYN_REPORT between state changes")'
Signed-off-by: Daniel Drake <drake@endlessos.org>
Signed-off-by: Chris Chiu <chiu@endlessos.org>
Link: https://lore.kernel.org/r/20201207064322.13992-1-chiu@endlessos.org
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
69 lines
1.7 KiB
C
69 lines
1.7 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Acer Wireless Radio Control Driver
|
|
*
|
|
* Copyright (C) 2017 Endless Mobile, Inc.
|
|
*/
|
|
|
|
#include <linux/acpi.h>
|
|
#include <linux/input.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/pci_ids.h>
|
|
#include <linux/types.h>
|
|
|
|
static const struct acpi_device_id acer_wireless_acpi_ids[] = {
|
|
{"10251229", 0},
|
|
{"", 0},
|
|
};
|
|
MODULE_DEVICE_TABLE(acpi, acer_wireless_acpi_ids);
|
|
|
|
static void acer_wireless_notify(struct acpi_device *adev, u32 event)
|
|
{
|
|
struct input_dev *idev = acpi_driver_data(adev);
|
|
|
|
dev_dbg(&adev->dev, "event=%#x\n", event);
|
|
if (event != 0x80) {
|
|
dev_notice(&adev->dev, "Unknown SMKB event: %#x\n", event);
|
|
return;
|
|
}
|
|
input_report_key(idev, KEY_RFKILL, 1);
|
|
input_sync(idev);
|
|
input_report_key(idev, KEY_RFKILL, 0);
|
|
input_sync(idev);
|
|
}
|
|
|
|
static int acer_wireless_add(struct acpi_device *adev)
|
|
{
|
|
struct input_dev *idev;
|
|
|
|
idev = devm_input_allocate_device(&adev->dev);
|
|
if (!idev)
|
|
return -ENOMEM;
|
|
|
|
adev->driver_data = idev;
|
|
idev->name = "Acer Wireless Radio Control";
|
|
idev->phys = "acer-wireless/input0";
|
|
idev->id.bustype = BUS_HOST;
|
|
idev->id.vendor = PCI_VENDOR_ID_AI;
|
|
idev->id.product = 0x1229;
|
|
set_bit(EV_KEY, idev->evbit);
|
|
set_bit(KEY_RFKILL, idev->keybit);
|
|
|
|
return input_register_device(idev);
|
|
}
|
|
|
|
static struct acpi_driver acer_wireless_driver = {
|
|
.name = "Acer Wireless Radio Control Driver",
|
|
.class = "hotkey",
|
|
.ids = acer_wireless_acpi_ids,
|
|
.ops = {
|
|
.add = acer_wireless_add,
|
|
.notify = acer_wireless_notify,
|
|
},
|
|
};
|
|
module_acpi_driver(acer_wireless_driver);
|
|
|
|
MODULE_DESCRIPTION("Acer Wireless Radio Control Driver");
|
|
MODULE_AUTHOR("Chris Chiu <chiu@gmail.com>");
|
|
MODULE_LICENSE("GPL v2");
|