mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-12 13:55:32 +00:00
6c0eb5ba35
For bus-based driver, device removal is implemented as:
1 device_remove()->
2 bus->remove()->
3 driver->remove()
Driver core needs no inform from callee(bus driver) about the
result of remove callback. In that case, commit fc7a6209d5
("bus: Make remove callback return void") forces bus_type::remove
be void-returned.
Now we have the situation that both 1 & 2 of calling chain are
void-returned, so it does not make much sense for 3(driver->remove)
to return non-void to its caller.
So the basic idea behind this change is making remove() callback of
any bus-based driver to be void-returned.
This change, for itself, is for device drivers based on acpi-bus.
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Lee Jones <lee@kernel.org>
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Dawei Li <set_pte_at@outlook.com>
Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com> # for drivers/platform/surface/*
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
140 lines
3 KiB
C
140 lines
3 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* Copyright 2013 Matthew Garrett <mjg59@srcf.ucam.org>
|
|
*/
|
|
|
|
#include <linux/acpi.h>
|
|
#include <linux/module.h>
|
|
#include <linux/slab.h>
|
|
|
|
MODULE_LICENSE("GPL");
|
|
|
|
static ssize_t irst_show_wakeup_events(struct device *dev,
|
|
struct device_attribute *attr,
|
|
char *buf)
|
|
{
|
|
struct acpi_device *acpi;
|
|
unsigned long long value;
|
|
acpi_status status;
|
|
|
|
acpi = to_acpi_device(dev);
|
|
|
|
status = acpi_evaluate_integer(acpi->handle, "GFFS", NULL, &value);
|
|
if (ACPI_FAILURE(status))
|
|
return -EINVAL;
|
|
|
|
return sprintf(buf, "%lld\n", value);
|
|
}
|
|
|
|
static ssize_t irst_store_wakeup_events(struct device *dev,
|
|
struct device_attribute *attr,
|
|
const char *buf, size_t count)
|
|
{
|
|
struct acpi_device *acpi;
|
|
acpi_status status;
|
|
unsigned long value;
|
|
int error;
|
|
|
|
acpi = to_acpi_device(dev);
|
|
|
|
error = kstrtoul(buf, 0, &value);
|
|
if (error)
|
|
return error;
|
|
|
|
status = acpi_execute_simple_method(acpi->handle, "SFFS", value);
|
|
if (ACPI_FAILURE(status))
|
|
return -EINVAL;
|
|
|
|
return count;
|
|
}
|
|
|
|
static struct device_attribute irst_wakeup_attr = {
|
|
.attr = { .name = "wakeup_events", .mode = 0600 },
|
|
.show = irst_show_wakeup_events,
|
|
.store = irst_store_wakeup_events
|
|
};
|
|
|
|
static ssize_t irst_show_wakeup_time(struct device *dev,
|
|
struct device_attribute *attr, char *buf)
|
|
{
|
|
struct acpi_device *acpi;
|
|
unsigned long long value;
|
|
acpi_status status;
|
|
|
|
acpi = to_acpi_device(dev);
|
|
|
|
status = acpi_evaluate_integer(acpi->handle, "GFTV", NULL, &value);
|
|
if (ACPI_FAILURE(status))
|
|
return -EINVAL;
|
|
|
|
return sprintf(buf, "%lld\n", value);
|
|
}
|
|
|
|
static ssize_t irst_store_wakeup_time(struct device *dev,
|
|
struct device_attribute *attr,
|
|
const char *buf, size_t count)
|
|
{
|
|
struct acpi_device *acpi;
|
|
acpi_status status;
|
|
unsigned long value;
|
|
int error;
|
|
|
|
acpi = to_acpi_device(dev);
|
|
|
|
error = kstrtoul(buf, 0, &value);
|
|
if (error)
|
|
return error;
|
|
|
|
status = acpi_execute_simple_method(acpi->handle, "SFTV", value);
|
|
if (ACPI_FAILURE(status))
|
|
return -EINVAL;
|
|
|
|
return count;
|
|
}
|
|
|
|
static struct device_attribute irst_timeout_attr = {
|
|
.attr = { .name = "wakeup_time", .mode = 0600 },
|
|
.show = irst_show_wakeup_time,
|
|
.store = irst_store_wakeup_time
|
|
};
|
|
|
|
static int irst_add(struct acpi_device *acpi)
|
|
{
|
|
int error;
|
|
|
|
error = device_create_file(&acpi->dev, &irst_timeout_attr);
|
|
if (unlikely(error))
|
|
return error;
|
|
|
|
error = device_create_file(&acpi->dev, &irst_wakeup_attr);
|
|
if (unlikely(error))
|
|
device_remove_file(&acpi->dev, &irst_timeout_attr);
|
|
|
|
return error;
|
|
}
|
|
|
|
static void irst_remove(struct acpi_device *acpi)
|
|
{
|
|
device_remove_file(&acpi->dev, &irst_wakeup_attr);
|
|
device_remove_file(&acpi->dev, &irst_timeout_attr);
|
|
}
|
|
|
|
static const struct acpi_device_id irst_ids[] = {
|
|
{"INT3392", 0},
|
|
{"", 0}
|
|
};
|
|
|
|
static struct acpi_driver irst_driver = {
|
|
.owner = THIS_MODULE,
|
|
.name = "intel_rapid_start",
|
|
.class = "intel_rapid_start",
|
|
.ids = irst_ids,
|
|
.ops = {
|
|
.add = irst_add,
|
|
.remove = irst_remove,
|
|
},
|
|
};
|
|
|
|
module_acpi_driver(irst_driver);
|
|
|
|
MODULE_DEVICE_TABLE(acpi, irst_ids);
|