Stefan Berger 48cff270b0 tpm: efi: Use local variable for calculating final log size ... When tpm_read_log_efi is called multiple times, which happens when one loads and unloads a TPM2 driver multiple times, then the global variable efi_tpm_final_log_size will at some point become a negative number due to the subtraction of final_events_preboot_size occurring each time. Use a local variable to avoid this integer underflow. The following issue is now resolved: Mar 8 15:35:12 hibinst kernel: Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 0.0.0 02/06/2015 Mar 8 15:35:12 hibinst kernel: Workqueue: tpm-vtpm vtpm_proxy_work [tpm_vtpm_proxy] Mar 8 15:35:12 hibinst kernel: RIP: 0010:__memcpy+0x12/0x20 Mar 8 15:35:12 hibinst kernel: Code: 00 b8 01 00 00 00 85 d2 74 0a c7 05 44 7b ef 00 0f 00 00 00 c3 cc cc cc 66 66 90 66 90 48 89 f8 48 89 d1 48 c1 e9 03 83 e2 07 <f3> 48 a5 89 d1 f3 a4 c3 66 0f 1f 44 00 00 48 89 f8 48 89 d1 f3 a4 Mar 8 15:35:12 hibinst kernel: RSP: 0018:ffff9ac4c0fcfde0 EFLAGS: 00010206 Mar 8 15:35:12 hibinst kernel: RAX: ffff88f878cefed5 RBX: ffff88f878ce9000 RCX: 1ffffffffffffe0f Mar 8 15:35:12 hibinst kernel: RDX: 0000000000000003 RSI: ffff9ac4c003bff9 RDI: ffff88f878cf0e4d Mar 8 15:35:12 hibinst kernel: RBP: ffff9ac4c003b000 R08: 0000000000001000 R09: 000000007e9d6073 Mar 8 15:35:12 hibinst kernel: R10: ffff9ac4c003b000 R11: ffff88f879ad3500 R12: 0000000000000ed5 Mar 8 15:35:12 hibinst kernel: R13: ffff88f878ce9760 R14: 0000000000000002 R15: ffff88f77de7f018 Mar 8 15:35:12 hibinst kernel: FS: 0000000000000000(0000) GS:ffff88f87bd00000(0000) knlGS:0000000000000000 Mar 8 15:35:12 hibinst kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 Mar 8 15:35:12 hibinst kernel: CR2: ffff9ac4c003c000 CR3: 00000001785a6004 CR4: 0000000000060ee0 Mar 8 15:35:12 hibinst kernel: Call Trace: Mar 8 15:35:12 hibinst kernel: tpm_read_log_efi+0x152/0x1a7 Mar 8 15:35:12 hibinst kernel: tpm_bios_log_setup+0xc8/0x1c0 Mar 8 15:35:12 hibinst kernel: tpm_chip_register+0x8f/0x260 Mar 8 15:35:12 hibinst kernel: vtpm_proxy_work+0x16/0x60 [tpm_vtpm_proxy] Mar 8 15:35:12 hibinst kernel: process_one_work+0x1b4/0x370 Mar 8 15:35:12 hibinst kernel: worker_thread+0x53/0x3e0 Mar 8 15:35:12 hibinst kernel: ? process_one_work+0x370/0x370 Cc: stable@vger.kernel.org Fixes: 166a2809d6 ("tpm: Don't duplicate events from the final event log in the TCG2 log") Signed-off-by: Stefan Berger <stefanb@linux.ibm.com> Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org> Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>		2021-04-14 16:30:29 +03:00
..
eventlog	tpm: efi: Use local variable for calculating final log size	2021-04-14 16:30:29 +03:00
st33zp24	tpm/st33zp24: fix spelling mistake "drescription" -> "description"	2020-07-02 17:49:00 +03:00
Kconfig	char: tpm: add i2c driver for cr50	2021-02-16 10:40:27 +02:00
Makefile	char: tpm: add i2c driver for cr50	2021-02-16 10:40:27 +02:00
tpm-chip.c	tpm: Remove unintentional dump_stack() call	2021-03-03 17:43:52 +02:00
tpm-dev-common.c	tpm: Remove tpm_dev_wq_lock	2021-02-16 10:40:27 +02:00
tpm-dev.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441	2019-06-05 17:37:17 +02:00
tpm-dev.h	tpm: Handle negative priv->response_len in tpm_common_read()	2020-01-08 18:11:09 +02:00
tpm-interface.c	tpm: fix wrong return value in tpm_pcr_extend	2020-04-21 00:06:13 +03:00
tpm-sysfs.c	tpm: add sysfs exports for all banks of PCR registers	2021-02-16 10:40:27 +02:00
tpm.h	KEYS: trusted: Reserve TPM for seal and unseal operations	2021-02-16 10:40:28 +02:00
tpm1-cmd.c	tpm: provide a way to override the chip returned durations	2019-11-12 21:45:36 +02:00
tpm2-cmd.c	tpm: Export tpm2_get_cc_attrs_tbl for ibmvtpm driver as module	2020-04-21 00:06:13 +03:00
tpm2-space.c	tpm: Unify the mismatching TPM space buffer sizes	2020-07-24 09:26:23 +03:00
tpm_atmel.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441	2019-06-05 17:37:17 +02:00
tpm_atmel.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441	2019-06-05 17:37:17 +02:00
tpm_crb.c	tpm_crb: fix fTPM on AMD Zen+ CPUs	2019-11-12 21:45:37 +02:00
tpm_ftpm_tee.c	Enable multi-stage OP-TEE bus enumeration	2020-07-13 15:11:44 +02:00
tpm_ftpm_tee.h	tpm/tpm_ftpm_tee: A driver for firmware TPM running inside TEE	2019-09-02 17:08:35 +03:00
tpm_i2c_atmel.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 13	2019-05-21 11:28:45 +02:00
tpm_i2c_infineon.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441	2019-06-05 17:37:17 +02:00
tpm_i2c_nuvoton.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 13	2019-05-21 11:28:45 +02:00
tpm_ibmvtpm.c	vio: make remove callback return void	2021-03-02 22:41:23 +11:00
tpm_ibmvtpm.h	tpm: ibmvtpm: Wait for buffer to be set before proceeding	2020-03-15 20:12:52 +02:00
tpm_infineon.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441	2019-06-05 17:37:17 +02:00
tpm_nsc.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441	2019-06-05 17:37:17 +02:00
tpm_ppi.c	tpm/ppi: Constify static struct attribute_group	2021-02-16 10:40:27 +02:00
tpm_tis.c	tpm_tis: Disable interrupts on ThinkPad T490s	2020-11-06 18:21:00 +02:00
tpm_tis_core.c	tpm, tpm_tis: Decorate tpm_tis_gen_interrupt() with request_locality()	2021-02-24 18:53:22 +02:00
tpm_tis_core.h	tpm_tis: Add a check for invalid status	2020-10-02 00:21:03 +03:00
tpm_tis_i2c_cr50.c	char: tpm: add i2c driver for cr50	2021-02-16 10:40:27 +02:00
tpm_tis_spi.h	tpm: tpm_tis_spi: Support cr50 devices	2019-11-12 21:45:37 +02:00
tpm_tis_spi_cr50.c	tpm: tpm_tis_spi_cr50: use new structure for SPI transfer delays	2020-03-13 03:53:16 +02:00
tpm_tis_spi_main.c	tpm_tis_spi: Prefer async probe	2020-07-02 17:49:00 +03:00
tpm_tis_synquacer.c	tpm: tis: add support for MMIO TPM on SynQuacer	2020-10-02 00:21:02 +03:00
tpm_vtpm_proxy.c	compat_ioctl: move drivers to compat_ptr_ioctl	2019-10-23 17:23:43 +02:00
tpmrm-dev.c	tpm: Unify the mismatching TPM space buffer sizes	2020-07-24 09:26:23 +03:00
xen-tpmfront.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00