mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-11-01 17:08:10 +00:00
723fe298ad
Since commit 7723f4c5ec ("driver core: platform: Add an error
message to platform_get_irq*()"), platform_get_irq() calls dev_err()
on an error. As we enumerate all interrupts until platform_get_irq()
fails, we now systematically get a message such as:
"vfio-platform fff51000.ethernet: IRQ index 3 not found" which is
a false positive.
Let's use platform_get_irq_optional() instead.
Signed-off-by: Eric Auger <eric.auger@redhat.com>
Cc: stable@vger.kernel.org # v5.3+
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Tested-by: Andre Przywara <andre.przywara@arm.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
100 lines
2.3 KiB
C
100 lines
2.3 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright (C) 2013 - Virtual Open Systems
|
|
* Author: Antonios Motakis <a.motakis@virtualopensystems.com>
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/vfio.h>
|
|
#include <linux/platform_device.h>
|
|
|
|
#include "vfio_platform_private.h"
|
|
|
|
#define DRIVER_VERSION "0.10"
|
|
#define DRIVER_AUTHOR "Antonios Motakis <a.motakis@virtualopensystems.com>"
|
|
#define DRIVER_DESC "VFIO for platform devices - User Level meta-driver"
|
|
|
|
static bool reset_required = true;
|
|
module_param(reset_required, bool, 0444);
|
|
MODULE_PARM_DESC(reset_required, "override reset requirement (default: 1)");
|
|
|
|
/* probing devices from the linux platform bus */
|
|
|
|
static struct resource *get_platform_resource(struct vfio_platform_device *vdev,
|
|
int num)
|
|
{
|
|
struct platform_device *dev = (struct platform_device *) vdev->opaque;
|
|
int i;
|
|
|
|
for (i = 0; i < dev->num_resources; i++) {
|
|
struct resource *r = &dev->resource[i];
|
|
|
|
if (resource_type(r) & (IORESOURCE_MEM|IORESOURCE_IO)) {
|
|
if (!num)
|
|
return r;
|
|
|
|
num--;
|
|
}
|
|
}
|
|
return NULL;
|
|
}
|
|
|
|
static int get_platform_irq(struct vfio_platform_device *vdev, int i)
|
|
{
|
|
struct platform_device *pdev = (struct platform_device *) vdev->opaque;
|
|
|
|
return platform_get_irq_optional(pdev, i);
|
|
}
|
|
|
|
static int vfio_platform_probe(struct platform_device *pdev)
|
|
{
|
|
struct vfio_platform_device *vdev;
|
|
int ret;
|
|
|
|
vdev = kzalloc(sizeof(*vdev), GFP_KERNEL);
|
|
if (!vdev)
|
|
return -ENOMEM;
|
|
|
|
vdev->opaque = (void *) pdev;
|
|
vdev->name = pdev->name;
|
|
vdev->flags = VFIO_DEVICE_FLAGS_PLATFORM;
|
|
vdev->get_resource = get_platform_resource;
|
|
vdev->get_irq = get_platform_irq;
|
|
vdev->parent_module = THIS_MODULE;
|
|
vdev->reset_required = reset_required;
|
|
|
|
ret = vfio_platform_probe_common(vdev, &pdev->dev);
|
|
if (ret)
|
|
kfree(vdev);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int vfio_platform_remove(struct platform_device *pdev)
|
|
{
|
|
struct vfio_platform_device *vdev;
|
|
|
|
vdev = vfio_platform_remove_common(&pdev->dev);
|
|
if (vdev) {
|
|
kfree(vdev);
|
|
return 0;
|
|
}
|
|
|
|
return -EINVAL;
|
|
}
|
|
|
|
static struct platform_driver vfio_platform_driver = {
|
|
.probe = vfio_platform_probe,
|
|
.remove = vfio_platform_remove,
|
|
.driver = {
|
|
.name = "vfio-platform",
|
|
},
|
|
};
|
|
|
|
module_platform_driver(vfio_platform_driver);
|
|
|
|
MODULE_VERSION(DRIVER_VERSION);
|
|
MODULE_LICENSE("GPL v2");
|
|
MODULE_AUTHOR(DRIVER_AUTHOR);
|
|
MODULE_DESCRIPTION(DRIVER_DESC);
|