mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-11 02:59:12 +00:00
4aae070252
this is the tale of a full day spent debugging an ancient but elusive bug. after booting up thousands of random .config kernels, i finally happened to generate a .config that produced the following rare bootup failure on 32-bit x86: | ..TIMER: vector=0x31 apic1=0 pin1=2 apic2=-1 pin2=-1 | ..MP-BIOS bug: 8254 timer not connected to IO-APIC | ...trying to set up timer (IRQ0) through the 8259A ... failed. | ...trying to set up timer as Virtual Wire IRQ... failed. | ...trying to set up timer as ExtINT IRQ... failed :(. | Kernel panic - not syncing: IO-APIC + timer doesn't work! Boot with apic=debug | and send a report. Then try booting with the 'noapic' option this bug has been reported many times during the years, but it was never reproduced nor fixed. the bug that i hit was extremely sensitive to .config details. First i did a .config-bisection - suspecting some .config detail. That led to CONFIG_X86_MCE: enabling X86_MCE magically made the bug disappear and the system would boot up just fine. Debugging my way through the MCE code ended up identifying two unlikely candidates: the thing that made a real difference to the hang was that X86_MCE did two printks: Intel machine check architecture supported. Intel machine check reporting enabled on CPU#1. Adding the same printks to a !CONFIG_X86_MCE kernel made the bug go away! this left timing as the main suspect: i experimented with adding various udelay()s to the arch/x86/kernel/io_apic_32.c:check_timer() function, and the race window turned out to be narrower than 30 microseconds (!). That made debugging especially funny, debugging without having printk ability before the bug hits is ... interesting ;-) eventually i started suspecting IRQ activities - those are pretty much the only thing that happen this early during bootup and have the timescale of a few dozen microseconds. Also, check_timer() changes the IRQ hardware in various creative ways, so the main candidate became IRQ0 interaction. i've added a counter to track timer irqs (on which core they arrived, at what exact time, etc.) and found that no timer IRQ would arrive after the bug condition hits - even if we re-enable IRQ0 and re-initialize the i8259A, but that we'd get a small number of timer irqs right around the time when we call the check_timer() function. Eventually i got the following backtrace triggered from debug code in the timer interrupt: ...trying to set up timer as Virtual Wire IRQ... failed. ...trying to set up timer as ExtINT IRQ... Pid: 1, comm: swapper Not tainted (2.6.24-rc5 #57) EIP: 0060:[<c044d57e>] EFLAGS: 00000246 CPU: 0 EIP is at _spin_unlock_irqrestore+0x5/0x1c EAX: c0634178 EBX: 00000000 ECX: c4947d63 EDX: 00000246 ESI: 00000002 EDI: 00010031 EBP: c04e0f2e ESP: f7c41df4 DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068 CR0: 8005003b CR2: ffe04000 CR3: 00630000 CR4: 000006d0 DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000 DR6: ffff0ff0 DR7: 00000400 [<c05f5784>] setup_IO_APIC+0x9c3/0xc5c the spin_unlock() was called from init_8259A(). Wait ... we have an IRQ0 entry while we are in the middle of setting up the local APIC, the i8259A and the PIT?? That is certainly not how it's supposed to work! check_timer() was supposed to be called with irqs turned off - but this eroded away sometime in the past. This code would still work most of the time because this code runs very quickly, but just the right timing conditions are present and IRQ0 hits in this small, ~30 usecs window, timer irqs stop and the system does not boot up. Also, given how early this is during bootup, the hang is very deterministic - but it would only occur on certain machines (and certain configs). The fix was quite simple: disable/restore interrupts properly in this function. With that in place the test-system now boots up just fine. (64-bit x86 io_apic_64.c had the same bug.) Phew! One down, only 1500 other kernel bugs are left ;-) Signed-off-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> |
||
|---|---|---|
| .. | ||
| acpi | ||
| cpu | ||
| .gitignore | ||
| alternative.c | ||
| aperture_64.c | ||
| apic_32.c | ||
| apic_64.c | ||
| apm_32.c | ||
| asm-offsets.c | ||
| asm-offsets_32.c | ||
| asm-offsets_64.c | ||
| audit_64.c | ||
| bootflag.c | ||
| bugs_64.c | ||
| cpuid.c | ||
| crash.c | ||
| crash_dump_32.c | ||
| crash_dump_64.c | ||
| doublefault_32.c | ||
| e820_32.c | ||
| e820_64.c | ||
| early-quirks.c | ||
| early_printk.c | ||
| efi_32.c | ||
| efi_stub_32.S | ||
| entry_32.S | ||
| entry_64.S | ||
| genapic_64.c | ||
| genapic_flat_64.c | ||
| geode_32.c | ||
| head64.c | ||
| head_32.S | ||
| head_64.S | ||
| hpet.c | ||
| i386_ksyms_32.c | ||
| i387_32.c | ||
| i387_64.c | ||
| i8237.c | ||
| i8253.c | ||
| i8259_32.c | ||
| i8259_64.c | ||
| init_task.c | ||
| io_apic_32.c | ||
| io_apic_64.c | ||
| ioport_32.c | ||
| ioport_64.c | ||
| irq_32.c | ||
| irq_64.c | ||
| k8.c | ||
| kprobes_32.c | ||
| kprobes_64.c | ||
| ldt_32.c | ||
| ldt_64.c | ||
| machine_kexec_32.c | ||
| machine_kexec_64.c | ||
| Makefile | ||
| Makefile_32 | ||
| Makefile_64 | ||
| mca_32.c | ||
| mfgpt_32.c | ||
| microcode.c | ||
| module_32.c | ||
| module_64.c | ||
| mpparse_32.c | ||
| mpparse_64.c | ||
| msr.c | ||
| nmi_32.c | ||
| nmi_64.c | ||
| numaq_32.c | ||
| paravirt_32.c | ||
| pci-calgary_64.c | ||
| pci-dma_32.c | ||
| pci-dma_64.c | ||
| pci-gart_64.c | ||
| pci-nommu_64.c | ||
| pci-swiotlb_64.c | ||
| pcspeaker.c | ||
| pmtimer_64.c | ||
| process_32.c | ||
| process_64.c | ||
| ptrace_32.c | ||
| ptrace_64.c | ||
| quirks.c | ||
| reboot_32.c | ||
| reboot_64.c | ||
| reboot_fixups_32.c | ||
| relocate_kernel_32.S | ||
| relocate_kernel_64.S | ||
| scx200_32.c | ||
| setup64.c | ||
| setup_32.c | ||
| setup_64.c | ||
| sigframe_32.h | ||
| signal_32.c | ||
| signal_64.c | ||
| smp_32.c | ||
| smp_64.c | ||
| smpboot_32.c | ||
| smpboot_64.c | ||
| smpcommon_32.c | ||
| srat_32.c | ||
| stacktrace.c | ||
| summit_32.c | ||
| suspend_64.c | ||
| suspend_asm_64.S | ||
| sys_i386_32.c | ||
| sys_x86_64.c | ||
| syscall_64.c | ||
| syscall_table_32.S | ||
| sysenter_32.c | ||
| tce_64.c | ||
| time_32.c | ||
| time_64.c | ||
| topology.c | ||
| trampoline_32.S | ||
| trampoline_64.S | ||
| traps_32.c | ||
| traps_64.c | ||
| tsc_32.c | ||
| tsc_64.c | ||
| tsc_sync.c | ||
| verify_cpu_64.S | ||
| vm86_32.c | ||
| vmi_32.c | ||
| vmiclock_32.c | ||
| vmlinux.lds.S | ||
| vmlinux_32.lds.S | ||
| vmlinux_64.lds.S | ||
| vsmp_64.c | ||
| vsyscall-int80_32.S | ||
| vsyscall-note_32.S | ||
| vsyscall-sigreturn_32.S | ||
| vsyscall-sysenter_32.S | ||
| vsyscall_32.lds.S | ||
| vsyscall_32.S | ||
| vsyscall_64.c | ||
| x8664_ksyms_64.c | ||