Mika Westerberg c801b7e678 bdi: Do not use freezable workqueue ... commit a2b90f1121 upstream. A removable block device, such as NVMe or SSD connected over Thunderbolt can be hot-removed any time including when the system is suspended. When device is hot-removed during suspend and the system gets resumed, kernel first resumes devices and then thaws the userspace including freezable workqueues. What happens in that case is that the NVMe driver notices that the device is unplugged and removes it from the system. This ends up calling bdi_unregister() for the gendisk which then schedules wb_workfn() to be run one more time. However, since the bdi_wq is still frozen flush_delayed_work() call in wb_shutdown() blocks forever halting system resume process. User sees this as hang as nothing is happening anymore. Triggering sysrq-w reveals this: Workqueue: nvme-wq nvme_remove_dead_ctrl_work [nvme] Call Trace: ? __schedule+0x2c5/0x630 ? wait_for_completion+0xa4/0x120 schedule+0x3e/0xc0 schedule_timeout+0x1c9/0x320 ? resched_curr+0x1f/0xd0 ? wait_for_completion+0xa4/0x120 wait_for_completion+0xc3/0x120 ? wake_up_q+0x60/0x60 __flush_work+0x131/0x1e0 ? flush_workqueue_prep_pwqs+0x130/0x130 bdi_unregister+0xb9/0x130 del_gendisk+0x2d2/0x2e0 nvme_ns_remove+0xed/0x110 [nvme_core] nvme_remove_namespaces+0x96/0xd0 [nvme_core] nvme_remove+0x5b/0x160 [nvme] pci_device_remove+0x36/0x90 device_release_driver_internal+0xdf/0x1c0 nvme_remove_dead_ctrl_work+0x14/0x30 [nvme] process_one_work+0x1c2/0x3f0 worker_thread+0x48/0x3e0 kthread+0x100/0x140 ? current_work+0x30/0x30 ? kthread_park+0x80/0x80 ret_from_fork+0x35/0x40 This is not limited to NVMes so exactly same issue can be reproduced by hot-removing SSD (over Thunderbolt) while the system is suspended. Prevent this from happening by removing WQ_FREEZABLE from bdi_wq. Reported-by: AceLan Kao <acelan.kao@canonical.com> Link: https://marc.info/?l=linux-kernel&m=138695698516487 Link: https://bugzilla.kernel.org/show_bug.cgi?id=204385 Link: https://lore.kernel.org/lkml/20191002122136.GD2819@lahna.fi.intel.com/#t Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> Signed-off-by: Jens Axboe <axboe@kernel.dk> Cc: Macpaul Lin <macpaul.lin@mediatek.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2021-07-20 16:17:45 +02:00
..
kasan	kasan: fix shadow_size calculation error in kasan_module_alloc	2018-08-24 13:09:12 +02:00
backing-dev.c	bdi: Do not use freezable workqueue	2021-07-20 16:17:45 +02:00
balloon_compaction.c	virtio_balloon: fix deadlock on OOM	2018-10-13 09:27:30 +02:00
bootmem.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
cleancache.c	fs: switch ->s_uuid to uuid_t	2017-06-05 16:59:12 +02:00
cma.c	mm/cma.c: fail if fixed declaration can't be honored	2019-08-06 19:05:23 +02:00
cma.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
cma_debug.c	mm/cma_debug.c: fix the break condition in cma_maxchunk_get()	2019-06-15 11:54:51 +02:00
compaction.c	mm/compaction.c: clear total_{migrate,free}_scanned before scanning a new zone	2019-10-05 12:48:13 +02:00
debug.c	mm: get rid of vmacache_flush_all() entirely	2018-09-19 22:43:48 +02:00
debug_page_ref.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
dmapool.c
early_ioremap.c	mm/early_ioremap: Fix boot hang with earlyprintk=efi,keep	2018-02-25 11:08:03 +01:00
fadvise.c	mm/fadvise.c: fix signed overflow UBSAN complaint	2018-09-15 09:45:28 +02:00
failslab.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
filemap.c	mm/filemap.c: clear page error before actual read	2020-10-01 13:12:40 +02:00
frame_vector.c	mm/frame_vector.c: release a semaphore in 'get_vaddr_frames()'	2018-03-03 10:24:21 +01:00
frontswap.c
gup.c	gup: document and work around "COW can break either way" issue	2021-04-28 12:08:42 +02:00
highmem.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
hmm.c	mm, hmm: mark hmm_devmem_{add, add_resource} EXPORT_SYMBOL_GPL	2019-01-13 10:01:02 +01:00
huge_memory.c	mm/huge_memory.c: don't discard hugepage if other processes are mapping it	2021-07-20 16:17:41 +02:00
hugetlb.c	mm, futex: fix shared futex pgoff on shmem huge page	2021-07-11 12:48:12 +02:00
hugetlb_cgroup.c	mm: hugetlb: switch to css_tryget() in hugetlb_cgroup_charge_cgroup()	2019-11-20 17:59:33 +01:00
hwpoison-inject.c	mm: hwpoison: call shake_page() unconditionally	2017-05-03 15:52:12 -07:00
init-mm.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
internal.h	mm/thp: fix vma_address() if virtual address below file offset	2021-07-11 12:48:10 +02:00
interval_tree.c	lib/interval_tree: fast overlap detection	2017-09-08 18:26:49 -07:00
Kconfig	mm/hmm: select mmu notifier when selecting HMM	2019-06-15 11:54:51 +02:00
Kconfig.debug	kmemcheck: rip it out	2018-02-22 15:42:24 +01:00
khugepaged.c	khugepaged: fix wrong result value for trace_mm_collapse_huge_page_isolate()	2021-05-22 10:57:39 +02:00
kmemleak-test.c
kmemleak.c	mm/kmemleak.c: use address-of operator on section symbols	2020-10-01 13:12:40 +02:00
ksm.c	ksm: fix potential missing rmap_item for stable_node	2021-05-22 10:57:39 +02:00
list_lru.c	mm/list_lru.c: fix memory leak in __memcg_init_list_lru_node	2019-06-19 08:20:54 +02:00
maccess.c	uaccess: Add non-pagefault user-space write function	2020-09-09 19:03:11 +02:00
madvise.c	mm: madvise(MADV_DODUMP): allow hugetlbfs pages	2018-10-10 08:54:22 +02:00
Makefile	kmemcheck: rip it out	2018-02-22 15:42:24 +01:00
memblock.c	memblock: do not start bottom-up allocations with kernel_end	2021-02-23 14:00:32 +01:00
memcontrol.c	mm: writeback: use exact memcg dirty counts	2021-04-07 12:47:03 +02:00
memory-failure.c	mm/memory-failure: make sure wait for page writeback in memory_failure	2021-06-30 08:48:48 -04:00
memory.c	mm: fix race by making init_zero_pfn() early_initcall	2021-04-07 12:47:02 +02:00
memory_hotplug.c	mm/memory_hotplug: don't access uninitialized memmaps in shrink_zone_span()	2019-12-01 09:14:18 +01:00
mempolicy.c	mm: mempolicy: fix potential pte_unmap_unlock pte error	2020-11-18 18:27:52 +01:00
mempool.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
memtest.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
migrate.c	mm/migrate.c: add missing flush_dcache_page for non-mapped page migrate	2019-04-03 06:25:20 +02:00
mincore.c	mm/mincore.c: make mincore() more conservative	2019-05-21 18:50:16 +02:00
mlock.c	mm/mlock.c: change count_mm_mlocked_page_nr return type	2019-07-10 09:54:36 +02:00
mm_init.c
mmap.c	mm/mmap.c: initialize align_offset explicitly for vm_unmapped_area	2020-10-01 13:12:41 +02:00
mmu_context.c
mmu_notifier.c	mm/mmu_notifier: use hlist_add_head_rcu()	2019-07-31 07:28:56 +02:00
mmzone.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
mprotect.c	mm, numa: fix bad pmd by atomically check for pmd_trans_huge when marking page tables prot_numa	2020-03-11 18:03:02 +01:00
mremap.c	mm: Fix mremap not considering huge pmd devmap	2020-06-11 09:22:57 +02:00
msync.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
nobootmem.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
nommu.c	x86/mm: split vmalloc_sync_all()	2020-04-02 16:34:20 +02:00
oom_kill.c	mm: fix oom_kill event handling	2021-04-07 12:47:03 +02:00
page-writeback.c	mm/page-writeback.c: avoid potential division by zero in wb_min_max_ratio()	2020-01-23 08:20:32 +01:00
page_alloc.c	mm: khugepaged: recalculate min_free_kbytes after memory hotplug as expected by khugepaged	2020-10-14 09:51:14 +02:00
page_counter.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
page_ext.c	mm/page_ext.c: fix an imbalance with kmemleak	2019-04-05 22:31:27 +02:00
page_idle.c	mm/page_idle.c: fix oops because end_pfn is larger than max_pfn	2019-07-03 13:15:59 +02:00
page_io.c	swap: fix swapfile read/write offset	2021-03-07 11:27:46 +01:00
page_isolation.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
page_owner.c	mm/page_owner.c: remove drain_all_pages from init_early_allocated_pages	2020-07-31 16:44:45 +02:00
page_poison.c	page_poison: play nicely with KASAN	2019-04-05 22:31:28 +02:00
page_vma_mapped.c	mm/thp: another PVMW_SYNC fix in page_vma_mapped_walk()	2021-07-11 12:48:12 +02:00
pagewalk.c	mm: pagewalk: fix termination condition in walk_pte_range()	2020-10-01 13:12:32 +02:00
percpu-internal.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
percpu-km.c	percpu: convert spin_lock_irq to spin_lock_irqsave.	2019-02-12 19:46:05 +01:00
percpu-stats.c	percpu: fix starting offset for chunk statistics traversal	2017-09-27 14:45:57 -07:00
percpu-vm.c	percpu: add __GFP_NORETRY semantics to the percpu balancing path	2018-04-08 14:26:29 +02:00
percpu.c	percpu: fix first chunk size calculation for populated bitmap	2020-09-23 10:46:36 +02:00
pgtable-generic.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
process_vm_access.c
quicklist.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
readahead.c	readahead: stricter check for bdi io_pages	2018-09-09 19:55:53 +02:00
rmap.c	mm/thp: fix page_address_in_vma() on file THP tails	2021-07-11 12:48:10 +02:00
rodata_test.c	mm: fix RODATA_TEST failure "rodata_test: test data was not read only"	2017-10-03 17:54:24 -07:00
shmem.c	userfaultfd: release page in error path to avoid BUG_ON	2021-05-22 10:57:39 +02:00
slab.c	mm/slab.c: fix an infinite loop in leaks_show()	2019-06-15 11:54:51 +02:00
slab.h	kmemcheck: stop using GFP_NOTRACK and SLAB_NOTRACK	2018-02-22 15:42:23 +01:00
slab_common.c	mm/slab: use memzero_explicit() in kzfree()	2020-06-30 15:38:08 -04:00
slob.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
slub.c	mm/slub.c: include swab.h	2021-06-30 08:48:54 -04:00
sparse-vmemmap.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
sparse.c	mm: sections are not offlined during memory hotremove	2018-05-16 10:10:27 +02:00
swap.c	mm: avoid marking swap cached page as lazyfree	2017-10-03 17:54:24 -07:00
swap_cgroup.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
swap_slots.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
swap_state.c	mm/swap_state: fix a data race in swapin_nr_pages	2020-10-01 13:12:46 +02:00
swapfile.c	swap: fix swapfile read/write offset	2021-03-07 11:27:46 +01:00
truncate.c	mm: cleancache: fix corruption on missed inode invalidation	2018-12-08 13:03:40 +01:00
usercopy.c	usercopy: Avoid HIGHMEM pfn warning	2019-10-11 18:18:34 +02:00
userfaultfd.c	hugetlbfs: hugetlb_fault_mutex_hash() cleanup	2021-06-03 08:36:25 +02:00
util.c	mm: add kvfree_sensitive() for freeing sensitive data objects	2020-06-20 10:24:59 +02:00
vmacache.c	mm: get rid of vmacache_flush_all() entirely	2018-09-19 22:43:48 +02:00
vmalloc.c	mm/vmalloc.c: don't dereference possible NULL pointer in __vunmap()	2020-06-03 08:18:11 +02:00
vmpressure.c	mm, vmpressure: pass-through notification support	2017-07-10 16:32:31 -07:00
vmscan.c	mm: memcg: make sure memory.events is uptodate when waking pollers	2021-04-07 12:47:03 +02:00
vmstat.c	mm, vmstat: drop zone->lock in /proc/pagetypeinfo	2021-06-03 08:36:10 +02:00
workingset.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
z3fold.c	z3fold: fix possible reclaim races	2018-12-01 09:42:54 +01:00
zbud.c
zpool.c
zsmalloc.c	zsmalloc: account the number of compacted pages correctly	2021-03-07 11:27:46 +01:00
zswap.c	zswap: re-check zswap_is_full() after do zswap_shrink()	2018-09-05 09:26:30 +02:00