mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-29 23:53:32 +00:00
5e6a0e0527
There is no mutex protection of these state checking for 'stop' and 'detach' which can't guarantee there is no another instance is trying to do same operation. Consider two instances case: Instance1: echo stop > /sys/class/remoteproc/remoteproc0/state Instance2: echo stop > /sys/class/remoteproc/remoteproc0/state The issue is that the instance2 case may success, Or it may fail with -EINVAL, which is uncertain. So move this state checking in rproc_cdev_write() and state_store() for 'stop', 'detach' operation to 'rproc_shutdown' , 'rproc_detach' function under the mutex protection. Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com> Link: https://lore.kernel.org/r/1648434012-16655-3-git-send-email-shengjiu.wang@nxp.com Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
126 lines
2.9 KiB
C
126 lines
2.9 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Character device interface driver for Remoteproc framework.
|
|
*
|
|
* Copyright (c) 2020, The Linux Foundation. All rights reserved.
|
|
*/
|
|
|
|
#include <linux/cdev.h>
|
|
#include <linux/compat.h>
|
|
#include <linux/fs.h>
|
|
#include <linux/module.h>
|
|
#include <linux/remoteproc.h>
|
|
#include <linux/uaccess.h>
|
|
#include <uapi/linux/remoteproc_cdev.h>
|
|
|
|
#include "remoteproc_internal.h"
|
|
|
|
#define NUM_RPROC_DEVICES 64
|
|
static dev_t rproc_major;
|
|
|
|
static ssize_t rproc_cdev_write(struct file *filp, const char __user *buf, size_t len, loff_t *pos)
|
|
{
|
|
struct rproc *rproc = container_of(filp->f_inode->i_cdev, struct rproc, cdev);
|
|
int ret = 0;
|
|
char cmd[10];
|
|
|
|
if (!len || len > sizeof(cmd))
|
|
return -EINVAL;
|
|
|
|
ret = copy_from_user(cmd, buf, len);
|
|
if (ret)
|
|
return -EFAULT;
|
|
|
|
if (!strncmp(cmd, "start", len)) {
|
|
ret = rproc_boot(rproc);
|
|
} else if (!strncmp(cmd, "stop", len)) {
|
|
ret = rproc_shutdown(rproc);
|
|
} else if (!strncmp(cmd, "detach", len)) {
|
|
ret = rproc_detach(rproc);
|
|
} else {
|
|
dev_err(&rproc->dev, "Unrecognized option\n");
|
|
ret = -EINVAL;
|
|
}
|
|
|
|
return ret ? ret : len;
|
|
}
|
|
|
|
static long rproc_device_ioctl(struct file *filp, unsigned int ioctl, unsigned long arg)
|
|
{
|
|
struct rproc *rproc = container_of(filp->f_inode->i_cdev, struct rproc, cdev);
|
|
void __user *argp = (void __user *)arg;
|
|
s32 param;
|
|
|
|
switch (ioctl) {
|
|
case RPROC_SET_SHUTDOWN_ON_RELEASE:
|
|
if (copy_from_user(¶m, argp, sizeof(s32)))
|
|
return -EFAULT;
|
|
|
|
rproc->cdev_put_on_release = !!param;
|
|
break;
|
|
case RPROC_GET_SHUTDOWN_ON_RELEASE:
|
|
param = (s32)rproc->cdev_put_on_release;
|
|
if (copy_to_user(argp, ¶m, sizeof(s32)))
|
|
return -EFAULT;
|
|
|
|
break;
|
|
default:
|
|
dev_err(&rproc->dev, "Unsupported ioctl\n");
|
|
return -EINVAL;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int rproc_cdev_release(struct inode *inode, struct file *filp)
|
|
{
|
|
struct rproc *rproc = container_of(inode->i_cdev, struct rproc, cdev);
|
|
int ret = 0;
|
|
|
|
if (!rproc->cdev_put_on_release)
|
|
return 0;
|
|
|
|
if (rproc->state == RPROC_RUNNING)
|
|
rproc_shutdown(rproc);
|
|
else if (rproc->state == RPROC_ATTACHED)
|
|
ret = rproc_detach(rproc);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static const struct file_operations rproc_fops = {
|
|
.write = rproc_cdev_write,
|
|
.unlocked_ioctl = rproc_device_ioctl,
|
|
.compat_ioctl = compat_ptr_ioctl,
|
|
.release = rproc_cdev_release,
|
|
};
|
|
|
|
int rproc_char_device_add(struct rproc *rproc)
|
|
{
|
|
int ret;
|
|
|
|
cdev_init(&rproc->cdev, &rproc_fops);
|
|
rproc->cdev.owner = THIS_MODULE;
|
|
|
|
rproc->dev.devt = MKDEV(MAJOR(rproc_major), rproc->index);
|
|
cdev_set_parent(&rproc->cdev, &rproc->dev.kobj);
|
|
ret = cdev_add(&rproc->cdev, rproc->dev.devt, 1);
|
|
if (ret < 0)
|
|
dev_err(&rproc->dev, "Failed to add char dev for %s\n", rproc->name);
|
|
|
|
return ret;
|
|
}
|
|
|
|
void rproc_char_device_remove(struct rproc *rproc)
|
|
{
|
|
cdev_del(&rproc->cdev);
|
|
}
|
|
|
|
void __init rproc_init_cdev(void)
|
|
{
|
|
int ret;
|
|
|
|
ret = alloc_chrdev_region(&rproc_major, 0, NUM_RPROC_DEVICES, "remoteproc");
|
|
if (ret < 0)
|
|
pr_err("Failed to alloc rproc_cdev region, err %d\n", ret);
|
|
}
|