linux-stable/drivers/tty/vt
Igor Matheus Andrade Torrente 883f7897a2 tty: Fix out-of-bound vmalloc access in imageblit
[ Upstream commit 3b0c406124 ]

This issue happens when a userspace program does an ioctl
FBIOPUT_VSCREENINFO passing the fb_var_screeninfo struct
containing only the fields xres, yres, and bits_per_pixel
with values.

If this struct is the same as the previous ioctl, the
vc_resize() detects it and doesn't call the resize_screen(),
leaving the fb_var_screeninfo incomplete. And this leads to
the updatescrollmode() calculates a wrong value to
fbcon_display->vrows, which makes the real_y() return a
wrong value of y, and that value, eventually, causes
the imageblit to access an out-of-bound address value.

To solve this issue I made the resize_screen() be called
even if the screen does not need any resizing, so it will
"fix and fill" the fb_var_screeninfo independently.

Cc: stable <stable@vger.kernel.org> # after 5.15-rc2 is out, give it time to bake
Reported-and-tested-by: syzbot+858dc7a2f7ef07c2c219@syzkaller.appspotmail.com
Signed-off-by: Igor Matheus Andrade Torrente <igormtorrente@gmail.com>
Link: https://lore.kernel.org/r/20210628134509.15895-1-igormtorrente@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2021-10-06 15:42:29 +02:00
..
.gitignore
consolemap.c vt/consolemap: do font sum unsigned 2021-03-07 12:20:44 +01:00
cp437.uni
defkeymap.c_shipped
defkeymap.map
keyboard.c vt: keyboard, extend func_buf_lock to readers 2020-11-05 11:43:29 +01:00
Makefile
selection.c vt: selection, introduce vc_is_sel 2020-04-02 15:11:00 +02:00
vc_screen.c
vt.c tty: Fix out-of-bound vmalloc access in imageblit 2021-10-06 15:42:29 +02:00
vt_ioctl.c vt_kdsetmode: extend console locking 2021-09-03 10:08:15 +02:00