Eric Dumazet e5d28205bf inet_diag: fix kernel-infoleak for UDP sockets ... [ Upstream commit 71ddeac8cd ] KMSAN reported a kernel-infoleak [1], that can exploited by unpriv users. After analysis it turned out UDP was not initializing r->idiag_expires. Other users of inet_sk_diag_fill() might make the same mistake in the future, so fix this in inet_sk_diag_fill(). [1] BUG: KMSAN: kernel-infoleak in instrument_copy_to_user include/linux/instrumented.h:121 [inline] BUG: KMSAN: kernel-infoleak in copyout lib/iov_iter.c:156 [inline] BUG: KMSAN: kernel-infoleak in _copy_to_iter+0x69d/0x25c0 lib/iov_iter.c:670 instrument_copy_to_user include/linux/instrumented.h:121 [inline] copyout lib/iov_iter.c:156 [inline] _copy_to_iter+0x69d/0x25c0 lib/iov_iter.c:670 copy_to_iter include/linux/uio.h:155 [inline] simple_copy_to_iter+0xf3/0x140 net/core/datagram.c:519 __skb_datagram_iter+0x2cb/0x1280 net/core/datagram.c:425 skb_copy_datagram_iter+0xdc/0x270 net/core/datagram.c:533 skb_copy_datagram_msg include/linux/skbuff.h:3657 [inline] netlink_recvmsg+0x660/0x1c60 net/netlink/af_netlink.c:1974 sock_recvmsg_nosec net/socket.c:944 [inline] sock_recvmsg net/socket.c:962 [inline] sock_read_iter+0x5a9/0x630 net/socket.c:1035 call_read_iter include/linux/fs.h:2156 [inline] new_sync_read fs/read_write.c:400 [inline] vfs_read+0x1631/0x1980 fs/read_write.c:481 ksys_read+0x28c/0x520 fs/read_write.c:619 __do_sys_read fs/read_write.c:629 [inline] __se_sys_read fs/read_write.c:627 [inline] __x64_sys_read+0xdb/0x120 fs/read_write.c:627 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x54/0xd0 arch/x86/entry/common.c:82 entry_SYSCALL_64_after_hwframe+0x44/0xae Uninit was created at: slab_post_alloc_hook mm/slab.h:524 [inline] slab_alloc_node mm/slub.c:3251 [inline] __kmalloc_node_track_caller+0xe0c/0x1510 mm/slub.c:4974 kmalloc_reserve net/core/skbuff.c:354 [inline] __alloc_skb+0x545/0xf90 net/core/skbuff.c:426 alloc_skb include/linux/skbuff.h:1126 [inline] netlink_dump+0x3d5/0x16a0 net/netlink/af_netlink.c:2245 __netlink_dump_start+0xd1c/0xee0 net/netlink/af_netlink.c:2370 netlink_dump_start include/linux/netlink.h:254 [inline] inet_diag_handler_cmd+0x2e7/0x400 net/ipv4/inet_diag.c:1343 sock_diag_rcv_msg+0x24a/0x620 netlink_rcv_skb+0x447/0x800 net/netlink/af_netlink.c:2491 sock_diag_rcv+0x63/0x80 net/core/sock_diag.c:276 netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline] netlink_unicast+0x1095/0x1360 net/netlink/af_netlink.c:1345 netlink_sendmsg+0x16f3/0x1870 net/netlink/af_netlink.c:1916 sock_sendmsg_nosec net/socket.c:704 [inline] sock_sendmsg net/socket.c:724 [inline] sock_write_iter+0x594/0x690 net/socket.c:1057 do_iter_readv_writev+0xa7f/0xc70 do_iter_write+0x52c/0x1500 fs/read_write.c:851 vfs_writev fs/read_write.c:924 [inline] do_writev+0x63f/0xe30 fs/read_write.c:967 __do_sys_writev fs/read_write.c:1040 [inline] __se_sys_writev fs/read_write.c:1037 [inline] __x64_sys_writev+0xe5/0x120 fs/read_write.c:1037 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x54/0xd0 arch/x86/entry/common.c:82 entry_SYSCALL_64_after_hwframe+0x44/0xae Bytes 68-71 of 312 are uninitialized Memory access of size 312 starts at ffff88812ab54000 Data copied to user address 0000000020001440 CPU: 1 PID: 6365 Comm: syz-executor801 Not tainted 5.16.0-rc3-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Fixes: 3c4d05c805 ("inet_diag: Introduce the inet socket dumping routine") Signed-off-by: Eric Dumazet <edumazet@google.com> Reported-by: syzbot <syzkaller@googlegroups.com> Link: https://lore.kernel.org/r/20211209185058.53917-1-eric.dumazet@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2021-12-22 09:32:40 +01:00
..
6lowpan	6lowpan: iphc: Fix an off-by-one check of array index	2021-07-22 16:19:03 +02:00
9p	9p/net: fix missing error check in p9_check_errors	2021-11-18 19:17:16 +01:00
802	net: 802: remove dead leftover after ipx driver removal	2021-08-13 16:30:35 -07:00
8021q	net: vlan: fix underflow for the real_dev refcnt	2021-12-01 09:04:53 +01:00
appletalk	net: socket: rework compat_ifreq_ioctl()	2021-07-23 14:20:25 +01:00
atm
ax25	ax25: use skb_expand_head	2021-08-03 11:21:39 +01:00
batman-adv	net: batman-adv: fix error handling	2021-10-26 14:47:12 +01:00
bluetooth	Bluetooth: fix init and cleanup of sco_conn.timeout_work	2021-11-18 19:16:22 +01:00
bpf	bpf, test, cgroup: Use sk_{alloc,free} for test cases	2021-09-28 09:29:28 +02:00
bpfilter
bridge	net: bridge: fix uninitialized variables when BRIDGE_CFM is disabled	2021-11-18 19:16:44 +01:00
caif	net-caif: avoid user-triggerable WARN_ON(1)	2021-09-14 12:51:15 +01:00
can	can: j1939: j1939_tp_cmd_recv(): check the dst address of TP.CM_BAM	2021-11-18 19:16:03 +01:00
ceph
core	net, neigh: clear whole pneigh_entry at alloc time	2021-12-14 10:57:19 +01:00
dcb
dccp	tcp: switch orphan_count to bare per-cpu counters	2021-11-18 19:16:33 +01:00
decnet	net: Remove redundant if statements	2021-08-05 13:27:50 +01:00
dns_resolver
dsa	net: dsa: felix: fix broken VLAN-tagged PTP under VLAN-aware bridge	2021-11-18 19:17:06 +01:00
ethernet	move netdev_boot_setup into Space.c	2021-08-03 13:05:26 +01:00
ethtool	ethtool: do not perform operations on net devices being unregistered	2021-12-14 10:57:09 +01:00
hsr
ieee802154	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2021-08-13 06:41:22 -07:00
ife
ipv4	inet_diag: fix kernel-infoleak for UDP sockets	2021-12-22 09:32:40 +01:00
ipv6	seg6: fix the iif in the IPv6 socket control block	2021-12-14 10:57:09 +01:00
iucv	net/iucv: Replace deprecated CPU-hotplug functions.	2021-08-09 10:13:32 +01:00
kcm
key
l2tp	net/l2tp: Fix reference count leak in l2tp_udp_recv_core	2021-09-09 11:00:20 +01:00
l3mdev
lapb
llc	net: Remove redundant if statements	2021-08-05 13:27:50 +01:00
mac80211	mac80211: track only QoS data frames for admission control	2021-12-22 09:32:38 +01:00
mac802154	ieee802154: Remove redundant initialization of variable ret	2021-09-07 14:06:08 +01:00
mctp	mctp: Don't let RTM_DELROUTE delete local routes	2021-12-08 09:04:53 +01:00
mpls	net: mpls: Fix notifications when deleting a device	2021-12-08 09:04:47 +01:00
mptcp	mptcp: use delegate action to schedule 3rd ack retrans	2021-12-01 09:04:49 +01:00
ncsi	net/ncsi : Add payload to be 32-bit aligned to fix dropped packets	2021-12-01 09:04:51 +01:00
netfilter	netfilter: conntrack: annotate data-races around ct->timeout	2021-12-14 10:57:10 +01:00
netlabel	net: fix NULL pointer reference in cipso_v4_doi_free	2021-08-30 12:23:18 +01:00
netlink	net: netlink: af_netlink: Prevent empty skb by adding a check on len.	2021-12-17 10:30:15 +01:00
netrom	net: Remove redundant if statements	2021-08-05 13:27:50 +01:00
nfc	nfc: fix segfault in nfc_genl_dump_devices_done	2021-12-17 10:30:12 +01:00
nsh
openvswitch	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2021-08-19 18:09:18 -07:00
packet	net/packet: clarify source of pr_*() messages	2021-09-10 10:00:59 +01:00
phonet	net: Remove redundant if statements	2021-08-05 13:27:50 +01:00
psample
qrtr	net: qrtr: revert check in qrtr_endpoint_post()	2021-09-02 11:37:02 +01:00
rds	net/rds: correct socket tunable error in rds_tcp_tune()	2021-12-08 09:04:50 +01:00
rfkill
rose
rxrpc	rxrpc: Fix rxrpc_local leak in rxrpc_lookup_peer()	2021-12-08 09:04:49 +01:00
sched	sch_cake: do not call cake_destroy() from cake_init()	2021-12-22 09:32:40 +01:00
sctp	sctp: return true only for pathmtu update in sctp_transport_pl_toobig	2021-11-18 19:16:43 +01:00
smc	net/smc: Keep smc_close_final rc during active close	2021-12-08 09:04:50 +01:00
strparser	bpf: sockmap, strparser, and tls are reusing qdisc_skb_cb and colliding	2021-11-18 19:17:11 +01:00
sunrpc	SUNRPC: Partial revert of commit 6f9f17287e	2021-11-18 19:17:20 +01:00
switchdev	net: make switchdev_bridge_port_{,unoffload} loosely coupled with the bridge	2021-08-04 12:35:07 +01:00
tipc	tipc: check for null after calling kmemdup	2021-11-25 09:48:42 +01:00
tls	net/tls: Fix authentication failure in CCM mode	2021-12-08 09:04:41 +01:00
unix	af_unix: fix regression in read after shutdown	2021-12-01 09:04:49 +01:00
vmw_vsock	virtio/vsock: fix the transport to work with VMADDR_CID_ANY	2021-12-22 09:32:39 +01:00
wireless	cfg80211: call cfg80211_stop_ap when switch from P2P_GO type	2021-11-25 09:48:46 +01:00
x25
xdp
xfrm	xfrm: fix rcu lock in xfrm_notify_userpolicy()	2021-09-23 10:11:12 +02:00
compat.c
devres.c
Kconfig	mctp: Add MCTP base	2021-07-29 15:06:49 +01:00
Makefile	mctp: Add MCTP base	2021-07-29 15:06:49 +01:00
socket.c	Core:	2021-08-31 16:43:06 -07:00
sysctl_net.c