Josef Bacik d98b5032c9 btrfs: fix deadlock with fsync+fiemap+transaction commit ... commit bf7ba8ee75 upstream. We are hitting the following deadlock in production occasionally Task 1 Task 2 Task 3 Task 4 Task 5 fsync(A) start trans start commit falloc(A) lock 5m-10m start trans wait for commit fiemap(A) lock 0-10m wait for 5m-10m (have 0-5m locked) have btrfs_need_log_full_commit !full_sync wait_ordered_extents finish_ordered_io(A) lock 0-5m DEADLOCK We have an existing dependency of file extent lock -> transaction. However in fsync if we tried to do the fast logging, but then had to fall back to committing the transaction, we will be forced to call btrfs_wait_ordered_range() to make sure all of our extents are updated. This creates a dependency of transaction -> file extent lock, because btrfs_finish_ordered_io() will need to take the file extent lock in order to run the ordered extents. Fix this by stopping the transaction if we have to do the full commit and we attempted to do the fast logging. Then attach to the transaction and commit it if we need to. CC: stable@vger.kernel.org # 5.15+ Reviewed-by: Filipe Manana <fdmanana@suse.com> Signed-off-by: Josef Bacik <josef@toxicpanda.com> Signed-off-by: David Sterba <dsterba@suse.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2022-06-29 09:03:27 +02:00
..
tests	btrfs: remove ignore_offset argument from btrfs_find_all_roots()	2021-08-23 13:19:01 +02:00
acl.c	overlayfs update for 5.15	2021-09-02 09:21:27 -07:00
async-thread.c	btrfs: fix memory ordering between normal and ordered work functions	2021-11-25 09:48:46 +01:00
async-thread.h
backref.c	btrfs: remove BUG_ON(!eie) in find_parent_nodes	2022-01-27 11:04:52 +01:00
backref.h	btrfs: remove ignore_offset argument from btrfs_find_all_roots()	2021-08-23 13:19:01 +02:00
block-group.c	btrfs: remove unused variable in btrfs_{start,write}_dirty_block_groups()	2022-04-20 09:34:04 +02:00
block-group.h	btrfs: rework chunk allocation to avoid exhaustion of the system chunk array	2021-07-07 17:42:41 +02:00
block-rsv.c
block-rsv.h
btrfs_inode.h	btrfs: initial fsverity support	2021-08-23 13:19:09 +02:00
check-integrity.c	btrfs: check-integrity: drop kmap/kunmap for block pages	2021-08-23 13:19:00 +02:00
check-integrity.h
compression.c	btrfs: remove unused parameter nr_pages in add_ra_bio_pages()	2022-04-20 09:34:04 +02:00
compression.h	btrfs: rework btrfs_decompress_buf2page()	2021-08-23 13:19:04 +02:00
ctree.c	btrfs: make send work with concurrent block group relocation	2022-03-16 14:23:46 +01:00
ctree.h	btrfs: skip reserved bytes warning on unmount after log cleanup failure	2022-03-23 09:16:43 +01:00
delalloc-space.c	btrfs: free exchange changeset on failures	2021-12-14 10:57:13 +01:00
delalloc-space.h
delayed-inode.c	btrfs: add ro compat flags to inodes	2021-08-23 13:19:09 +02:00
delayed-inode.h
delayed-ref.c	btrfs: fix lock inversion problem when doing qgroup extent tracing	2021-07-22 15:50:07 +02:00
delayed-ref.h
dev-replace.c	btrfs: zoned: cache reported zone during mount	2022-02-23 12:03:02 +01:00
dev-replace.h	btrfs: zoned: mark block groups to copy for device-replace	2021-02-09 02:46:07 +01:00
dir-item.c	btrfs: unify lookup return value when dir entry is missing	2021-10-07 22:06:32 +02:00
discard.c	btrfs: fix typos in comments	2021-06-22 14:11:57 +02:00
discard.h
disk-io.c	btrfs: fix hang during unmount when block group reclaim task is running	2022-06-29 09:03:19 +02:00
disk-io.h	btrfs: split alloc_log_tree()	2021-02-09 02:46:07 +01:00
export.c
export.h
extent-io-tree.h
extent-tree.c	btrfs: do not start relocation until in progress drops are done	2022-03-08 19:12:54 +01:00
extent_io.c	btrfs: fix the error handling for submit_extent_page() for btrfs_do_readpage()	2022-06-09 10:22:30 +02:00
extent_io.h	btrfs: fix qgroup reserve overflow the qgroup limit	2022-04-13 20:59:23 +02:00
extent_map.c
extent_map.h
file-item.c	btrfs: make search_csum_tree return 0 if we get -EFBIG	2022-04-08 14:23:58 +02:00
file.c	btrfs: fix deadlock with fsync+fiemap+transaction commit	2022-06-29 09:03:27 +02:00
free-space-cache.c	btrfs: zoned: fix block group alloc_offset calculation	2021-08-23 13:19:11 +02:00
free-space-cache.h
free-space-tree.c
free-space-tree.h
inode-item.c
inode.c	btrfs: fallback to blocking mode when doing async dio over multiple extents	2022-05-01 17:22:34 +02:00
ioctl.c	gup: Turn fault_in_pages_{readable,writeable} into fault_in_{readable,writeable}	2022-05-01 17:22:28 +02:00
Kconfig	btrfs: disable build on platforms having page size 256K	2021-06-22 14:11:57 +02:00
locking.c	btrfs: don't set lock_owner when locking extent buffer for reading	2022-06-29 09:03:27 +02:00
locking.h
lzo.c	btrfs: prevent copying too big compressed lzo segment	2022-03-02 11:48:07 +01:00
Makefile	btrfs: initial fsverity support	2021-08-23 13:19:09 +02:00
misc.h	btrfs: use correct header for div_u64 in misc.h	2021-09-07 14:29:50 +02:00
ordered-data.c	btrfs: zoned: fix double counting of split ordered extent	2021-09-07 14:30:41 +02:00
ordered-data.h	btrfs: remove uptodate parameter from btrfs_dec_test_first_ordered_pending	2021-08-23 13:19:02 +02:00
orphan.c
print-tree.c
print-tree.h
props.c	btrfs: props: change how empty value is interpreted	2021-06-22 14:11:58 +02:00
props.h
qgroup.c	btrfs: qgroup: fix deadlock between rescan worker and remove qgroup	2022-03-08 19:12:54 +01:00
qgroup.h	btrfs: fix lock inversion problem when doing qgroup extent tracing	2021-07-22 15:50:07 +02:00
raid56.c	btrfs: constify and cleanup variables in comparators	2021-08-23 13:19:03 +02:00
raid56.h
rcu-string.h
reada.c	btrfs: subpage: make readahead work properly	2021-03-16 11:06:21 +01:00
ref-verify.c	btrfs: stop doing GFP_KERNEL memory allocations in the ref verify tool	2021-08-23 13:19:00 +02:00
ref-verify.h
reflink.c	btrfs: fix unexpected error path when reflinking an inline extent	2022-04-08 14:23:11 +02:00
reflink.h
relocation.c	btrfs: make send work with concurrent block group relocation	2022-03-16 14:23:46 +01:00
root-tree.c	btrfs: do not start relocation until in progress drops are done	2022-03-08 19:12:54 +01:00
scrub.c	btrfs: make 1-bit bit-fields of scrub_page unsigned int	2021-11-25 09:48:37 +01:00
send.c	btrfs: make send work with concurrent block group relocation	2022-03-16 14:23:46 +01:00
send.h
space-info.c	btrfs: extend locking to all space_info members accesses	2022-04-08 14:23:02 +02:00
space-info.h	btrfs: rip out btrfs_space_info::total_bytes_pinned	2021-06-22 14:55:25 +02:00
struct-funcs.c	btrfs: add special case to setget helpers for 64k pages	2021-08-23 13:18:58 +02:00
subpage.c	btrfs: subpage: fix a potential use-after-free in writeback helper	2021-08-23 13:19:05 +02:00
subpage.h	btrfs: subpage: fix writeback which does not have ordered extent	2021-08-23 13:19:04 +02:00
super.c	btrfs: add error messages to all unrecognized mount options	2022-06-29 09:03:19 +02:00
sysfs.c	btrfs: sysfs: document structures and their associated files	2021-08-23 13:19:12 +02:00
sysfs.h
transaction.c	btrfs: make send work with concurrent block group relocation	2022-03-16 14:23:46 +01:00
transaction.h	btrfs: do not start relocation until in progress drops are done	2022-03-08 19:12:54 +01:00
tree-checker.c	btrfs: tree-checker: check item_size for dev_item	2022-03-02 11:47:48 +01:00
tree-checker.h
tree-defrag.c
tree-log.c	btrfs: always log symlinks in full mode	2022-05-12 12:30:20 +02:00
tree-log.h
tree-mod-log.c	btrfs: fix race when picking most recent mod log operation for an old root	2021-04-20 19:27:17 +02:00
tree-mod-log.h	btrfs: add and use helper to get lowest sequence number for the tree mod log	2021-04-19 17:25:17 +02:00
ulist.c
ulist.h
uuid-tree.c
verity.c	btrfs: fix transaction handle leak after verity rollback failure	2021-09-17 19:29:41 +02:00
volumes.c	btrfs: repair super block num_devices automatically	2022-06-09 10:22:30 +02:00
volumes.h	btrfs: convert latest_bdev type to btrfs_device and rename	2021-12-22 09:32:37 +01:00
xattr.c	btrfs: do not BUG_ON() on failure to update inode when setting xattr	2022-05-12 12:30:18 +02:00
xattr.h
zlib.c	Revert "btrfs: compression: drop kmap/kunmap from zlib"	2021-10-29 13:03:05 +02:00
zoned.c	btrfs: zoned: cache reported zone during mount	2022-02-23 12:03:02 +01:00
zoned.h	btrfs: zoned: cache reported zone during mount	2022-02-23 12:03:02 +01:00
zstd.c	Revert "btrfs: compression: drop kmap/kunmap from zstd"	2021-10-29 13:02:50 +02:00