linux-stable/sound/firewire
Geert Uytterhoeven 92f72f2c8e ALSA: fireface: Fix integer overflow in transmit_midi_msg()
commit e7c22eeaff upstream.

As snd_ff.rx_bytes[] is unsigned int, and NSEC_PER_SEC is 1000000000L,
the second multiplication in

    ff->rx_bytes[port] * 8 * NSEC_PER_SEC / 31250

always overflows on 32-bit platforms, truncating the result.  Fix this
by precalculating "NSEC_PER_SEC / 31250", which is an integer constant.

Note that this assumes ff->rx_bytes[port] <= 16777.

Fixes: 1917429578 ("ALSA: fireface: add transaction support")
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20210111130251.361335-2-geert+renesas@glider.be
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-01-23 15:48:45 +01:00
..
bebob ALSA: bebob: potential info leak in hwdep_read() 2020-10-29 09:06:59 +01:00
dice ALSA: dice: fix error path to destroy initialized stream data 2018-05-01 12:58:14 -07:00
digi00x ALSA: firewire-digi00x: exclude Avid Adrenaline from detection 2020-09-09 19:03:11 +02:00
fireface ALSA: fireface: Fix integer overflow in transmit_midi_msg() 2021-01-23 15:48:45 +01:00
fireworks ALSA: fireworks: fix memory leak of response buffer at error path 2018-09-29 03:06:03 -07:00
motu ALSA: firewire-motu: Correct a typo in the clock proc string 2020-01-09 10:17:56 +01:00
oxfw ALSA: oxfw: allow PCM capture for Stanton SCS.1m 2019-06-19 08:20:54 +02:00
tascam ALSA: firewire-tascam: Fix integer overflow in midi_port_work() 2021-01-23 15:48:45 +01:00
amdtp-am824.c ALSA: firewire-lib/fireworks: fix miss detection of received MIDI messages 2019-07-10 09:54:39 +02:00
amdtp-am824.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
amdtp-stream-trace.h ALSA: firewire-lib: use the same print format for 'without_header' tracepoints 2019-01-09 17:14:47 +01:00
amdtp-stream.c ALSA: firewire-lib: fix wrong handling payload_length as payload_quadlet 2019-01-09 17:14:47 +01:00
amdtp-stream.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
cmp.c
cmp.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
fcp.c ALSA: firewire-lib/bebob/oxfw: improve response evaluation for AV/C commands 2017-04-05 21:37:23 +02:00
fcp.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
isight.c ALSA: isight: fix leak of reference to firewire unit in error path of .probe callback 2019-12-01 09:13:16 +01:00
iso-resources.c ALSA: firewire: fix NULL pointer dereference when releasing uninitialized data of iso-resource 2017-08-20 09:40:32 +02:00
iso-resources.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
Kconfig ALSA: oxfw: add support for APOGEE duet FireWire 2019-01-26 09:37:01 +01:00
lib.c ALSA: firewire-lib/firewire-tascam: localize async midi port 2017-04-14 14:50:26 +02:00
lib.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
packets-buffer.c ALSA: firewire: fix a memory leak bug 2019-08-16 10:13:56 +02:00
packets-buffer.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00