mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-02 15:18:19 +00:00
d36ad77f70
This patch converts core_tpg_set_initiator_node_queue_depth() to use struct se_node_acl->acl_sess_list when performing explicit se_tpg_tfo->shutdown_session() for active sessions, in order for new se_node_acl->queue_depth to take effect. This follows how core_tpg_del_initiator_node_acl() currently works when invoking se_tpg_tfo->shutdown-session(), and ahead of the next patch to take se_node_acl->acl_kref during lookup, the extra get_initiator_node_acl() can go away. In order to achieve this, go ahead and change target_get_session() to use kref_get_unless_zero() and propigate up the return value to know when a session is already being released. This is because se_node_acl->acl_group is already protecting se_node_acl->acl_group reference via configfs, and shutdown within core_tpg_del_initiator_node_acl() won't occur until sys_write() to core_tpg_set_initiator_node_queue_depth() attribute returns back to user-space. Also, drop the left-over iscsi-target hack, and obtain se_portal_group->session_lock in lio_tpg_shutdown_session() internally. Remove iscsi-target wrapper and unused se_tpg + force parameters and associated code. Reported-by: Christoph Hellwig <hch@lst.de> Cc: Sagi Grimberg <sagig@mellanox.com> Cc: Hannes Reinecke <hare@suse.de> Cc: Andy Grover <agrover@redhat.com> Cc: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
43 lines
2.5 KiB
C
43 lines
2.5 KiB
C
#ifndef ISCSI_TARGET_TPG_H
|
|
#define ISCSI_TARGET_TPG_H
|
|
|
|
extern struct iscsi_portal_group *iscsit_alloc_portal_group(struct iscsi_tiqn *, u16);
|
|
extern int iscsit_load_discovery_tpg(void);
|
|
extern void iscsit_release_discovery_tpg(void);
|
|
extern struct iscsi_portal_group *iscsit_get_tpg_from_np(struct iscsi_tiqn *,
|
|
struct iscsi_np *, struct iscsi_tpg_np **);
|
|
extern int iscsit_get_tpg(struct iscsi_portal_group *);
|
|
extern void iscsit_put_tpg(struct iscsi_portal_group *);
|
|
extern void iscsit_tpg_dump_params(struct iscsi_portal_group *);
|
|
extern int iscsit_tpg_add_portal_group(struct iscsi_tiqn *, struct iscsi_portal_group *);
|
|
extern int iscsit_tpg_del_portal_group(struct iscsi_tiqn *, struct iscsi_portal_group *,
|
|
int);
|
|
extern int iscsit_tpg_enable_portal_group(struct iscsi_portal_group *);
|
|
extern int iscsit_tpg_disable_portal_group(struct iscsi_portal_group *, int);
|
|
extern struct iscsi_node_acl *iscsit_tpg_add_initiator_node_acl(
|
|
struct iscsi_portal_group *, const char *, u32);
|
|
extern void iscsit_tpg_del_initiator_node_acl(struct iscsi_portal_group *,
|
|
struct se_node_acl *);
|
|
extern struct iscsi_node_attrib *iscsit_tpg_get_node_attrib(struct iscsi_session *);
|
|
extern void iscsit_tpg_del_external_nps(struct iscsi_tpg_np *);
|
|
extern struct iscsi_tpg_np *iscsit_tpg_locate_child_np(struct iscsi_tpg_np *, int);
|
|
extern struct iscsi_tpg_np *iscsit_tpg_add_network_portal(struct iscsi_portal_group *,
|
|
struct sockaddr_storage *, struct iscsi_tpg_np *,
|
|
int);
|
|
extern int iscsit_tpg_del_network_portal(struct iscsi_portal_group *,
|
|
struct iscsi_tpg_np *);
|
|
extern int iscsit_ta_authentication(struct iscsi_portal_group *, u32);
|
|
extern int iscsit_ta_login_timeout(struct iscsi_portal_group *, u32);
|
|
extern int iscsit_ta_netif_timeout(struct iscsi_portal_group *, u32);
|
|
extern int iscsit_ta_generate_node_acls(struct iscsi_portal_group *, u32);
|
|
extern int iscsit_ta_default_cmdsn_depth(struct iscsi_portal_group *, u32);
|
|
extern int iscsit_ta_cache_dynamic_acls(struct iscsi_portal_group *, u32);
|
|
extern int iscsit_ta_demo_mode_write_protect(struct iscsi_portal_group *, u32);
|
|
extern int iscsit_ta_prod_mode_write_protect(struct iscsi_portal_group *, u32);
|
|
extern int iscsit_ta_demo_mode_discovery(struct iscsi_portal_group *, u32);
|
|
extern int iscsit_ta_default_erl(struct iscsi_portal_group *, u32);
|
|
extern int iscsit_ta_t10_pi(struct iscsi_portal_group *, u32);
|
|
extern int iscsit_ta_fabric_prot_type(struct iscsi_portal_group *, u32);
|
|
extern int iscsit_ta_tpg_enabled_sendtargets(struct iscsi_portal_group *, u32);
|
|
|
|
#endif /* ISCSI_TARGET_TPG_H */
|