mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-12 13:55:32 +00:00
![Vladimir Oltean](/assets/img/avatar_default.png)
Some really really weird switches just couldn't decide whether to use a normal or a tail tagger, so they just did both. This creates problems for DSA, because we only have the concept of an 'overhead' which can be applied to the headroom or to the tailroom of the skb (like for example during the central TX reallocation procedure), depending on the value of bool tail_tag, but not to both. We need to generalize DSA to cater for these odd switches by transforming the 'overhead / tail_tag' pair into 'needed_headroom / needed_tailroom'. The DSA master's MTU is increased to account for both. The flow dissector code is modified such that it only calls the DSA adjustment callback if the tagger has a non-zero header length. Taggers are trivially modified to declare either needed_headroom or needed_tailroom, based on the tail_tag value that they currently declare. Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Signed-off-by: David S. Miller <davem@davemloft.net>
63 lines
1.4 KiB
C
63 lines
1.4 KiB
C
// SPDX-License-Identifier: (GPL-2.0 OR MIT)
|
|
/*
|
|
* net/dsa/tag_hellcreek.c - Hirschmann Hellcreek switch tag format handling
|
|
*
|
|
* Copyright (C) 2019,2020 Linutronix GmbH
|
|
* Author Kurt Kanzenbach <kurt@linutronix.de>
|
|
*
|
|
* Based on tag_ksz.c.
|
|
*/
|
|
|
|
#include <linux/skbuff.h>
|
|
#include <net/dsa.h>
|
|
|
|
#include "dsa_priv.h"
|
|
|
|
#define HELLCREEK_TAG_LEN 1
|
|
|
|
static struct sk_buff *hellcreek_xmit(struct sk_buff *skb,
|
|
struct net_device *dev)
|
|
{
|
|
struct dsa_port *dp = dsa_slave_to_port(dev);
|
|
u8 *tag;
|
|
|
|
/* Tag encoding */
|
|
tag = skb_put(skb, HELLCREEK_TAG_LEN);
|
|
*tag = BIT(dp->index);
|
|
|
|
return skb;
|
|
}
|
|
|
|
static struct sk_buff *hellcreek_rcv(struct sk_buff *skb,
|
|
struct net_device *dev,
|
|
struct packet_type *pt)
|
|
{
|
|
/* Tag decoding */
|
|
u8 *tag = skb_tail_pointer(skb) - HELLCREEK_TAG_LEN;
|
|
unsigned int port = tag[0] & 0x03;
|
|
|
|
skb->dev = dsa_master_find_slave(dev, 0, port);
|
|
if (!skb->dev) {
|
|
netdev_warn(dev, "Failed to get source port: %d\n", port);
|
|
return NULL;
|
|
}
|
|
|
|
pskb_trim_rcsum(skb, skb->len - HELLCREEK_TAG_LEN);
|
|
|
|
skb->offload_fwd_mark = true;
|
|
|
|
return skb;
|
|
}
|
|
|
|
static const struct dsa_device_ops hellcreek_netdev_ops = {
|
|
.name = "hellcreek",
|
|
.proto = DSA_TAG_PROTO_HELLCREEK,
|
|
.xmit = hellcreek_xmit,
|
|
.rcv = hellcreek_rcv,
|
|
.needed_tailroom = HELLCREEK_TAG_LEN,
|
|
};
|
|
|
|
MODULE_LICENSE("Dual MIT/GPL");
|
|
MODULE_ALIAS_DSA_TAG_DRIVER(DSA_TAG_PROTO_HELLCREEK);
|
|
|
|
module_dsa_tag_driver(hellcreek_netdev_ops);
|