mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-30 14:19:16 +00:00
2e8cff0a0e
On arm64, "rodata=full" has been suppored (but not documented) since commit:c55191e96c("arm64: mm: apply r/o permissions of VM areas to its linear alias as well") As it's necessary to determine the rodata configuration early during boot, arm64 has an early_param() handler for this, whereas init/main.c has a __setup() handler which is run later. Unfortunately, this split meant that since commit:f9a40b0890("init/main.c: return 1 from handled __setup() functions") ... passing "rodata=full" would result in a spurious warning from the __setup() handler (though RO permissions would be configured appropriately). Further, "rodata=full" has been broken since commit:0d6ea3ac94("lib/kstrtox.c: add "false"/"true" support to kstrtobool()") ... which caused strtobool() to parse "full" as false (in addition to many other values not documented for the "rodata=" kernel parameter. This patch fixes this breakage by: * Moving the core parameter parser to an __early_param(), such that it is available early. * Adding an (optional) arch hook which arm64 can use to parse "full". * Updating the documentation to mention that "full" is valid for arm64. * Having the core parameter parser handle "on" and "off" explicitly, such that any undocumented values (e.g. typos such as "ful") are reported as errors rather than being silently accepted. Note that __setup() and early_param() have opposite conventions for their return values, where __setup() uses 1 to indicate a parameter was handled and early_param() uses 0 to indicate a parameter was handled. Fixes:f9a40b0890("init/main.c: return 1 from handled __setup() functions") Fixes:0d6ea3ac94("lib/kstrtox.c: add "false"/"true" support to kstrtobool()") Signed-off-by: Mark Rutland <mark.rutland@arm.com> Cc: Andy Shevchenko <andy.shevchenko@gmail.com> Cc: Ard Biesheuvel <ardb@kernel.org> Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: Jagdish Gediya <jvgediya@linux.ibm.com> Cc: Matthew Wilcox <willy@infradead.org> Cc: Randy Dunlap <rdunlap@infradead.org> Cc: Will Deacon <will@kernel.org> Reviewed-by: Ard Biesheuvel <ardb@kernel.org> Link: https://lore.kernel.org/r/20220817154022.3974645-1-mark.rutland@arm.com Signed-off-by: Will Deacon <will@kernel.org>
34 lines
660 B
C
34 lines
660 B
C
// SPDX-License-Identifier: GPL-2.0
|
|
|
|
#ifndef __ARM64_ASM_SETUP_H
|
|
#define __ARM64_ASM_SETUP_H
|
|
|
|
#include <linux/string.h>
|
|
|
|
#include <uapi/asm/setup.h>
|
|
|
|
void *get_early_fdt_ptr(void);
|
|
void early_fdt_map(u64 dt_phys);
|
|
|
|
/*
|
|
* These two variables are used in the head.S file.
|
|
*/
|
|
extern phys_addr_t __fdt_pointer __initdata;
|
|
extern u64 __cacheline_aligned boot_args[4];
|
|
|
|
static inline bool arch_parse_debug_rodata(char *arg)
|
|
{
|
|
extern bool rodata_enabled;
|
|
extern bool rodata_full;
|
|
|
|
if (arg && !strcmp(arg, "full")) {
|
|
rodata_enabled = true;
|
|
rodata_full = true;
|
|
return true;
|
|
}
|
|
|
|
return false;
|
|
}
|
|
#define arch_parse_debug_rodata arch_parse_debug_rodata
|
|
|
|
#endif
|