mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-21 08:19:28 +00:00
51bbf9bee3
When a hotplug driver calls pci_hp_register(), all steps necessary for
registration are carried out in one go, including creation of a kobject
and addition to sysfs. That's a problem for pciehp once it's converted
to enable/disable the slot exclusively from the IRQ thread: The thread
needs to be spawned after creation of the kobject (because it uses the
kobject's name), but before addition to sysfs (because it will handle
enable/disable requests submitted via sysfs).
pci_hp_deregister() does offer a ->release callback that's invoked
after deletion from sysfs and before destruction of the kobject. But
because pci_hp_register() doesn't offer a counterpart, hotplug drivers'
->probe and ->remove code becomes asymmetric, which is error prone
as recently discovered use-after-free bugs in pciehp's ->remove hook
have shown.
In a sense, this appears to be a case of the midlayer antipattern:
"The core thesis of the "midlayer mistake" is that midlayers are
bad and should not exist. That common functionality which it is
so tempting to put in a midlayer should instead be provided as
library routines which can [be] used, augmented, or ignored by
each bottom level driver independently. Thus every subsystem
that supports multiple implementations (or drivers) should
provide a very thin top layer which calls directly into the
bottom layer drivers, and a rich library of support code that
eases the implementation of those drivers. This library is
available to, but not forced upon, those drivers."
-- Neil Brown (2009), https://lwn.net/Articles/336262/
The presence of midlayer traits in the PCI hotplug core might be ascribed
to its age: When it was introduced in February 2002, the blessings of a
library approach might not have been well known:
https://git.kernel.org/tglx/history/c/a8a2069f432c
For comparison, the driver core does offer split functions for creating
a kobject (device_initialize()) and addition to sysfs (device_add()) as
an alternative to carrying out everything at once (device_register()).
This was introduced in October 2002:
https://git.kernel.org/tglx/history/c/8b290eb19962
The odd ->release callback in the PCI hotplug core was added in 2003:
https://git.kernel.org/tglx/history/c/69f8d663b595
Clearly, a library approach would not force every hotplug driver to
implement a ->release callback, but rather allow the driver to remove
the sysfs files, release its data structures and finally destroy the
kobject. Alternatively, a driver may choose to remove everything with
pci_hp_deregister(), then release its data structures.
To this end, offer drivers pci_hp_initialize() and pci_hp_add() as a
split-up version of pci_hp_register(). Likewise, offer pci_hp_del()
and pci_hp_destroy() as a split-up version of pci_hp_deregister().
Eliminate the ->release callback and move its code into each driver's
teardown routine.
Declare pci_hp_deregister() void, in keeping with the usual kernel
pattern that enablement can fail, but disablement cannot. It only
returned an error if the caller passed in a NULL pointer or a slot which
has never or is no longer registered or is sharing its name with another
slot. Those would be bugs, so WARN about them. Few hotplug drivers
actually checked the return value and those that did only printed a
useless error message to dmesg. Remove that.
For most drivers the conversion was straightforward since it doesn't
matter whether the code in the ->release callback is executed before or
after destruction of the kobject. But in the case of ibmphp, it was
unclear to me whether setting slot_cur->ctrl and slot_cur->bus_on to
NULL needs to happen before the kobject is destroyed, so I erred on
the side of caution and ensured that the order stays the same. Another
nontrivial case is pnv_php, I've found the list and kref logic difficult
to understand, however my impression was that it is safe to delete the
list element and drop the references until after the kobject is
destroyed.
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com> # drivers/platform/x86
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
Cc: Len Brown <lenb@kernel.org>
Cc: Scott Murray <scott@spiteful.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Gavin Shan <gwshan@linux.vnet.ibm.com>
Cc: Sebastian Ott <sebott@linux.vnet.ibm.com>
Cc: Gerald Schaefer <gerald.schaefer@de.ibm.com>
Cc: Corentin Chary <corentin.chary@gmail.com>
Cc: Darren Hart <dvhart@infradead.org>
Cc: Andy Shevchenko <andy@infradead.org>
196 lines
6.8 KiB
C
196 lines
6.8 KiB
C
/* SPDX-License-Identifier: GPL-2.0+ */
|
|
/*
|
|
* PCI HotPlug Core Functions
|
|
*
|
|
* Copyright (C) 1995,2001 Compaq Computer Corporation
|
|
* Copyright (C) 2001 Greg Kroah-Hartman (greg@kroah.com)
|
|
* Copyright (C) 2001 IBM Corp.
|
|
*
|
|
* All rights reserved.
|
|
*
|
|
* Send feedback to <kristen.c.accardi@intel.com>
|
|
*
|
|
*/
|
|
#ifndef _PCI_HOTPLUG_H
|
|
#define _PCI_HOTPLUG_H
|
|
|
|
/**
|
|
* struct hotplug_slot_ops -the callbacks that the hotplug pci core can use
|
|
* @owner: The module owner of this structure
|
|
* @mod_name: The module name (KBUILD_MODNAME) of this structure
|
|
* @enable_slot: Called when the user wants to enable a specific pci slot
|
|
* @disable_slot: Called when the user wants to disable a specific pci slot
|
|
* @set_attention_status: Called to set the specific slot's attention LED to
|
|
* the specified value
|
|
* @hardware_test: Called to run a specified hardware test on the specified
|
|
* slot.
|
|
* @get_power_status: Called to get the current power status of a slot.
|
|
* If this field is NULL, the value passed in the struct hotplug_slot_info
|
|
* will be used when this value is requested by a user.
|
|
* @get_attention_status: Called to get the current attention status of a slot.
|
|
* If this field is NULL, the value passed in the struct hotplug_slot_info
|
|
* will be used when this value is requested by a user.
|
|
* @get_latch_status: Called to get the current latch status of a slot.
|
|
* If this field is NULL, the value passed in the struct hotplug_slot_info
|
|
* will be used when this value is requested by a user.
|
|
* @get_adapter_status: Called to get see if an adapter is present in the slot or not.
|
|
* If this field is NULL, the value passed in the struct hotplug_slot_info
|
|
* will be used when this value is requested by a user.
|
|
* @reset_slot: Optional interface to allow override of a bus reset for the
|
|
* slot for cases where a secondary bus reset can result in spurious
|
|
* hotplug events or where a slot can be reset independent of the bus.
|
|
*
|
|
* The table of function pointers that is passed to the hotplug pci core by a
|
|
* hotplug pci driver. These functions are called by the hotplug pci core when
|
|
* the user wants to do something to a specific slot (query it for information,
|
|
* set an LED, enable / disable power, etc.)
|
|
*/
|
|
struct hotplug_slot_ops {
|
|
struct module *owner;
|
|
const char *mod_name;
|
|
int (*enable_slot) (struct hotplug_slot *slot);
|
|
int (*disable_slot) (struct hotplug_slot *slot);
|
|
int (*set_attention_status) (struct hotplug_slot *slot, u8 value);
|
|
int (*hardware_test) (struct hotplug_slot *slot, u32 value);
|
|
int (*get_power_status) (struct hotplug_slot *slot, u8 *value);
|
|
int (*get_attention_status) (struct hotplug_slot *slot, u8 *value);
|
|
int (*get_latch_status) (struct hotplug_slot *slot, u8 *value);
|
|
int (*get_adapter_status) (struct hotplug_slot *slot, u8 *value);
|
|
int (*reset_slot) (struct hotplug_slot *slot, int probe);
|
|
};
|
|
|
|
/**
|
|
* struct hotplug_slot_info - used to notify the hotplug pci core of the state of the slot
|
|
* @power_status: if power is enabled or not (1/0)
|
|
* @attention_status: if the attention light is enabled or not (1/0)
|
|
* @latch_status: if the latch (if any) is open or closed (1/0)
|
|
* @adapter_status: if there is a pci board present in the slot or not (1/0)
|
|
*
|
|
* Used to notify the hotplug pci core of the status of a specific slot.
|
|
*/
|
|
struct hotplug_slot_info {
|
|
u8 power_status;
|
|
u8 attention_status;
|
|
u8 latch_status;
|
|
u8 adapter_status;
|
|
};
|
|
|
|
/**
|
|
* struct hotplug_slot - used to register a physical slot with the hotplug pci core
|
|
* @ops: pointer to the &struct hotplug_slot_ops to be used for this slot
|
|
* @info: pointer to the &struct hotplug_slot_info for the initial values for
|
|
* this slot.
|
|
* @private: used by the hotplug pci controller driver to store whatever it
|
|
* needs.
|
|
*/
|
|
struct hotplug_slot {
|
|
struct hotplug_slot_ops *ops;
|
|
struct hotplug_slot_info *info;
|
|
void *private;
|
|
|
|
/* Variables below this are for use only by the hotplug pci core. */
|
|
struct list_head slot_list;
|
|
struct pci_slot *pci_slot;
|
|
};
|
|
|
|
static inline const char *hotplug_slot_name(const struct hotplug_slot *slot)
|
|
{
|
|
return pci_slot_name(slot->pci_slot);
|
|
}
|
|
|
|
int __pci_hp_register(struct hotplug_slot *slot, struct pci_bus *pbus, int nr,
|
|
const char *name, struct module *owner,
|
|
const char *mod_name);
|
|
int __pci_hp_initialize(struct hotplug_slot *slot, struct pci_bus *bus, int nr,
|
|
const char *name, struct module *owner,
|
|
const char *mod_name);
|
|
int pci_hp_add(struct hotplug_slot *slot);
|
|
|
|
void pci_hp_del(struct hotplug_slot *slot);
|
|
void pci_hp_destroy(struct hotplug_slot *slot);
|
|
void pci_hp_deregister(struct hotplug_slot *slot);
|
|
|
|
int __must_check pci_hp_change_slot_info(struct hotplug_slot *slot,
|
|
struct hotplug_slot_info *info);
|
|
|
|
/* use a define to avoid include chaining to get THIS_MODULE & friends */
|
|
#define pci_hp_register(slot, pbus, devnr, name) \
|
|
__pci_hp_register(slot, pbus, devnr, name, THIS_MODULE, KBUILD_MODNAME)
|
|
#define pci_hp_initialize(slot, bus, nr, name) \
|
|
__pci_hp_initialize(slot, bus, nr, name, THIS_MODULE, KBUILD_MODNAME)
|
|
|
|
/* PCI Setting Record (Type 0) */
|
|
struct hpp_type0 {
|
|
u32 revision;
|
|
u8 cache_line_size;
|
|
u8 latency_timer;
|
|
u8 enable_serr;
|
|
u8 enable_perr;
|
|
};
|
|
|
|
/* PCI-X Setting Record (Type 1) */
|
|
struct hpp_type1 {
|
|
u32 revision;
|
|
u8 max_mem_read;
|
|
u8 avg_max_split;
|
|
u16 tot_max_split;
|
|
};
|
|
|
|
/* PCI Express Setting Record (Type 2) */
|
|
struct hpp_type2 {
|
|
u32 revision;
|
|
u32 unc_err_mask_and;
|
|
u32 unc_err_mask_or;
|
|
u32 unc_err_sever_and;
|
|
u32 unc_err_sever_or;
|
|
u32 cor_err_mask_and;
|
|
u32 cor_err_mask_or;
|
|
u32 adv_err_cap_and;
|
|
u32 adv_err_cap_or;
|
|
u16 pci_exp_devctl_and;
|
|
u16 pci_exp_devctl_or;
|
|
u16 pci_exp_lnkctl_and;
|
|
u16 pci_exp_lnkctl_or;
|
|
u32 sec_unc_err_sever_and;
|
|
u32 sec_unc_err_sever_or;
|
|
u32 sec_unc_err_mask_and;
|
|
u32 sec_unc_err_mask_or;
|
|
};
|
|
|
|
struct hotplug_params {
|
|
struct hpp_type0 *t0; /* Type0: NULL if not available */
|
|
struct hpp_type1 *t1; /* Type1: NULL if not available */
|
|
struct hpp_type2 *t2; /* Type2: NULL if not available */
|
|
struct hpp_type0 type0_data;
|
|
struct hpp_type1 type1_data;
|
|
struct hpp_type2 type2_data;
|
|
};
|
|
|
|
#ifdef CONFIG_ACPI
|
|
#include <linux/acpi.h>
|
|
int pci_get_hp_params(struct pci_dev *dev, struct hotplug_params *hpp);
|
|
bool pciehp_is_native(struct pci_dev *bridge);
|
|
int acpi_get_hp_hw_control_from_firmware(struct pci_dev *bridge);
|
|
bool shpchp_is_native(struct pci_dev *bridge);
|
|
int acpi_pci_check_ejectable(struct pci_bus *pbus, acpi_handle handle);
|
|
int acpi_pci_detect_ejectable(acpi_handle handle);
|
|
#else
|
|
static inline int pci_get_hp_params(struct pci_dev *dev,
|
|
struct hotplug_params *hpp)
|
|
{
|
|
return -ENODEV;
|
|
}
|
|
|
|
static inline int acpi_get_hp_hw_control_from_firmware(struct pci_dev *bridge)
|
|
{
|
|
return 0;
|
|
}
|
|
static inline bool pciehp_is_native(struct pci_dev *bridge) { return true; }
|
|
static inline bool shpchp_is_native(struct pci_dev *bridge) { return true; }
|
|
#endif
|
|
|
|
static inline bool hotplug_is_native(struct pci_dev *bridge)
|
|
{
|
|
return pciehp_is_native(bridge) || shpchp_is_native(bridge);
|
|
}
|
|
#endif
|