Christian Marangi 10f2af1af8 leds: trigger: netdev: Fix kernel panic on interface rename trig notify ... [ Upstream commit 415798bc07 ] Commit d5e01266e7 ("leds: trigger: netdev: add additional specific link speed mode") in the various changes, reworked the way to set the LINKUP mode in commit cee4bd16c3 ("leds: trigger: netdev: Recheck NETDEV_LED_MODE_LINKUP on dev rename") and moved it to a generic function. This changed the logic where, in the previous implementation the dev from the trigger event was used to check if the carrier was ok, but in the new implementation with the generic function, the dev in trigger_data is used instead. This is problematic and cause a possible kernel panic due to the fact that the dev in the trigger_data still reference the old one as the new one (passed from the trigger event) still has to be hold and saved in the trigger_data struct (done in the NETDEV_REGISTER case). On calling of get_device_state(), an invalid net_dev is used and this cause a kernel panic. To handle this correctly, move the call to get_device_state() after the new net_dev is correctly set in trigger_data (in the NETDEV_REGISTER case) and correctly parse the new dev. Fixes: d5e01266e7 ("leds: trigger: netdev: add additional specific link speed mode") Cc: stable@vger.kernel.org Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Link: https://lore.kernel.org/r/20240203235413.1146-1-ansuelsmth@gmail.com Signed-off-by: Lee Jones <lee@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-04-03 15:28:27 +02:00
..
Kconfig	leds: Mark GPIO LED trigger broken	2023-03-16 15:08:44 +00:00
Makefile	leds: trigger: implement a tty trigger	2021-01-15 10:22:26 +01:00
ledtrig-activity.c	treewide: Convert del_timer*() to timer_shutdown*()	2022-12-25 13:38:09 -08:00
ledtrig-audio.c	leds: trigger: audio: Add an activate callback to ensure the initial brightness is set	2021-08-03 23:57:17 +02:00
ledtrig-backlight.c	…
ledtrig-camera.c	…
ledtrig-cpu.c	leds: trigger: ledtrig-cpu:: Fix 'output may be truncated' issue for 'cpu'	2023-11-20 11:59:24 +01:00
ledtrig-default-on.c	…
ledtrig-disk.c	leds: Change led_trigger_blink[_oneshot]() delay parameters to pass-by-value	2023-05-25 12:16:27 +01:00
ledtrig-gpio.c	…
ledtrig-heartbeat.c	treewide: Convert del_timer*() to timer_shutdown*()	2022-12-25 13:38:09 -08:00
ledtrig-mtd.c	leds: Change led_trigger_blink[_oneshot]() delay parameters to pass-by-value	2023-05-25 12:16:27 +01:00
ledtrig-netdev.c	leds: trigger: netdev: Fix kernel panic on interface rename trig notify	2024-04-03 15:28:27 +02:00
ledtrig-oneshot.c	…
ledtrig-panic.c	leds: trigger: panic: Don't register panic notifier if creating the trigger failed	2024-02-05 20:14:30 +00:00
ledtrig-pattern.c	treewide: Convert del_timer*() to timer_shutdown*()	2022-12-25 13:38:09 -08:00
ledtrig-timer.c	…
ledtrig-transient.c	treewide: Convert del_timer*() to timer_shutdown*()	2022-12-25 13:38:09 -08:00
ledtrig-tty.c	leds: ledtrig-tty: Free allocated ttyname buffer on deactivate	2024-01-20 11:51:48 +01:00