mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-21 08:19:28 +00:00
![Javier Martinez Canillas](/assets/img/avatar_default.png)
The PTR_ERR_OR_ZERO() helper function checks if a pointer contains an errno code and returns it or return 0 if that's not the case. Use the helper instead of open coding the same logic in the driver. This was found with make coccicheck that complains with the following warning: drivers/input/touchscreen/cyttsp4_i2c.c:53:1-3: WARNING: PTR_ERR_OR_ZERO can be used Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
85 lines
2.2 KiB
C
85 lines
2.2 KiB
C
/*
|
|
* cyttsp_i2c.c
|
|
* Cypress TrueTouch(TM) Standard Product (TTSP) I2C touchscreen driver.
|
|
* For use with Cypress Txx4xx parts.
|
|
* Supported parts include:
|
|
* TMA4XX
|
|
* TMA1036
|
|
*
|
|
* Copyright (C) 2009, 2010, 2011 Cypress Semiconductor, Inc.
|
|
* Copyright (C) 2012 Javier Martinez Canillas <javier@dowhile0.org>
|
|
* Copyright (C) 2013 Cypress Semiconductor
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* version 2, and only version 2, as published by the
|
|
* Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* Contact Cypress Semiconductor at www.cypress.com <ttdrivers@cypress.com>
|
|
*
|
|
*/
|
|
|
|
#include "cyttsp4_core.h"
|
|
|
|
#include <linux/i2c.h>
|
|
#include <linux/input.h>
|
|
|
|
#define CYTTSP4_I2C_DATA_SIZE (3 * 256)
|
|
|
|
static const struct cyttsp4_bus_ops cyttsp4_i2c_bus_ops = {
|
|
.bustype = BUS_I2C,
|
|
.write = cyttsp_i2c_write_block_data,
|
|
.read = cyttsp_i2c_read_block_data,
|
|
};
|
|
|
|
static int cyttsp4_i2c_probe(struct i2c_client *client,
|
|
const struct i2c_device_id *id)
|
|
{
|
|
struct cyttsp4 *ts;
|
|
|
|
if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) {
|
|
dev_err(&client->dev, "I2C functionality not Supported\n");
|
|
return -EIO;
|
|
}
|
|
|
|
ts = cyttsp4_probe(&cyttsp4_i2c_bus_ops, &client->dev, client->irq,
|
|
CYTTSP4_I2C_DATA_SIZE);
|
|
|
|
return PTR_ERR_OR_ZERO(ts);
|
|
}
|
|
|
|
static int cyttsp4_i2c_remove(struct i2c_client *client)
|
|
{
|
|
struct cyttsp4 *ts = i2c_get_clientdata(client);
|
|
|
|
cyttsp4_remove(ts);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct i2c_device_id cyttsp4_i2c_id[] = {
|
|
{ CYTTSP4_I2C_NAME, 0 },
|
|
{ }
|
|
};
|
|
MODULE_DEVICE_TABLE(i2c, cyttsp4_i2c_id);
|
|
|
|
static struct i2c_driver cyttsp4_i2c_driver = {
|
|
.driver = {
|
|
.name = CYTTSP4_I2C_NAME,
|
|
.pm = &cyttsp4_pm_ops,
|
|
},
|
|
.probe = cyttsp4_i2c_probe,
|
|
.remove = cyttsp4_i2c_remove,
|
|
.id_table = cyttsp4_i2c_id,
|
|
};
|
|
|
|
module_i2c_driver(cyttsp4_i2c_driver);
|
|
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_DESCRIPTION("Cypress TrueTouch(R) Standard Product (TTSP) I2C driver");
|
|
MODULE_AUTHOR("Cypress");
|