John Meneghini 2f5a1ac68b scsi: bnx2fc: Make bnx2fc_recv_frame() mp safe ... commit 936bd03405 upstream. Running tests with a debug kernel shows that bnx2fc_recv_frame() is modifying the per_cpu lport stats counters in a non-mpsafe way. Just boot a debug kernel and run the bnx2fc driver with the hardware enabled. [ 1391.699147] BUG: using smp_processor_id() in preemptible [00000000] code: bnx2fc_ [ 1391.699160] caller is bnx2fc_recv_frame+0xbf9/0x1760 [bnx2fc] [ 1391.699174] CPU: 2 PID: 4355 Comm: bnx2fc_l2_threa Kdump: loaded Tainted: G B [ 1391.699180] Hardware name: HP ProLiant DL120 G7, BIOS J01 07/01/2013 [ 1391.699183] Call Trace: [ 1391.699188] dump_stack_lvl+0x57/0x7d [ 1391.699198] check_preemption_disabled+0xc8/0xd0 [ 1391.699205] bnx2fc_recv_frame+0xbf9/0x1760 [bnx2fc] [ 1391.699215] ? do_raw_spin_trylock+0xb5/0x180 [ 1391.699221] ? bnx2fc_npiv_create_vports.isra.0+0x4e0/0x4e0 [bnx2fc] [ 1391.699229] ? bnx2fc_l2_rcv_thread+0xb7/0x3a0 [bnx2fc] [ 1391.699240] bnx2fc_l2_rcv_thread+0x1af/0x3a0 [bnx2fc] [ 1391.699250] ? bnx2fc_ulp_init+0xc0/0xc0 [bnx2fc] [ 1391.699258] kthread+0x364/0x420 [ 1391.699263] ? _raw_spin_unlock_irq+0x24/0x50 [ 1391.699268] ? set_kthread_struct+0x100/0x100 [ 1391.699273] ret_from_fork+0x22/0x30 Restore the old get_cpu/put_cpu code with some modifications to reduce the size of the critical section. Link: https://lore.kernel.org/r/20220124145110.442335-1-jmeneghi@redhat.com Fixes: d576a5e80c ("bnx2fc: Improve stats update mechanism") Tested-by: Guangwu Zhang <guazhang@redhat.com> Acked-by: Saurav Kashyap <skashyap@marvell.com> Signed-off-by: John Meneghini <jmeneghi@redhat.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2022-02-08 18:34:11 +01:00
..
57xx_hsi_bnx2fc.h	scsi: Fix various misspellings of "connect"	2019-10-24 21:22:32 -04:00
bnx2fc.h	scsi: libfc: Move scsi/fc_encode.h to libfc	2020-10-29 21:49:25 -04:00
bnx2fc_constants.h
bnx2fc_debug.c
bnx2fc_debug.h
bnx2fc_els.c	scsi: bnx2fc: fix bnx2fc_cmd refcount imbalance in send_srr	2019-06-26 22:43:02 -04:00
bnx2fc_fcoe.c	scsi: bnx2fc: Make bnx2fc_recv_frame() mp safe	2022-02-08 18:34:11 +01:00
bnx2fc_hwi.c	scsi: bnx2fc: Fix typo in bnx2fc_indicate_kcqe()	2021-03-15 22:14:51 -04:00
bnx2fc_io.c	SCSI misc on 20210711	2021-07-11 10:59:53 -07:00
bnx2fc_tgt.c	scsi: bnx2fc: Fix misnaming of bnx2fc_free_session_resc()	2021-03-15 22:14:52 -04:00
Kconfig	scsi: bnx2fc: Fix Kconfig warning & CNIC build errors	2021-02-22 22:26:39 -05:00
Makefile	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00