linux-stable/drivers
Colin Ian King 5425711b6d net: dsa: sja1105: fix check on while loop exit
The while-loop exit condition check is not correct; the
loop should continue if the returns from the function calls are
negative or the CRC status returns are invalid.  Currently it
is ignoring the returns from the function calls.  Fix this by
removing the status return checks and only break from the loop
at the very end when we know that all the success condtions have
been met.

Kudos to Dan Carpenter for describing the correct fix and
Vladimir Oltean for noting the change to the check on the number
of retries.

Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: 8aa9ebccae ("net: dsa: Introduce driver for NXP SJA1105 5-port L2 switch")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Tested-by: Vladimir Oltean <olteanv@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2019-05-08 13:13:25 -07:00
..
accessibility
acpi Driver core/kobject patches for 5.2-rc1 2019-05-07 13:01:40 -07:00
amba
android Char/Misc patches for 5.2-rc1 - part 2 2019-05-07 13:39:22 -07:00
ata ahci: qoriq: add ls1028a platforms support 2019-04-09 08:16:43 -06:00
atm Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net 2019-04-25 23:52:29 -04:00
auxdisplay
base Driver core/kobject patches for 5.2-rc1 2019-05-07 13:01:40 -07:00
bcma
block Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next 2019-05-07 22:03:58 -07:00
bluetooth Bluetooth: hci_qca: Rename STATE_<flags> to QCA_<flags> 2019-05-05 19:34:00 +02:00
bus
cdrom Revert "block: unexport DISK_EVENT_MEDIA_CHANGE for legacy/fringe drivers" 2019-04-12 13:35:27 -06:00
char Initialize the random driver earler; fix CRNG initialization when we 2019-05-07 21:42:23 -07:00
clk Allwinner clocks fixes for 5.1 2019-04-19 13:06:58 -07:00
clocksource Staging / IIO driver patches for 5.2-rc1 2019-05-07 13:31:29 -07:00
connector
counter counter: add FlexTimer Module Quadrature decoder counter driver 2019-04-25 21:33:41 +02:00
cpufreq Printk changes for 5.2 2019-05-07 09:18:12 -07:00
cpuidle cpuidle: Export the next timer expiration for CPUs 2019-04-10 00:32:34 +02:00
crypto Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6 2019-05-06 20:15:06 -07:00
dax dax: make use of ->free_inode() 2019-05-01 22:43:26 -04:00
dca
devfreq PM / devfreq: add tracing for scheduling work 2019-04-16 09:29:18 +09:00
dio
dma Remove Mysterious Macro Intended to Obscure Weird Behaviours (mmiowb()) 2019-05-06 16:57:52 -07:00
dma-buf Make anon_inodes unconditional 2019-04-19 14:03:11 +02:00
edac Merge branch 'ras-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip 2019-05-06 19:54:57 -07:00
eisa
extcon Char/Misc patches for 5.2-rc1 - part 2 2019-05-07 13:39:22 -07:00
firewire stream_open related patches for Linux 5.2 2019-05-07 12:15:13 -07:00
firmware Char/Misc patches for 5.2-rc1 - part 2 2019-05-07 13:39:22 -07:00
fmc
fpga
fsi
gnss Char/Misc patches for 5.2-rc1 - part 2 2019-05-07 13:39:22 -07:00
gpio pidfd patches for v5.2-rc1 2019-05-07 12:30:24 -07:00
gpu Merge branch 'work.file' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs 2019-05-07 20:34:21 -07:00
hid stream_open related patches for Linux 5.2 2019-05-07 12:15:13 -07:00
hsi
hv Drivers: hv: vmbus: Remove the undesired put_cpu_ptr() in hv_synic_cleanup() 2019-04-13 09:36:35 -04:00
hwmon stream_open related patches for Linux 5.2 2019-05-07 12:15:13 -07:00
hwspinlock
hwtracing Char/Misc patches for 5.2-rc1 - part 2 2019-05-07 13:39:22 -07:00
i2c Merge branch 'i2c/for-current-fixed' of ssh://gitolite.kernel.org/pub/scm/linux/kernel/git/wsa/linux 2019-05-03 11:42:01 -07:00
i3c * Fix a shift wrap bug in the core 2019-05-07 08:50:40 -07:00
ide for-5.2/block-20190507 2019-05-07 18:14:36 -07:00
idle
iio Staging / IIO driver patches for 5.2-rc1 2019-05-07 13:31:29 -07:00
infiniband Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next 2019-05-07 22:03:58 -07:00
input *: convert stream-like files from nonseekable_open -> stream_open 2019-05-06 17:46:41 +03:00
interconnect interconnect: convert to DEFINE_SHOW_ATTRIBUTE 2019-04-06 22:03:03 +07:00
iommu iommu/amd: Set exclusion range correctly 2019-04-12 12:59:45 +02:00
ipack
irqchip Driver core/kobject patches for 5.2-rc1 2019-05-07 13:01:40 -07:00
isdn Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next 2019-05-07 22:03:58 -07:00
leds LED updates for 5.2-rc1. 2019-05-07 18:02:51 -07:00
lightnvm lightnvm: pblk: fix crash in pblk_end_partial_read due to multipage bvecs 2019-04-10 12:17:01 -06:00
macintosh
mailbox acpi: Create subtable parsing infrastructure 2019-04-04 18:41:12 +02:00
mcb
md for-5.2/block-20190507 2019-05-07 18:14:36 -07:00
media Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next 2019-05-07 22:03:58 -07:00
memory
memstick MMC core: 2019-05-07 12:56:19 -07:00
message
mfd LED updates for 5.2-rc1. 2019-05-07 18:02:51 -07:00
misc Char/Misc patches for 5.2-rc1 - part 2 2019-05-07 13:39:22 -07:00
mmc MMC core: 2019-05-07 12:56:19 -07:00
mtd Remove Mysterious Macro Intended to Obscure Weird Behaviours (mmiowb()) 2019-05-06 16:57:52 -07:00
mux
net net: dsa: sja1105: fix check on while loop exit 2019-05-08 13:13:25 -07:00
nfc Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next 2019-05-07 22:03:58 -07:00
ntb drivers: Remove explicit invocations of mmiowb() 2019-04-08 12:01:02 +01:00
nubus
nvdimm for-5.2/block-20190507 2019-05-07 18:14:36 -07:00
nvme for-5.2/block-20190507 2019-05-07 18:14:36 -07:00
nvmem nvmem: core: add NVMEM_SYSFS Kconfig 2019-04-25 19:44:33 +02:00
of Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next 2019-05-07 22:03:58 -07:00
opp OPP: Introduce dev_pm_opp_find_freq_ceil_by_volt() 2019-04-10 12:13:31 +05:30
oprofile
parisc parisc: Skip registering LED when running in QEMU 2019-05-03 23:47:39 +02:00
parport parport: ieee1284: mark expected switch fall-through 2019-04-25 19:41:47 +02:00
pci stream_open related patches for Linux 5.2 2019-05-07 12:15:13 -07:00
pcmcia
perf perf/arm-ccn: Clean up CPU hotplug handling 2019-04-23 12:29:37 +01:00
phy phy: for 5.1-rc 2019-04-25 11:27:48 +02:00
pinctrl
platform *: convert stream-like files from nonseekable_open -> stream_open 2019-05-06 17:46:41 +03:00
pnp treewide: Switch printk users from %pf and %pF to %ps and %pS, respectively 2019-04-09 14:19:06 +02:00
power Power Supply Fixes for 5.1 cycle 2019-05-01 14:57:23 -07:00
powercap
pps
ps3
ptp
pwm drivers/pwm: pwm-fsl-ftm: use common header for FlexTimer #defines 2019-04-25 21:33:41 +02:00
rapidio
ras RAS/CEC: Increment cec_entered under the mutex lock 2019-04-20 12:16:52 +02:00
regulator Merge branch 'regulator-5.2' into regulator-next 2019-05-06 22:52:14 +09:00
remoteproc
reset reset: meson-audio-arb: Fix missing .owner setting of reset_controller_dev 2019-03-25 16:22:10 +01:00
rpmsg
rtc *: convert stream-like files from nonseekable_open -> stream_open 2019-05-06 17:46:41 +03:00
s390 Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next 2019-05-07 22:03:58 -07:00
sbus
scsi for-5.2/block-20190507 2019-05-07 18:14:36 -07:00
sfi
sh
siox
slimbus slimbus: fix a potential NULL pointer dereference in of_qcom_slim_ngd_register 2019-04-25 22:23:06 +02:00
sn
soc
soundwire soundwire: add a blank line between functions 2019-05-02 17:17:51 +02:00
spi Staging / IIO driver patches for 5.2-rc1 2019-05-07 13:31:29 -07:00
spmi
ssb Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next 2019-05-07 22:03:58 -07:00
staging Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next 2019-05-07 22:03:58 -07:00
target Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next 2019-05-07 22:03:58 -07:00
tc
tee
thermal ACPICA: Rename nameseg length macro/define for clarity 2019-04-09 11:24:48 +02:00
thunderbolt Char/Misc patches for 5.2-rc1 - part 2 2019-05-07 13:39:22 -07:00
tty Staging / IIO driver patches for 5.2-rc1 2019-05-07 13:31:29 -07:00
uio
usb stream_open related patches for Linux 5.2 2019-05-07 12:15:13 -07:00
uwb
vfio Make anon_inodes unconditional 2019-04-19 14:03:11 +02:00
vhost vhost: reject zero size iova range 2019-04-10 22:45:38 -07:00
video efifb: Omit memory map check on legacy boot 2019-03-29 07:34:59 +01:00
virt virt: vbox: Sanity-check parameter types for hgcm-calls coming from userspace 2019-04-25 21:52:40 +02:00
virtio virtio: Honour 'may_reduce_num' in vring_create_virtqueue 2019-04-08 17:05:52 -04:00
visorbus
vlynq
vme
w1 Char/Misc patches for 5.2-rc1 - part 2 2019-05-07 13:39:22 -07:00
watchdog stream_open related patches for Linux 5.2 2019-05-07 12:15:13 -07:00
xen Merge branch 'stable/for-linus-5.2' of git://git.kernel.org/pub/scm/linux/kernel/git/konrad/swiotlb 2019-05-07 18:45:27 -07:00
zorro
Kconfig counter: Introduce the Generic Counter interface 2019-04-25 21:33:37 +02:00
Makefile counter: Introduce the Generic Counter interface 2019-04-25 21:33:37 +02:00