mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-21 08:19:28 +00:00
94dfc73e7c
There is a regular need in the kernel to provide a way to declare
having a dynamically sized set of trailing elements in a structure.
Kernel code should always use “flexible array members”[1] for these
cases. The older style of one-element or zero-length arrays should
no longer be used[2].
This code was transformed with the help of Coccinelle:
(linux-5.19-rc2$ spatch --jobs $(getconf _NPROCESSORS_ONLN) --sp-file script.cocci --include-headers --dir . > output.patch)
@@
identifier S, member, array;
type T1, T2;
@@
struct S {
...
T1 member;
T2 array[
- 0
];
};
-fstrict-flex-arrays=3 is coming and we need to land these changes
to prevent issues like these in the short future:
../fs/minix/dir.c:337:3: warning: 'strcpy' will always overflow; destination buffer has size 0,
but the source string has length 2 (including NUL byte) [-Wfortify-source]
strcpy(de3->name, ".");
^
Since these are all [0] to [] changes, the risk to UAPI is nearly zero. If
this breaks anything, we can use a union with a new member name.
[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays
Link: https://github.com/KSPP/linux/issues/78
Build-tested-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/lkml/62b675ec.wKX6AOZ6cbE71vtF%25lkp@intel.com/
Acked-by: Dan Williams <dan.j.williams@intel.com> # For ndctl.h
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
133 lines
2.9 KiB
C
133 lines
2.9 KiB
C
/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
|
|
#ifndef __NET_DROPMON_H
|
|
#define __NET_DROPMON_H
|
|
|
|
#include <linux/types.h>
|
|
#include <linux/netlink.h>
|
|
|
|
struct net_dm_drop_point {
|
|
__u8 pc[8];
|
|
__u32 count;
|
|
};
|
|
|
|
#define is_drop_point_hw(x) do {\
|
|
int ____i, ____j;\
|
|
for (____i = 0; ____i < 8; i ____i++)\
|
|
____j |= x[____i];\
|
|
____j;\
|
|
} while (0)
|
|
|
|
#define NET_DM_CFG_VERSION 0
|
|
#define NET_DM_CFG_ALERT_COUNT 1
|
|
#define NET_DM_CFG_ALERT_DELAY 2
|
|
#define NET_DM_CFG_MAX 3
|
|
|
|
struct net_dm_config_entry {
|
|
__u32 type;
|
|
__u64 data __attribute__((aligned(8)));
|
|
};
|
|
|
|
struct net_dm_config_msg {
|
|
__u32 entries;
|
|
struct net_dm_config_entry options[];
|
|
};
|
|
|
|
struct net_dm_alert_msg {
|
|
__u32 entries;
|
|
struct net_dm_drop_point points[];
|
|
};
|
|
|
|
struct net_dm_user_msg {
|
|
union {
|
|
struct net_dm_config_msg user;
|
|
struct net_dm_alert_msg alert;
|
|
} u;
|
|
};
|
|
|
|
|
|
/* These are the netlink message types for this protocol */
|
|
|
|
enum {
|
|
NET_DM_CMD_UNSPEC = 0,
|
|
NET_DM_CMD_ALERT,
|
|
NET_DM_CMD_CONFIG,
|
|
NET_DM_CMD_START,
|
|
NET_DM_CMD_STOP,
|
|
NET_DM_CMD_PACKET_ALERT,
|
|
NET_DM_CMD_CONFIG_GET,
|
|
NET_DM_CMD_CONFIG_NEW,
|
|
NET_DM_CMD_STATS_GET,
|
|
NET_DM_CMD_STATS_NEW,
|
|
_NET_DM_CMD_MAX,
|
|
};
|
|
|
|
#define NET_DM_CMD_MAX (_NET_DM_CMD_MAX - 1)
|
|
|
|
/*
|
|
* Our group identifiers
|
|
*/
|
|
#define NET_DM_GRP_ALERT 1
|
|
|
|
enum net_dm_attr {
|
|
NET_DM_ATTR_UNSPEC,
|
|
|
|
NET_DM_ATTR_ALERT_MODE, /* u8 */
|
|
NET_DM_ATTR_PC, /* u64 */
|
|
NET_DM_ATTR_SYMBOL, /* string */
|
|
NET_DM_ATTR_IN_PORT, /* nested */
|
|
NET_DM_ATTR_TIMESTAMP, /* u64 */
|
|
NET_DM_ATTR_PROTO, /* u16 */
|
|
NET_DM_ATTR_PAYLOAD, /* binary */
|
|
NET_DM_ATTR_PAD,
|
|
NET_DM_ATTR_TRUNC_LEN, /* u32 */
|
|
NET_DM_ATTR_ORIG_LEN, /* u32 */
|
|
NET_DM_ATTR_QUEUE_LEN, /* u32 */
|
|
NET_DM_ATTR_STATS, /* nested */
|
|
NET_DM_ATTR_HW_STATS, /* nested */
|
|
NET_DM_ATTR_ORIGIN, /* u16 */
|
|
NET_DM_ATTR_HW_TRAP_GROUP_NAME, /* string */
|
|
NET_DM_ATTR_HW_TRAP_NAME, /* string */
|
|
NET_DM_ATTR_HW_ENTRIES, /* nested */
|
|
NET_DM_ATTR_HW_ENTRY, /* nested */
|
|
NET_DM_ATTR_HW_TRAP_COUNT, /* u32 */
|
|
NET_DM_ATTR_SW_DROPS, /* flag */
|
|
NET_DM_ATTR_HW_DROPS, /* flag */
|
|
NET_DM_ATTR_FLOW_ACTION_COOKIE, /* binary */
|
|
NET_DM_ATTR_REASON, /* string */
|
|
|
|
__NET_DM_ATTR_MAX,
|
|
NET_DM_ATTR_MAX = __NET_DM_ATTR_MAX - 1
|
|
};
|
|
|
|
/**
|
|
* enum net_dm_alert_mode - Alert mode.
|
|
* @NET_DM_ALERT_MODE_SUMMARY: A summary of recent drops is sent to user space.
|
|
* @NET_DM_ALERT_MODE_PACKET: Each dropped packet is sent to user space along
|
|
* with metadata.
|
|
*/
|
|
enum net_dm_alert_mode {
|
|
NET_DM_ALERT_MODE_SUMMARY,
|
|
NET_DM_ALERT_MODE_PACKET,
|
|
};
|
|
|
|
enum {
|
|
NET_DM_ATTR_PORT_NETDEV_IFINDEX, /* u32 */
|
|
NET_DM_ATTR_PORT_NETDEV_NAME, /* string */
|
|
|
|
__NET_DM_ATTR_PORT_MAX,
|
|
NET_DM_ATTR_PORT_MAX = __NET_DM_ATTR_PORT_MAX - 1
|
|
};
|
|
|
|
enum {
|
|
NET_DM_ATTR_STATS_DROPPED, /* u64 */
|
|
|
|
__NET_DM_ATTR_STATS_MAX,
|
|
NET_DM_ATTR_STATS_MAX = __NET_DM_ATTR_STATS_MAX - 1
|
|
};
|
|
|
|
enum net_dm_origin {
|
|
NET_DM_ORIGIN_SW,
|
|
NET_DM_ORIGIN_HW,
|
|
};
|
|
|
|
#endif
|