mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 19:00:25 +00:00
![Geert Uytterhoeven](/assets/img/avatar_default.png)
On Armadillo-800-EVA with CONFIG_DEBUG_SPINLOCK=y: BUG: spinlock bad magic on CPU#0, swapper/1 lock: lcdc0_device+0x10c/0x308, .magic: 00000000, .owner: <none>/-1, .owner_cpu: 0 CPU: 0 PID: 1 Comm: swapper Not tainted 5.11.0-rc5-armadillo-00036-gbbca04be7a80-dirty #287 Hardware name: Generic R8A7740 (Flattened Device Tree) [<c010c3c8>] (unwind_backtrace) from [<c010a49c>] (show_stack+0x10/0x14) [<c010a49c>] (show_stack) from [<c0159534>] (do_raw_spin_lock+0x20/0x94) [<c0159534>] (do_raw_spin_lock) from [<c040858c>] (dev_pm_get_subsys_data+0x8c/0x11c) [<c040858c>] (dev_pm_get_subsys_data) from [<c05fbcac>] (genpd_add_device+0x78/0x2b8) [<c05fbcac>] (genpd_add_device) from [<c0412db4>] (of_genpd_add_device+0x34/0x4c) [<c0412db4>] (of_genpd_add_device) from [<c0a1ea74>] (board_staging_register_device+0x11c/0x148) [<c0a1ea74>] (board_staging_register_device) from [<c0a1eac4>] (board_staging_register_devices+0x24/0x28) of_genpd_add_device() is called before platform_device_register(), as it needs to attach the genpd before the device is probed. But the spinlock is only initialized when the device is registered. Fix this by open-coding the spinlock initialization, cfr. device_pm_init_common() in the internal drivers/base code, and in the SuperH early platform code. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Link: https://lore.kernel.org/r/57783ece7ddae55f2bda2f59f452180bff744ea0.1626257398.git.geert+renesas@glider.be Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
204 lines
4.5 KiB
C
204 lines
4.5 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Copyright (C) 2014 Magnus Damm
|
|
* Copyright (C) 2015 Glider bvba
|
|
*/
|
|
|
|
#define pr_fmt(fmt) "board_staging: " fmt
|
|
|
|
#include <linux/clkdev.h>
|
|
#include <linux/init.h>
|
|
#include <linux/irq.h>
|
|
#include <linux/device.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/of.h>
|
|
#include <linux/of_address.h>
|
|
#include <linux/of_irq.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/pm_domain.h>
|
|
|
|
#include "board.h"
|
|
|
|
static struct device_node *irqc_node __initdata;
|
|
static unsigned int irqc_base __initdata;
|
|
|
|
static bool find_by_address(u64 base_address)
|
|
{
|
|
struct device_node *dn = of_find_all_nodes(NULL);
|
|
struct resource res;
|
|
|
|
while (dn) {
|
|
if (!of_address_to_resource(dn, 0, &res)) {
|
|
if (res.start == base_address) {
|
|
of_node_put(dn);
|
|
return true;
|
|
}
|
|
}
|
|
dn = of_find_all_nodes(dn);
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
bool __init board_staging_dt_node_available(const struct resource *resource,
|
|
unsigned int num_resources)
|
|
{
|
|
unsigned int i;
|
|
|
|
for (i = 0; i < num_resources; i++) {
|
|
const struct resource *r = resource + i;
|
|
|
|
if (resource_type(r) == IORESOURCE_MEM)
|
|
if (find_by_address(r->start))
|
|
return true; /* DT node available */
|
|
}
|
|
|
|
return false; /* Nothing found */
|
|
}
|
|
|
|
int __init board_staging_gic_setup_xlate(const char *gic_match,
|
|
unsigned int base)
|
|
{
|
|
WARN_ON(irqc_node);
|
|
|
|
irqc_node = of_find_compatible_node(NULL, NULL, gic_match);
|
|
|
|
WARN_ON(!irqc_node);
|
|
if (!irqc_node)
|
|
return -ENOENT;
|
|
|
|
irqc_base = base;
|
|
return 0;
|
|
}
|
|
|
|
static void __init gic_fixup_resource(struct resource *res)
|
|
{
|
|
struct of_phandle_args irq_data;
|
|
unsigned int hwirq = res->start;
|
|
unsigned int virq;
|
|
|
|
if (resource_type(res) != IORESOURCE_IRQ || !irqc_node)
|
|
return;
|
|
|
|
irq_data.np = irqc_node;
|
|
irq_data.args_count = 3;
|
|
irq_data.args[0] = 0;
|
|
irq_data.args[1] = hwirq - irqc_base;
|
|
switch (res->flags &
|
|
(IORESOURCE_IRQ_LOWEDGE | IORESOURCE_IRQ_HIGHEDGE |
|
|
IORESOURCE_IRQ_LOWLEVEL | IORESOURCE_IRQ_HIGHLEVEL)) {
|
|
case IORESOURCE_IRQ_LOWEDGE:
|
|
irq_data.args[2] = IRQ_TYPE_EDGE_FALLING;
|
|
break;
|
|
case IORESOURCE_IRQ_HIGHEDGE:
|
|
irq_data.args[2] = IRQ_TYPE_EDGE_RISING;
|
|
break;
|
|
case IORESOURCE_IRQ_LOWLEVEL:
|
|
irq_data.args[2] = IRQ_TYPE_LEVEL_LOW;
|
|
break;
|
|
case IORESOURCE_IRQ_HIGHLEVEL:
|
|
default:
|
|
irq_data.args[2] = IRQ_TYPE_LEVEL_HIGH;
|
|
break;
|
|
}
|
|
|
|
virq = irq_create_of_mapping(&irq_data);
|
|
if (WARN_ON(!virq))
|
|
return;
|
|
|
|
pr_debug("hwirq %u -> virq %u\n", hwirq, virq);
|
|
res->start = virq;
|
|
}
|
|
|
|
void __init board_staging_gic_fixup_resources(struct resource *res,
|
|
unsigned int nres)
|
|
{
|
|
unsigned int i;
|
|
|
|
for (i = 0; i < nres; i++)
|
|
gic_fixup_resource(&res[i]);
|
|
}
|
|
|
|
int __init board_staging_register_clock(const struct board_staging_clk *bsc)
|
|
{
|
|
int error;
|
|
|
|
pr_debug("Aliasing clock %s for con_id %s dev_id %s\n", bsc->clk,
|
|
bsc->con_id, bsc->dev_id);
|
|
error = clk_add_alias(bsc->con_id, bsc->dev_id, bsc->clk, NULL);
|
|
if (error)
|
|
pr_err("Failed to alias clock %s (%d)\n", bsc->clk, error);
|
|
|
|
return error;
|
|
}
|
|
|
|
#ifdef CONFIG_PM_GENERIC_DOMAINS_OF
|
|
static int board_staging_add_dev_domain(struct platform_device *pdev,
|
|
const char *domain)
|
|
{
|
|
struct device *dev = &pdev->dev;
|
|
struct of_phandle_args pd_args;
|
|
struct device_node *np;
|
|
|
|
np = of_find_node_by_path(domain);
|
|
if (!np) {
|
|
pr_err("Cannot find domain node %s\n", domain);
|
|
return -ENOENT;
|
|
}
|
|
|
|
pd_args.np = np;
|
|
pd_args.args_count = 0;
|
|
|
|
/* Initialization similar to device_pm_init_common() */
|
|
spin_lock_init(&dev->power.lock);
|
|
dev->power.early_init = true;
|
|
|
|
return of_genpd_add_device(&pd_args, dev);
|
|
}
|
|
#else
|
|
static inline int board_staging_add_dev_domain(struct platform_device *pdev,
|
|
const char *domain)
|
|
{
|
|
return 0;
|
|
}
|
|
#endif
|
|
|
|
int __init board_staging_register_device(const struct board_staging_dev *dev)
|
|
{
|
|
struct platform_device *pdev = dev->pdev;
|
|
unsigned int i;
|
|
int error;
|
|
|
|
pr_debug("Trying to register device %s\n", pdev->name);
|
|
if (board_staging_dt_node_available(pdev->resource,
|
|
pdev->num_resources)) {
|
|
pr_warn("Skipping %s, already in DT\n", pdev->name);
|
|
return -EEXIST;
|
|
}
|
|
|
|
board_staging_gic_fixup_resources(pdev->resource, pdev->num_resources);
|
|
|
|
for (i = 0; i < dev->nclocks; i++)
|
|
board_staging_register_clock(&dev->clocks[i]);
|
|
|
|
if (dev->domain)
|
|
board_staging_add_dev_domain(pdev, dev->domain);
|
|
|
|
error = platform_device_register(pdev);
|
|
if (error) {
|
|
pr_err("Failed to register device %s (%d)\n", pdev->name,
|
|
error);
|
|
return error;
|
|
}
|
|
|
|
return error;
|
|
}
|
|
|
|
void __init board_staging_register_devices(const struct board_staging_dev *devs,
|
|
unsigned int ndevs)
|
|
{
|
|
unsigned int i;
|
|
|
|
for (i = 0; i < ndevs; i++)
|
|
board_staging_register_device(&devs[i]);
|
|
}
|