mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 09:19:51 +00:00
![]() When CROS_EC_LPC is set to =m, we get a link failure for a
builtin wilco-ec module:
drivers/platform/chrome/wilco_ec/core.o: In function `wilco_ec_remove':
core.c:(.text+0x26): undefined reference to `cros_ec_lpc_mec_destroy'
drivers/platform/chrome/wilco_ec/core.o: In function `wilco_ec_probe':
core.c:(.text+0x18c): undefined reference to `cros_ec_lpc_mec_init'
core.c:(.text+0x224): undefined reference to `cros_ec_lpc_mec_destroy'
drivers/platform/chrome/wilco_ec/mailbox.o: In function `wilco_ec_mailbox':
mailbox.c:(.text+0x104): undefined reference to `cros_ec_lpc_io_bytes_mec'
The problem with the existing CROS_EC_LPC_MEC dependency is that this
is only for a 'bool' symbol, so the information about the exported
functions being in a module is lost on the way, and we actually have
to depend on both CROS_EC_LPC and CROS_EC_LPC_MEC.
Fixes:
|
||
---|---|---|
.. | ||
wilco_ec | ||
chromeos_laptop.c | ||
chromeos_pstore.c | ||
chromeos_tbmc.c | ||
cros_ec_debugfs.c | ||
cros_ec_i2c.c | ||
cros_ec_lightbar.c | ||
cros_ec_lpc.c | ||
cros_ec_lpc_mec.c | ||
cros_ec_lpc_mec.h | ||
cros_ec_lpc_reg.c | ||
cros_ec_lpc_reg.h | ||
cros_ec_proto.c | ||
cros_ec_spi.c | ||
cros_ec_sysfs.c | ||
cros_ec_vbc.c | ||
cros_kbd_led_backlight.c | ||
Kconfig | ||
Makefile |