Marcelo Ricardo Leitner 58b94d88de sctp: do not loose window information if in rwnd_over ... It's possible that we receive a packet that is larger than current window. If it's the first packet in this way, it will cause it to increase rwnd_over. Then, if we receive another data chunk (specially as SCTP allows you to have one data chunk in flight even during 0 window), rwnd_over will be overwritten instead of added to. In the long run, this could cause the window to grow bigger than its initial size, as rwnd_over would be charged only for the last received data chunk while the code will try open the window for all packets that were received and had its value in rwnd_over overwritten. This, then, can lead to the worsening of payload/buffer ratio and cause rwnd_press to kick in more often. The fix is to sum it too, same as is done for rwnd_press, so that if we receive 3 chunks after closing the window, we still have to release that same amount before re-opening it. Log snippet from sctp_test exhibiting the issue: [ 146.209232] sctp: sctp_assoc_rwnd_decrease: asoc:ffff88013928e000 rwnd decreased by 1 to (0, 1, 114221) [ 146.209232] sctp: sctp_assoc_rwnd_decrease: association:ffff88013928e000 has asoc->rwnd:0, asoc->rwnd_over:1! [ 146.209232] sctp: sctp_assoc_rwnd_decrease: asoc:ffff88013928e000 rwnd decreased by 1 to (0, 1, 114221) [ 146.209232] sctp: sctp_assoc_rwnd_decrease: association:ffff88013928e000 has asoc->rwnd:0, asoc->rwnd_over:1! [ 146.209232] sctp: sctp_assoc_rwnd_decrease: asoc:ffff88013928e000 rwnd decreased by 1 to (0, 1, 114221) [ 146.209232] sctp: sctp_assoc_rwnd_decrease: association:ffff88013928e000 has asoc->rwnd:0, asoc->rwnd_over:1! [ 146.209232] sctp: sctp_assoc_rwnd_decrease: asoc:ffff88013928e000 rwnd decreased by 1 to (0, 1, 114221) Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2016-12-23 14:01:35 -05:00
..
associola.c	sctp: do not loose window information if in rwnd_over	2016-12-23 14:01:35 -05:00
auth.c
bind_addr.c	sctp: not copying duplicate addrs to the assoc's bind address list	2016-12-20 14:15:45 -05:00
chunk.c
debug.c
endpointola.c	sctp: sctp_epaddr_lookup_transport should be protected by rcu_read_lock	2016-12-17 11:43:23 -05:00
input.c	sctp: use new rhlist interface on sctp transport rhashtable	2016-11-16 23:22:17 -05:00
inqueue.c
ipv6.c	sctp: hold transport instead of assoc when lookup assoc in rx path	2016-10-31 16:20:33 -04:00
Kconfig
Makefile
objcnt.c
offload.c
output.c	sctp: clean up sctp_packet_transmit	2016-11-02 15:03:13 -04:00
outqueue.c
primitive.c
probe.c
proc.c
protocol.c	sctp: not copying duplicate addrs to the assoc's bind address list	2016-12-20 14:15:45 -05:00
sctp_diag.c
sm_make_chunk.c
sm_sideeffect.c
sm_statefuns.c	sctp: validate chunk len before actually using it	2016-10-29 12:00:10 -04:00
sm_statetable.c
socket.c	sctp: sctp_transport_lookup_process should rcu_read_unlock when transport is null	2016-12-17 11:43:23 -05:00
ssnmap.c
sysctl.c
transport.c
tsnmap.c
ulpevent.c
ulpqueue.c