mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-28 20:02:17 +00:00
c32048d9e9
The dw_hdmi_setup_rx_sense exported function should not use struct device
to recover the dw-hdmi context using drvdata, but take struct dw_hdmi
directly like other exported functions.
This caused a regression using Meson DRM on S905X since v4.17-rc1 :
Internal error: Oops: 96000007 [#1] PREEMPT SMP
[...]
CPU: 0 PID: 124 Comm: irq/32-dw_hdmi_ Not tainted 4.17.0-rc7 #2
Hardware name: Libre Technology CC (DT)
[...]
pc : osq_lock+0x54/0x188
lr : __mutex_lock.isra.0+0x74/0x530
[...]
Process irq/32-dw_hdmi_ (pid: 124, stack limit = 0x00000000adf418cb)
Call trace:
osq_lock+0x54/0x188
__mutex_lock_slowpath+0x10/0x18
mutex_lock+0x30/0x38
__dw_hdmi_setup_rx_sense+0x28/0x98
dw_hdmi_setup_rx_sense+0x10/0x18
dw_hdmi_top_thread_irq+0x2c/0x50
irq_thread_fn+0x28/0x68
irq_thread+0x10c/0x1a0
kthread+0x128/0x130
ret_from_fork+0x10/0x18
Code: 34000964 d00050a2 51000484 9135c042 (f864d844)
---[ end trace 945641e1fbbc07da ]---
note: irq/32-dw_hdmi_[124] exited with preempt_count 1
genirq: exiting task "irq/32-dw_hdmi_" (124) is an active IRQ thread (irq 32)
Fixes: eea034af90 ("drm/bridge/synopsys: dw-hdmi: don't clobber drvdata")
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Tested-by: Koen Kooi <koen@dominion.thruhere.net>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/1527673438-20643-1-git-send-email-narmstrong@baylibre.com
175 lines
8.4 KiB
C
175 lines
8.4 KiB
C
/*
|
|
* Copyright (C) 2011 Freescale Semiconductor, Inc.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*/
|
|
|
|
#ifndef __DW_HDMI__
|
|
#define __DW_HDMI__
|
|
|
|
#include <drm/drmP.h>
|
|
|
|
struct dw_hdmi;
|
|
|
|
/**
|
|
* DOC: Supported input formats and encodings
|
|
*
|
|
* Depending on the Hardware configuration of the Controller IP, it supports
|
|
* a subset of the following input formats and encodings on its internal
|
|
* 48bit bus.
|
|
*
|
|
* +----------------------+----------------------------------+------------------------------+
|
|
* | Format Name | Format Code | Encodings |
|
|
* +----------------------+----------------------------------+------------------------------+
|
|
* | RGB 4:4:4 8bit | ``MEDIA_BUS_FMT_RGB888_1X24`` | ``V4L2_YCBCR_ENC_DEFAULT`` |
|
|
* +----------------------+----------------------------------+------------------------------+
|
|
* | RGB 4:4:4 10bits | ``MEDIA_BUS_FMT_RGB101010_1X30`` | ``V4L2_YCBCR_ENC_DEFAULT`` |
|
|
* +----------------------+----------------------------------+------------------------------+
|
|
* | RGB 4:4:4 12bits | ``MEDIA_BUS_FMT_RGB121212_1X36`` | ``V4L2_YCBCR_ENC_DEFAULT`` |
|
|
* +----------------------+----------------------------------+------------------------------+
|
|
* | RGB 4:4:4 16bits | ``MEDIA_BUS_FMT_RGB161616_1X48`` | ``V4L2_YCBCR_ENC_DEFAULT`` |
|
|
* +----------------------+----------------------------------+------------------------------+
|
|
* | YCbCr 4:4:4 8bit | ``MEDIA_BUS_FMT_YUV8_1X24`` | ``V4L2_YCBCR_ENC_601`` |
|
|
* | | | or ``V4L2_YCBCR_ENC_709`` |
|
|
* | | | or ``V4L2_YCBCR_ENC_XV601`` |
|
|
* | | | or ``V4L2_YCBCR_ENC_XV709`` |
|
|
* +----------------------+----------------------------------+------------------------------+
|
|
* | YCbCr 4:4:4 10bits | ``MEDIA_BUS_FMT_YUV10_1X30`` | ``V4L2_YCBCR_ENC_601`` |
|
|
* | | | or ``V4L2_YCBCR_ENC_709`` |
|
|
* | | | or ``V4L2_YCBCR_ENC_XV601`` |
|
|
* | | | or ``V4L2_YCBCR_ENC_XV709`` |
|
|
* +----------------------+----------------------------------+------------------------------+
|
|
* | YCbCr 4:4:4 12bits | ``MEDIA_BUS_FMT_YUV12_1X36`` | ``V4L2_YCBCR_ENC_601`` |
|
|
* | | | or ``V4L2_YCBCR_ENC_709`` |
|
|
* | | | or ``V4L2_YCBCR_ENC_XV601`` |
|
|
* | | | or ``V4L2_YCBCR_ENC_XV709`` |
|
|
* +----------------------+----------------------------------+------------------------------+
|
|
* | YCbCr 4:4:4 16bits | ``MEDIA_BUS_FMT_YUV16_1X48`` | ``V4L2_YCBCR_ENC_601`` |
|
|
* | | | or ``V4L2_YCBCR_ENC_709`` |
|
|
* | | | or ``V4L2_YCBCR_ENC_XV601`` |
|
|
* | | | or ``V4L2_YCBCR_ENC_XV709`` |
|
|
* +----------------------+----------------------------------+------------------------------+
|
|
* | YCbCr 4:2:2 8bit | ``MEDIA_BUS_FMT_UYVY8_1X16`` | ``V4L2_YCBCR_ENC_601`` |
|
|
* | | | or ``V4L2_YCBCR_ENC_709`` |
|
|
* +----------------------+----------------------------------+------------------------------+
|
|
* | YCbCr 4:2:2 10bits | ``MEDIA_BUS_FMT_UYVY10_1X20`` | ``V4L2_YCBCR_ENC_601`` |
|
|
* | | | or ``V4L2_YCBCR_ENC_709`` |
|
|
* +----------------------+----------------------------------+------------------------------+
|
|
* | YCbCr 4:2:2 12bits | ``MEDIA_BUS_FMT_UYVY12_1X24`` | ``V4L2_YCBCR_ENC_601`` |
|
|
* | | | or ``V4L2_YCBCR_ENC_709`` |
|
|
* +----------------------+----------------------------------+------------------------------+
|
|
* | YCbCr 4:2:0 8bit | ``MEDIA_BUS_FMT_UYYVYY8_0_5X24`` | ``V4L2_YCBCR_ENC_601`` |
|
|
* | | | or ``V4L2_YCBCR_ENC_709`` |
|
|
* +----------------------+----------------------------------+------------------------------+
|
|
* | YCbCr 4:2:0 10bits | ``MEDIA_BUS_FMT_UYYVYY10_0_5X30``| ``V4L2_YCBCR_ENC_601`` |
|
|
* | | | or ``V4L2_YCBCR_ENC_709`` |
|
|
* +----------------------+----------------------------------+------------------------------+
|
|
* | YCbCr 4:2:0 12bits | ``MEDIA_BUS_FMT_UYYVYY12_0_5X36``| ``V4L2_YCBCR_ENC_601`` |
|
|
* | | | or ``V4L2_YCBCR_ENC_709`` |
|
|
* +----------------------+----------------------------------+------------------------------+
|
|
* | YCbCr 4:2:0 16bits | ``MEDIA_BUS_FMT_UYYVYY16_0_5X48``| ``V4L2_YCBCR_ENC_601`` |
|
|
* | | | or ``V4L2_YCBCR_ENC_709`` |
|
|
* +----------------------+----------------------------------+------------------------------+
|
|
*/
|
|
|
|
enum {
|
|
DW_HDMI_RES_8,
|
|
DW_HDMI_RES_10,
|
|
DW_HDMI_RES_12,
|
|
DW_HDMI_RES_MAX,
|
|
};
|
|
|
|
enum dw_hdmi_phy_type {
|
|
DW_HDMI_PHY_DWC_HDMI_TX_PHY = 0x00,
|
|
DW_HDMI_PHY_DWC_MHL_PHY_HEAC = 0xb2,
|
|
DW_HDMI_PHY_DWC_MHL_PHY = 0xc2,
|
|
DW_HDMI_PHY_DWC_HDMI_3D_TX_PHY_HEAC = 0xe2,
|
|
DW_HDMI_PHY_DWC_HDMI_3D_TX_PHY = 0xf2,
|
|
DW_HDMI_PHY_DWC_HDMI20_TX_PHY = 0xf3,
|
|
DW_HDMI_PHY_VENDOR_PHY = 0xfe,
|
|
};
|
|
|
|
struct dw_hdmi_mpll_config {
|
|
unsigned long mpixelclock;
|
|
struct {
|
|
u16 cpce;
|
|
u16 gmp;
|
|
} res[DW_HDMI_RES_MAX];
|
|
};
|
|
|
|
struct dw_hdmi_curr_ctrl {
|
|
unsigned long mpixelclock;
|
|
u16 curr[DW_HDMI_RES_MAX];
|
|
};
|
|
|
|
struct dw_hdmi_phy_config {
|
|
unsigned long mpixelclock;
|
|
u16 sym_ctr; /*clock symbol and transmitter control*/
|
|
u16 term; /*transmission termination value*/
|
|
u16 vlev_ctr; /* voltage level control */
|
|
};
|
|
|
|
struct dw_hdmi_phy_ops {
|
|
int (*init)(struct dw_hdmi *hdmi, void *data,
|
|
struct drm_display_mode *mode);
|
|
void (*disable)(struct dw_hdmi *hdmi, void *data);
|
|
enum drm_connector_status (*read_hpd)(struct dw_hdmi *hdmi, void *data);
|
|
void (*update_hpd)(struct dw_hdmi *hdmi, void *data,
|
|
bool force, bool disabled, bool rxsense);
|
|
void (*setup_hpd)(struct dw_hdmi *hdmi, void *data);
|
|
};
|
|
|
|
struct dw_hdmi_plat_data {
|
|
struct regmap *regm;
|
|
enum drm_mode_status (*mode_valid)(struct drm_connector *connector,
|
|
const struct drm_display_mode *mode);
|
|
unsigned long input_bus_format;
|
|
unsigned long input_bus_encoding;
|
|
|
|
/* Vendor PHY support */
|
|
const struct dw_hdmi_phy_ops *phy_ops;
|
|
const char *phy_name;
|
|
void *phy_data;
|
|
|
|
/* Synopsys PHY support */
|
|
const struct dw_hdmi_mpll_config *mpll_cfg;
|
|
const struct dw_hdmi_curr_ctrl *cur_ctr;
|
|
const struct dw_hdmi_phy_config *phy_config;
|
|
int (*configure_phy)(struct dw_hdmi *hdmi,
|
|
const struct dw_hdmi_plat_data *pdata,
|
|
unsigned long mpixelclock);
|
|
};
|
|
|
|
struct dw_hdmi *dw_hdmi_probe(struct platform_device *pdev,
|
|
const struct dw_hdmi_plat_data *plat_data);
|
|
void dw_hdmi_remove(struct dw_hdmi *hdmi);
|
|
void dw_hdmi_unbind(struct dw_hdmi *hdmi);
|
|
struct dw_hdmi *dw_hdmi_bind(struct platform_device *pdev,
|
|
struct drm_encoder *encoder,
|
|
const struct dw_hdmi_plat_data *plat_data);
|
|
|
|
void dw_hdmi_setup_rx_sense(struct dw_hdmi *hdmi, bool hpd, bool rx_sense);
|
|
|
|
void dw_hdmi_set_sample_rate(struct dw_hdmi *hdmi, unsigned int rate);
|
|
void dw_hdmi_audio_enable(struct dw_hdmi *hdmi);
|
|
void dw_hdmi_audio_disable(struct dw_hdmi *hdmi);
|
|
|
|
/* PHY configuration */
|
|
void dw_hdmi_phy_i2c_set_addr(struct dw_hdmi *hdmi, u8 address);
|
|
void dw_hdmi_phy_i2c_write(struct dw_hdmi *hdmi, unsigned short data,
|
|
unsigned char addr);
|
|
|
|
void dw_hdmi_phy_gen2_pddq(struct dw_hdmi *hdmi, u8 enable);
|
|
void dw_hdmi_phy_gen2_txpwron(struct dw_hdmi *hdmi, u8 enable);
|
|
void dw_hdmi_phy_reset(struct dw_hdmi *hdmi);
|
|
|
|
enum drm_connector_status dw_hdmi_phy_read_hpd(struct dw_hdmi *hdmi,
|
|
void *data);
|
|
void dw_hdmi_phy_update_hpd(struct dw_hdmi *hdmi, void *data,
|
|
bool force, bool disabled, bool rxsense);
|
|
void dw_hdmi_phy_setup_hpd(struct dw_hdmi *hdmi, void *data);
|
|
|
|
#endif /* __IMX_HDMI_H__ */
|