linux-stable/drivers/nfc
Johannes Berg 59ae1d127a networking: introduce and use skb_put_data()
A common pattern with skb_put() is to just want to memcpy()
some data into the new space, introduce skb_put_data() for
this.

An spatch similar to the one for skb_put_zero() converts many
of the places using it:

    @@
    identifier p, p2;
    expression len, skb, data;
    type t, t2;
    @@
    (
    -p = skb_put(skb, len);
    +p = skb_put_data(skb, data, len);
    |
    -p = (t)skb_put(skb, len);
    +p = skb_put_data(skb, data, len);
    )
    (
    p2 = (t2)p;
    -memcpy(p2, data, len);
    |
    -memcpy(p, data, len);
    )

    @@
    type t, t2;
    identifier p, p2;
    expression skb, data;
    @@
    t *p;
    ...
    (
    -p = skb_put(skb, sizeof(t));
    +p = skb_put_data(skb, data, sizeof(t));
    |
    -p = (t *)skb_put(skb, sizeof(t));
    +p = skb_put_data(skb, data, sizeof(t));
    )
    (
    p2 = (t2)p;
    -memcpy(p2, data, sizeof(*p));
    |
    -memcpy(p, data, sizeof(*p));
    )

    @@
    expression skb, len, data;
    @@
    -memcpy(skb_put(skb, len), data, len);
    +skb_put_data(skb, data, len);

(again, manually post-processed to retain some comments)

Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2017-06-16 11:48:37 -04:00
..
fdp networking: introduce and use skb_put_data() 2017-06-16 11:48:37 -04:00
microread nfc: mei: use module_mei_cl_driver macro 2016-10-28 08:21:21 -04:00
nfcmrvl networking: introduce and use skb_put_data() 2017-06-16 11:48:37 -04:00
nxp-nci networking: introduce and use skb_put_data() 2017-06-16 11:48:37 -04:00
pn533 networking: introduce and use skb_put_data() 2017-06-16 11:48:37 -04:00
pn544 NFC: pn544: Get rid of code duplication in ->probe() 2017-04-05 10:04:20 +02:00
s3fwrn5 networking: introduce and use skb_put_data() 2017-06-16 11:48:37 -04:00
st-nci nfc: st-nci: Move loopback usage from HCI to NCI 2016-05-04 01:51:42 +02:00
st21nfca networking: introduce and use skb_put_data() 2017-06-16 11:48:37 -04:00
st95hf NFC: st95hf: Fix build error 2015-12-29 19:06:12 +01:00
Kconfig NFC: remove TI nfcwilink driver 2017-04-01 23:04:30 +02:00
Makefile NFC: remove TI nfcwilink driver 2017-04-01 23:04:30 +02:00
mei_phy.c mei: bus: split RX and async notification callbacks 2016-11-17 16:37:49 +01:00
mei_phy.h mei: bus: complete variable rename of type struct mei_cl_device 2015-09-20 19:31:09 -07:00
nfcsim.c NFC: nfcsim: Simulate lost frames through debugfs entry 2016-07-19 23:24:49 +02:00
port100.c networking: introduce and use skb_put_data() 2017-06-16 11:48:37 -04:00
trf7970a.c NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage 2017-04-05 11:04:03 +02:00